[PATCH] dmaengine: idxd: skip irq free when wq type is not kernel

[PATCH] dmaengine: idxd: skip irq free when wq type is not kernel

[Dave Jiang]

Skip wq irq resources freeing when wq type is not kernel since the driver
skips the irq alloction during wq enable. Add check in wq type check in
idxd_wq_free_irq() to mirror idxd_wq_request_irq().

Fixes: 63c14ae6c161 ("dmaengine: idxd: refactor wq driver enable/disable operations")
Reported-by: Tony Zu <tony.zhu@intel.com>
Tested-by: Tony Zu <tony.zhu@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/device.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 93cbfd726904..19a6cfaf4371 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -1177,6 +1177,9 @@ void idxd_wq_free_irq(struct idxd_wq *wq)
 	struct idxd_device *idxd = wq->idxd;
 	struct idxd_irq_entry *ie = &wq->ie;
 
+	if (wq->type != IDXD_WQT_KERNEL)
+		return;
+
 	synchronize_irq(ie->vector);
 	free_irq(ie->vector, ie);
 	idxd_flush_pending_descs(ie);

Re: [PATCH] dmaengine: idxd: skip irq free when wq type is not kernel

[Vinod Koul]

On 05-05-22, 08:05, Dave Jiang wrote:
> Skip wq irq resources freeing when wq type is not kernel since the driver
> skips the irq alloction during wq enable. Add check in wq type check in
> idxd_wq_free_irq() to mirror idxd_wq_request_irq().

Applied, thanks

-- 
~Vinod