dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	<dmaengine@vger.kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>, Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] dmaengine: xilinx: dpdma: Fix compilation when !HAS_IOMEM
Date: Mon, 15 Feb 2021 08:40:06 +0100	[thread overview]
Message-ID: <a72ad176-991c-0884-b99d-86aa9ef948a8@xilinx.com> (raw)
In-Reply-To: <20210214034319.11569-1-laurent.pinchart@ideasonboard.com>



On 2/14/21 4:43 AM, Laurent Pinchart wrote:
> The xilinx-dpdma driver uses the devm_platform_ioremap_resource() API,
> which is only available when HAS_IOMEM is selected. Depend on the
> Kconfig symbol to fix the error.
> 
> While at it, also depend on ARCH_ZYNQ to avoid cluttering the
> configuration on other platforms, unless COMPILE_TEST is selected. The
> former would be enough to guarantee HAS_IOMEM, but with COMPILE_TEST we
> still need to explicit dependendy on HAS_IOMEM.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/dma/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index d242c7632621..205bc888d49f 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -702,6 +702,8 @@ config XILINX_ZYNQMP_DMA
>  
>  config XILINX_ZYNQMP_DPDMA
>  	tristate "Xilinx DPDMA Engine"
> +	depends on ARCH_ZYNQ || COMPILE_TEST

Zynq doesn't have DP.

ARCH_ZYNQMP here?

M

      reply	other threads:[~2021-02-15  7:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14  3:43 [PATCH] dmaengine: xilinx: dpdma: Fix compilation when !HAS_IOMEM Laurent Pinchart
2021-02-15  7:40 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a72ad176-991c-0884-b99d-86aa9ef948a8@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).