* [PATCH] dmaengine: xilinx: dpdma: Fix compilation when !HAS_IOMEM
@ 2021-02-14 3:43 Laurent Pinchart
2021-02-15 7:40 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2021-02-14 3:43 UTC (permalink / raw)
To: dmaengine; +Cc: Vinod Koul, Michal Simek
The xilinx-dpdma driver uses the devm_platform_ioremap_resource() API,
which is only available when HAS_IOMEM is selected. Depend on the
Kconfig symbol to fix the error.
While at it, also depend on ARCH_ZYNQ to avoid cluttering the
configuration on other platforms, unless COMPILE_TEST is selected. The
former would be enough to guarantee HAS_IOMEM, but with COMPILE_TEST we
still need to explicit dependendy on HAS_IOMEM.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/dma/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index d242c7632621..205bc888d49f 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -702,6 +702,8 @@ config XILINX_ZYNQMP_DMA
config XILINX_ZYNQMP_DPDMA
tristate "Xilinx DPDMA Engine"
+ depends on ARCH_ZYNQ || COMPILE_TEST
+ depends on HAS_IOMEM
select DMA_ENGINE
select DMA_VIRTUAL_CHANNELS
help
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: xilinx: dpdma: Fix compilation when !HAS_IOMEM
2021-02-14 3:43 [PATCH] dmaengine: xilinx: dpdma: Fix compilation when !HAS_IOMEM Laurent Pinchart
@ 2021-02-15 7:40 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2021-02-15 7:40 UTC (permalink / raw)
To: Laurent Pinchart, dmaengine; +Cc: Vinod Koul, Michal Simek
On 2/14/21 4:43 AM, Laurent Pinchart wrote:
> The xilinx-dpdma driver uses the devm_platform_ioremap_resource() API,
> which is only available when HAS_IOMEM is selected. Depend on the
> Kconfig symbol to fix the error.
>
> While at it, also depend on ARCH_ZYNQ to avoid cluttering the
> configuration on other platforms, unless COMPILE_TEST is selected. The
> former would be enough to guarantee HAS_IOMEM, but with COMPILE_TEST we
> still need to explicit dependendy on HAS_IOMEM.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/dma/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index d242c7632621..205bc888d49f 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -702,6 +702,8 @@ config XILINX_ZYNQMP_DMA
>
> config XILINX_ZYNQMP_DPDMA
> tristate "Xilinx DPDMA Engine"
> + depends on ARCH_ZYNQ || COMPILE_TEST
Zynq doesn't have DP.
ARCH_ZYNQMP here?
M
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-15 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-14 3:43 [PATCH] dmaengine: xilinx: dpdma: Fix compilation when !HAS_IOMEM Laurent Pinchart
2021-02-15 7:40 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).