DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] examples: modify error message for ip pipeline
@ 2019-06-14 14:05 Agalya Babu RadhaKrishnan
  2019-07-09  9:31 ` Dumitrescu, Cristian
  0 siblings, 1 reply; 2+ messages in thread
From: Agalya Babu RadhaKrishnan @ 2019-06-14 14:05 UTC (permalink / raw)
  To: dev; +Cc: reshma.pattan, cristian.dumitrescu, Agalya Babu RadhaKrishnan

From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>

Added help command in error message for ip pipeline commands.

Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
---
 examples/ip_pipeline/cli.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 309b2936e..8a651bbbc 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -30,12 +30,12 @@
 
 #define MSG_OUT_OF_MEMORY   "Not enough memory.\n"
 #define MSG_CMD_UNKNOWN     "Unknown command \"%s\".\n"
-#define MSG_CMD_UNIMPLEM    "Command \"%s\" not implemented.\n"
-#define MSG_ARG_NOT_ENOUGH  "Not enough arguments for command \"%s\".\n"
-#define MSG_ARG_TOO_MANY    "Too many arguments for command \"%s\".\n"
-#define MSG_ARG_MISMATCH    "Wrong number of arguments for command \"%s\".\n"
-#define MSG_ARG_NOT_FOUND   "Argument \"%s\" not found.\n"
-#define MSG_ARG_INVALID     "Invalid value for argument \"%s\".\n"
+#define MSG_CMD_UNIMPLEM    "Command \"%s\" not implemented. Try help <cmd>\n"
+#define MSG_ARG_NOT_ENOUGH  "Not enough arguments for command \"%s\". Try help <cmd>\n"
+#define MSG_ARG_TOO_MANY    "Too many arguments for command \"%s\". Try help <cmd>\n"
+#define MSG_ARG_MISMATCH    "Wrong number of arguments for command \"%s\". Try help <cmd>\n"
+#define MSG_ARG_NOT_FOUND   "Argument \"%s\" not found. Try help <cmd>\n"
+#define MSG_ARG_INVALID     "Invalid value for argument \"%s\". Try help <cmd>\n"
 #define MSG_FILE_ERR        "Error in file \"%s\" at line %u.\n"
 #define MSG_FILE_NOT_ENOUGH "Not enough rules in file \"%s\".\n"
 #define MSG_CMD_FAIL        "Command \"%s\" failed.\n"
-- 
2.14.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] examples: modify error message for ip pipeline
  2019-06-14 14:05 [dpdk-dev] [PATCH] examples: modify error message for ip pipeline Agalya Babu RadhaKrishnan
@ 2019-07-09  9:31 ` Dumitrescu, Cristian
  0 siblings, 0 replies; 2+ messages in thread
From: Dumitrescu, Cristian @ 2019-07-09  9:31 UTC (permalink / raw)
  To: Babu Radhakrishnan, AgalyaX, dev; +Cc: Pattan, Reshma



> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Friday, June 14, 2019 3:06 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Babu Radhakrishnan, AgalyaX
> <agalyax.babu.radhakrishnan@intel.com>
> Subject: [PATCH] examples: modify error message for ip pipeline
> 
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> 
> Added help command in error message for ip pipeline commands.
> 
> Signed-off-by: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan@intel.com>
> ---
>  examples/ip_pipeline/cli.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index 309b2936e..8a651bbbc 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -30,12 +30,12 @@
> 
>  #define MSG_OUT_OF_MEMORY   "Not enough memory.\n"
>  #define MSG_CMD_UNKNOWN     "Unknown command \"%s\".\n"
> -#define MSG_CMD_UNIMPLEM    "Command \"%s\" not implemented.\n"
> -#define MSG_ARG_NOT_ENOUGH  "Not enough arguments for command
> \"%s\".\n"
> -#define MSG_ARG_TOO_MANY    "Too many arguments for command
> \"%s\".\n"
> -#define MSG_ARG_MISMATCH    "Wrong number of arguments for
> command \"%s\".\n"
> -#define MSG_ARG_NOT_FOUND   "Argument \"%s\" not found.\n"
> -#define MSG_ARG_INVALID     "Invalid value for argument \"%s\".\n"
> +#define MSG_CMD_UNIMPLEM    "Command \"%s\" not implemented. Try
> help <cmd>\n"
> +#define MSG_ARG_NOT_ENOUGH  "Not enough arguments for command
> \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_TOO_MANY    "Too many arguments for command
> \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_MISMATCH    "Wrong number of arguments for
> command \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_NOT_FOUND   "Argument \"%s\" not found. Try help
> <cmd>\n"
> +#define MSG_ARG_INVALID     "Invalid value for argument \"%s\". Try help
> <cmd>\n"
>  #define MSG_FILE_ERR        "Error in file \"%s\" at line %u.\n"
>  #define MSG_FILE_NOT_ENOUGH "Not enough rules in file \"%s\".\n"
>  #define MSG_CMD_FAIL        "Command \"%s\" failed.\n"
> --
> 2.14.1

NAK

I don't see the value to add "try help command" on all the error messages, the user is already aware that there is a help command available, and some people might actually find this repetition annoying.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 14:05 [dpdk-dev] [PATCH] examples: modify error message for ip pipeline Agalya Babu RadhaKrishnan
2019-07-09  9:31 ` Dumitrescu, Cristian

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox