* [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed [not found] <1589887092-26360-1> @ 2020-07-10 3:29 ` luyicai 2020-07-11 1:20 ` Wei Hu (Xavier) 0 siblings, 1 reply; 3+ messages in thread From: luyicai @ 2020-07-10 3:29 UTC (permalink / raw) To: dev Cc: chas3, xavier.huwei, zhangliang, chenchanghu, jerry.lilijun, haifeng.lin, guohongzhi1, Yicai Lu, stable From: Yicai Lu <luyicai@huawei.com> When two host is connected directly without any devices like switch, rx_machine_update would recieving partner lacp negotiation packets, and partner's port mac is filled with zeros in this packet, which is different with internal's mode4 mac. So in this situation, it would never go rx_machine branch and then execute mac swap for negotiation! Thus bond mode 4 will negotiation failed. Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation") Cc: stable@dpdk.org Signed-off-by: luyicai <luyicai@huawei.com> --- v1 -> v2: Adjust commit info style --- drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index b77a37d..2002ec0 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -798,7 +798,8 @@ RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); partner = &lacp->lacpdu.partner; - if (rte_is_same_ether_addr(&partner->port_params.system, + if (rte_is_zero_ether_addr(&partner->port_params.system) || + rte_is_same_ether_addr(&partner->port_params.system, &internals->mode4.mac_addr)) { /* This LACP frame is sending to the bonding port * so pass it to rx_machine. -- 1.9.5.msysgit.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed 2020-07-10 3:29 ` [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed luyicai @ 2020-07-11 1:20 ` Wei Hu (Xavier) 2020-07-11 3:07 ` Ferruh Yigit 0 siblings, 1 reply; 3+ messages in thread From: Wei Hu (Xavier) @ 2020-07-11 1:20 UTC (permalink / raw) To: luyicai, dev, Thomas Monjalon Cc: chas3, zhangliang, chenchanghu, jerry.lilijun, haifeng.lin, guohongzhi1, stable, Wei Hu (Xavier) Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> On 2020/7/10 11:29, luyicai wrote: > From: Yicai Lu <luyicai@huawei.com> > > When two host is connected directly without any devices like switch, > rx_machine_update would recieving partner lacp negotiation packets, > and partner's port mac is filled with zeros in this packet, > which is different with internal's mode4 mac. So in this situation, > it would never go rx_machine branch and then execute mac swap for negotiation! > Thus bond mode 4 will negotiation failed. > > Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation") > Cc: stable@dpdk.org > > Signed-off-by: luyicai <luyicai@huawei.com> > --- > v1 -> v2: Adjust commit info style > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index b77a37d..2002ec0 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -798,7 +798,8 @@ > RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); > > partner = &lacp->lacpdu.partner; > - if (rte_is_same_ether_addr(&partner->port_params.system, > + if (rte_is_zero_ether_addr(&partner->port_params.system) || > + rte_is_same_ether_addr(&partner->port_params.system, > &internals->mode4.mac_addr)) { > /* This LACP frame is sending to the bonding port > * so pass it to rx_machine. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed 2020-07-11 1:20 ` Wei Hu (Xavier) @ 2020-07-11 3:07 ` Ferruh Yigit 0 siblings, 0 replies; 3+ messages in thread From: Ferruh Yigit @ 2020-07-11 3:07 UTC (permalink / raw) To: Wei Hu (Xavier), luyicai, dev, Thomas Monjalon Cc: chas3, zhangliang, chenchanghu, jerry.lilijun, haifeng.lin, guohongzhi1, stable On 7/11/2020 2:20 AM, Wei Hu (Xavier) wrote: > > On 2020/7/10 11:29, luyicai wrote: >> From: Yicai Lu <luyicai@huawei.com> >> >> When two host is connected directly without any devices like switch, >> rx_machine_update would recieving partner lacp negotiation packets, >> and partner's port mac is filled with zeros in this packet, >> which is different with internal's mode4 mac. So in this situation, >> it would never go rx_machine branch and then execute mac swap for negotiation! >> Thus bond mode 4 will negotiation failed. >> >> Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation") >> Cc: stable@dpdk.org >> >> Signed-off-by: luyicai <luyicai@huawei.com> > > Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> > Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-11 3:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1589887092-26360-1>
2020-07-10 3:29 ` [dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed luyicai
2020-07-11 1:20 ` Wei Hu (Xavier)
2020-07-11 3:07 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).