DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit
@ 2019-07-18 19:41 Dekel Peled
  2019-07-19  2:58 ` Jack Min
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dekel Peled @ 2019-07-18 19:41 UTC (permalink / raw)
  To: yskoh, viacheslavo, shahafs; +Cc: jackmin, orika, dev

The new define MLX5_FLOW_LAYER_IPIP is using the same value as
existing define MLX5_FLOW_LAYER_GRE_KEY.
This patch updates the values to be in order.

Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index ece967a..3f96bec 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -58,8 +58,8 @@
 #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)
 #define MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
 
-#define MLX5_FLOW_LAYER_IPIP (1u << 20)
-#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
+#define MLX5_FLOW_LAYER_IPIP (1u << 21)
+#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
 
 /* Outer Masks. */
 #define MLX5_FLOW_LAYER_OUTER_L3 \
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit
  2019-07-18 19:41 [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit Dekel Peled
@ 2019-07-19  2:58 ` Jack Min
  2019-07-19  4:28 ` Slava Ovsiienko
  2019-07-21  7:51 ` Raslan Darawsheh
  2 siblings, 0 replies; 4+ messages in thread
From: Jack Min @ 2019-07-19  2:58 UTC (permalink / raw)
  To: Dekel Peled; +Cc: Yongseok Koh, Slava Ovsiienko, Shahaf Shuler, Ori Kam, dev

On Thu, 19-07-18, 22:41, Dekel Peled wrote:
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as
> existing define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
> 
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index ece967a..3f96bec 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -58,8 +58,8 @@
>  #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)
>  #define MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
>  
> -#define MLX5_FLOW_LAYER_IPIP (1u << 20)
> -#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPIP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
>  
>  /* Outer Masks. */
>  #define MLX5_FLOW_LAYER_OUTER_L3 \
> -- 
> 1.8.3.1
> 
Acked-by: Xiaoyu Min <jackmin@mellanox.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit
  2019-07-18 19:41 [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit Dekel Peled
  2019-07-19  2:58 ` Jack Min
@ 2019-07-19  4:28 ` Slava Ovsiienko
  2019-07-21  7:51 ` Raslan Darawsheh
  2 siblings, 0 replies; 4+ messages in thread
From: Slava Ovsiienko @ 2019-07-19  4:28 UTC (permalink / raw)
  To: Dekel Peled, Yongseok Koh, Shahaf Shuler; +Cc: Jack Min, Ori Kam, dev

> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Thursday, July 18, 2019 22:42
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Jack Min <jackmin@mellanox.com>; Ori Kam <orika@mellanox.com>;
> dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix define of added tunnel layer bit
> 
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as existing
> define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
> 
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

> ---
>  drivers/net/mlx5/mlx5_flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index ece967a..3f96bec 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -58,8 +58,8 @@
>  #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)  #define
> MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
> 
> -#define MLX5_FLOW_LAYER_IPIP (1u << 20) -#define
> MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPIP (1u << 21) #define
> +MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
> 
>  /* Outer Masks. */
>  #define MLX5_FLOW_LAYER_OUTER_L3 \
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit
  2019-07-18 19:41 [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit Dekel Peled
  2019-07-19  2:58 ` Jack Min
  2019-07-19  4:28 ` Slava Ovsiienko
@ 2019-07-21  7:51 ` Raslan Darawsheh
  2 siblings, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2019-07-21  7:51 UTC (permalink / raw)
  To: Dekel Peled, Yongseok Koh, Slava Ovsiienko, Shahaf Shuler
  Cc: Jack Min, Ori Kam, dev

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Thursday, July 18, 2019 10:42 PM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Jack Min <jackmin@mellanox.com>; Ori Kam <orika@mellanox.com>;
> dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit
> 
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as existing
> define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
> 
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
> index ece967a..3f96bec 100644
> --- a/drivers/net/mlx5/mlx5_flow.h
> +++ b/drivers/net/mlx5/mlx5_flow.h
> @@ -58,8 +58,8 @@
>  #define MLX5_FLOW_LAYER_ICMP6 (1u << 19)  #define
> MLX5_FLOW_LAYER_GRE_KEY (1u << 20)
> 
> -#define MLX5_FLOW_LAYER_IPIP (1u << 20) -#define
> MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 21)
> +#define MLX5_FLOW_LAYER_IPIP (1u << 21) #define
> +MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22)
> 
>  /* Outer Masks. */
>  #define MLX5_FLOW_LAYER_OUTER_L3 \
> --
> 1.8.3.1

Applied to next-net-mlx,

Kindest regards
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 19:41 [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit Dekel Peled
2019-07-19  2:58 ` Jack Min
2019-07-19  4:28 ` Slava Ovsiienko
2019-07-21  7:51 ` Raslan Darawsheh

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git