DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci
@ 2019-08-09  9:29 Damian Nowak
  2019-10-15 13:42 ` Akhil Goyal
  2019-10-17 13:17 ` Trahe, Fiona
  0 siblings, 2 replies; 5+ messages in thread
From: Damian Nowak @ 2019-08-09  9:29 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, fiona.trahe, arkadiuszx.kusztal, Damian Nowak

When running auth NULL cases while using
vfio_pci, DMAR read/write faults appear. It
happens even if digest_length is set to 0.
This is caused by auth_res_addr initialized
as 0x0.

Fixes: 4e0955bddb08
Cc: Fiona Trahe <fiona.trahe@intel.com>

Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
---
 drivers/crypto/qat/qat_sym.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index 46ef27a..6aa514c 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -307,9 +307,8 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
 		}
 		min_ofs = auth_ofs;
 
-		if (likely(ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL))
-			auth_param->auth_res_addr =
-					op->sym->auth.digest.phys_addr;
+		auth_param->auth_res_addr =
+			op->sym->auth.digest.phys_addr;
 
 	}
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci
  2019-08-09  9:29 [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci Damian Nowak
@ 2019-10-15 13:42 ` Akhil Goyal
  2019-10-17 13:17 ` Trahe, Fiona
  1 sibling, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2019-10-15 13:42 UTC (permalink / raw)
  To: fiona.trahe; +Cc: arkadiuszx.kusztal, Damian Nowak, dev

Hi Fiona,

Could you please Ack the following change.

Thanks,
Akhil

> -----Original Message-----
> From: Damian Nowak <damianx.nowak@intel.com>
> Sent: Friday, August 9, 2019 2:59 PM
> To: dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; fiona.trahe@intel.com;
> arkadiuszx.kusztal@intel.com; Damian Nowak <damianx.nowak@intel.com>
> Subject: [PATCH] crypto/qat: fix null auth issues when using vfio_pci
> 
> When running auth NULL cases while using
> vfio_pci, DMAR read/write faults appear. It
> happens even if digest_length is set to 0.
> This is caused by auth_res_addr initialized
> as 0x0.
> 
> Fixes: 4e0955bddb08
> Cc: Fiona Trahe <fiona.trahe@intel.com>
> 
> Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
> ---
>  drivers/crypto/qat/qat_sym.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
> index 46ef27a..6aa514c 100644
> --- a/drivers/crypto/qat/qat_sym.c
> +++ b/drivers/crypto/qat/qat_sym.c
> @@ -307,9 +307,8 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
>  		}
>  		min_ofs = auth_ofs;
> 
> -		if (likely(ctx->qat_hash_alg !=
> ICP_QAT_HW_AUTH_ALGO_NULL))
> -			auth_param->auth_res_addr =
> -					op->sym->auth.digest.phys_addr;
> +		auth_param->auth_res_addr =
> +			op->sym->auth.digest.phys_addr;
> 
>  	}
> 
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci
  2019-08-09  9:29 [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci Damian Nowak
  2019-10-15 13:42 ` Akhil Goyal
@ 2019-10-17 13:17 ` Trahe, Fiona
  2019-10-21  9:43   ` Akhil Goyal
  1 sibling, 1 reply; 5+ messages in thread
From: Trahe, Fiona @ 2019-10-17 13:17 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, Kusztal, ArkadiuszX, Trahe, Fiona



> -----Original Message-----
> From: Nowak, DamianX
> Sent: Friday, August 9, 2019 10:29 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>; Nowak, DamianX <damianx.nowak@intel.com>
> Subject: [PATCH] crypto/qat: fix null auth issues when using vfio_pci
> 
> When running auth NULL cases while using
> vfio_pci, DMAR read/write faults appear. It
> happens even if digest_length is set to 0.
> This is caused by auth_res_addr initialized
> as 0x0.
> 
> Fixes: 4e0955bddb08
> Cc: Fiona Trahe <fiona.trahe@intel.com>
> 
> Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci
  2019-10-17 13:17 ` Trahe, Fiona
@ 2019-10-21  9:43   ` Akhil Goyal
  2019-10-21  9:44     ` Akhil Goyal
  0 siblings, 1 reply; 5+ messages in thread
From: Akhil Goyal @ 2019-10-21  9:43 UTC (permalink / raw)
  To: Trahe, Fiona, dev; +Cc: Kusztal, ArkadiuszX


> >
> > When running auth NULL cases while using
> > vfio_pci, DMAR read/write faults appear. It
> > happens even if digest_length is set to 0.
> > This is caused by auth_res_addr initialized
> > as 0x0.
> >
> > Fixes: 4e0955bddb08
> > Cc: Fiona Trahe <fiona.trahe@intel.com>
> >
> > Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto

Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci
  2019-10-21  9:43   ` Akhil Goyal
@ 2019-10-21  9:44     ` Akhil Goyal
  0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2019-10-21  9:44 UTC (permalink / raw)
  To: Trahe, Fiona, dev; +Cc: Kusztal, ArkadiuszX, stable


> 
> 
> > >
> > > When running auth NULL cases while using
> > > vfio_pci, DMAR read/write faults appear. It
> > > happens even if digest_length is set to 0.
> > > This is caused by auth_res_addr initialized
> > > as 0x0.
> > >
> > > Fixes: 4e0955bddb08
> > > Cc: Fiona Trahe <fiona.trahe@intel.com>
> > >
> > > Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> Applied to dpdk-next-crypto
> 
> Thanks

Cc: stable@dpdk.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09  9:29 [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci Damian Nowak
2019-10-15 13:42 ` Akhil Goyal
2019-10-17 13:17 ` Trahe, Fiona
2019-10-21  9:43   ` Akhil Goyal
2019-10-21  9:44     ` Akhil Goyal

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox