DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>
Cc: Luca Boccassi <bluca@debian.org>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org, stable@dpdk.org, iryzhov@nfware.com
Subject: Re: [dpdk-dev] [PATCH v3] kernel/linux: fix kernel dir for meson
Date: Wed, 4 Dec 2019 15:12:31 +0000
Message-ID: <20191204151231.GB61@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191204141821.GA26248@intel.com>

On Wed, Dec 04, 2019 at 10:18:21PM +0800, Ye Xiaolong wrote:
> On 12/04, Luca Boccassi wrote:
> >On Tue, 2019-12-03 at 23:59 +0800, Xiaolong Ye wrote:
> >> kernel_dir option in meson build is equivalent to RTE_KERNELDIR in
> >> make
> >> system, for cross-compilation case, users would specify it as local
> >> kernel src dir like
> >> 
> >> /<user local dir>/target-arm_glibc/linux-arm/linux-4.19.81/
> >> 
> >> Current meson build would fail to compile kernel module if user
> >> specify
> >> kernel_dir as above, this patch fixes this issue.
> >> 
> >> After this change, for normal build case, user can specify
> >> /lib/modules/<kernel_version> or /lib/modules/<kernel_version>/build
> >> as
> >> kernel_dir. For cross compilation case, user can specify any
> >> directory
> >> that contains kernel source code as the kernel_dir.
> >> 
> >> Fixes: 317832f97c16 ("kernel/linux: fix modules install path")
> >> Cc: 
> >> stable@dpdk.org
> >> 
> >> Cc: 
> >> iryzhov@nfware.com
> >> 
> >> 
> >> Signed-off-by: Xiaolong Ye <
> >> xiaolong.ye@intel.com
> >
> >The convention used by upstream and all distros is that kernel headers
> >are in <version>/build. Why can't the cross compilation case also
> >follow this convention, rather than adding complications to the
> 
> Yes, cross-compilation can follow this convention, but one common case is that
> users download and put kernel src (the same kernel that's running in the target machine)
> to one arbitrary dir, he then use this dir as kernel_dir to build kernel modules,
> it's extra burden for users to create extra build dir to hold the kernel headers.
> 

As part of the build of the kernel, do you not do a "modules_install" step,
which should set up things correctly for later builds?

/Bruce

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  6:14 [dpdk-dev] [PATCH] " Xiaolong Ye
2019-12-02  8:10 ` Igor Ryzhov
2019-12-02  8:39   ` Ye Xiaolong
2019-12-02  9:16     ` Igor Ryzhov
2019-12-02 11:34       ` Ye Xiaolong
2019-12-02 12:08         ` Bruce Richardson
2019-12-02 15:44           ` Ye Xiaolong
2019-12-03  5:33           ` Ye Xiaolong
2019-12-03 10:10             ` Bruce Richardson
2019-12-03  5:29 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-12-03 10:11   ` Bruce Richardson
2019-12-03 12:33     ` Ye Xiaolong
2019-12-03 13:58       ` Bruce Richardson
2019-12-03 15:01         ` Ye Xiaolong
2019-12-03 15:59 ` [dpdk-dev] [PATCH v3] " Xiaolong Ye
2019-12-04 13:51   ` Luca Boccassi
2019-12-04 14:18     ` Ye Xiaolong
2019-12-04 15:12       ` Bruce Richardson [this message]
2019-12-08  1:26         ` Ye Xiaolong
2019-12-09 12:12           ` Bruce Richardson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204151231.GB61@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=iryzhov@nfware.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git