Question for queue_start

Question for queue_start

[Zhang, Qi Z]

Hi:
         In rte_eth_dev_rx|tx_queue_start, dev_started is not checked

         Which mean we can call
         Rte_eth_rx_queue_setup
         Rte_eth_rx_qeueu_start

         And what we expected is the queue is started while device is still stopped, does this make sense?
         Should it return fail when device is not started?

Thanks
Qi

Re: Question for queue_start

[Ananyev, Konstantin]

Hi Qi, 


>Hi:
>       In rte_eth_dev_rx|tx_queue_start, dev_started is not checked
>         
>      Which mean we can call  
>         Rte_eth_rx_queue_setup
>         Rte_eth_rx_qeueu_start         
>
>         And what we expected is the queue is started while device is still stopped, does this make sense?
>         Should it return fail when device is not started?

Good point, I think we should.
Konstantin

>
>Thanks
>Qi

Re: Question for queue_start

[Thomas Monjalon]

22/03/2018 13:27, Ananyev, Konstantin:
> Hi Qi, 
> 
> 
> >Hi:
> >       In rte_eth_dev_rx|tx_queue_start, dev_started is not checked
> >         
> >      Which mean we can call  
> >         Rte_eth_rx_queue_setup
> >         Rte_eth_rx_qeueu_start         
> >
> >         And what we expected is the queue is started while device is still stopped, does this make sense?
> >         Should it return fail when device is not started?
> 
> Good point, I think we should.

Yes, I think there was no intent to start a queue of a stopped device.