From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Yasufumi Ogawa <yasufum.o@gmail.com>,
konstantin.ananyev@intel.com, david.marchand@redhat.com,
dev@dpdk.org
Cc: yasufumi.ogawa.gy@hco.ntt.co.jp,
Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Subject: Re: [dpdk-dev] [PATCH v8 1/1] fbarray: fix duplicated fbarray file in secondary
Date: Fri, 6 Dec 2019 10:44:32 +0000 [thread overview]
Message-ID: <2dc8c11a-ec17-7b26-b79e-bed4e6063f6b@intel.com> (raw)
In-Reply-To: <20191127084826.3519-2-yasufum.o@gmail.com>
On 27-Nov-19 8:48 AM, Yasufumi Ogawa wrote:
> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>
> In secondary_msl_create_walk(), it creates a file for fbarrays with its
> PID for reserving unique name among secondary processes. However, it
> does not work if several secondaries run as app containers because each
> of containerized secondary has PID 1, and failed to reserve unique name
> other than first one. To reserve unique name in each of containers, use
> hostname in addition to PID.
>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> ---
> lib/librte_eal/common/include/rte_fbarray.h | 7 ++++++-
> lib/librte_eal/linux/eal/eal_memalloc.c | 11 ++++++++---
> 2 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/rte_fbarray.h b/lib/librte_eal/common/include/rte_fbarray.h
> index 6dccdbec9..df003b8dc 100644
> --- a/lib/librte_eal/common/include/rte_fbarray.h
> +++ b/lib/librte_eal/common/include/rte_fbarray.h
> @@ -39,7 +39,12 @@ extern "C" {
> #include <rte_compat.h>
> #include <rte_rwlock.h>
>
> -#define RTE_FBARRAY_NAME_LEN 64
> +/* Filename of fbarray is defined as a combination of several params
> + * such as "fbarray_memseg-1048576k-0-0_PID_HOSTNAME".
> + * The length of string before PID can be 32bytes, and the length of
> + * PID can be 7bytes maximamly. Final 1 byte is for null terminator.
> + */
> +#define RTE_FBARRAY_NAME_LEN (32 + 7 + 1 + HOST_NAME_MAX + 1)
>
This breaks ABI, but i believe this doesn't break *stable* ABI, so it is OK.
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-12-06 10:44 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 1:59 [dpdk-dev] [PATCH] fbarray: get fbarrays from containerized secondary ogawa.yasufumi
2019-04-16 3:43 ` [dpdk-dev] [PATCH v2 0/1] Get " ogawa.yasufumi
2019-04-16 3:43 ` [dpdk-dev] [PATCH v2 1/1] fbarray: get " ogawa.yasufumi
2019-07-04 20:17 ` Thomas Monjalon
2019-07-05 8:53 ` Burakov, Anatoly
2019-07-09 10:22 ` Yasufumi Ogawa
2019-07-09 10:24 ` Burakov, Anatoly
2019-07-09 10:26 ` Burakov, Anatoly
2019-07-11 9:37 ` Yasufumi Ogawa
2019-07-11 9:43 ` Burakov, Anatoly
2019-07-11 10:31 ` [dpdk-dev] [PATCH v3 0/1] " yasufum.o
2019-07-11 10:31 ` [dpdk-dev] [PATCH v3 1/1] " yasufum.o
2019-07-11 10:53 ` Burakov, Anatoly
2019-07-11 11:57 ` Yasufumi Ogawa
2019-07-11 13:14 ` Burakov, Anatoly
2019-07-12 2:22 ` Yasufumi Ogawa
2019-07-22 1:06 ` Ogawa Yasufumi
2019-07-22 9:33 ` Burakov, Anatoly
2019-07-22 9:25 ` Burakov, Anatoly
2019-07-24 8:20 ` [dpdk-dev] [PATCH v4 0/1] " yasufum.o
2019-07-24 8:20 ` [dpdk-dev] [PATCH v4 1/1] " yasufum.o
2019-07-24 9:59 ` Burakov, Anatoly
2019-07-30 8:16 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-07-30 9:18 ` Burakov, Anatoly
2019-07-31 5:48 ` Yasufumi Ogawa
2019-10-11 9:36 ` [dpdk-dev] " David Marchand
2019-10-25 15:36 ` David Marchand
2019-10-25 19:54 ` Yasufumi Ogawa
2019-10-26 16:15 ` David Marchand
2019-10-26 18:11 ` Yasufumi Ogawa
2019-10-28 8:07 ` [dpdk-dev] [PATCH v5 0/1] fbarray: fix duplicated fbarray file in secondary yasufum.o
2019-10-28 8:07 ` [dpdk-dev] [PATCH v5 1/1] " yasufum.o
2019-10-29 12:03 ` Ananyev, Konstantin
2019-10-30 13:42 ` Yasufumi Ogawa
2019-10-30 19:00 ` Ananyev, Konstantin
2019-10-31 10:03 ` Yasufumi Ogawa
2019-10-31 10:32 ` Ananyev, Konstantin
2019-11-01 9:04 ` [dpdk-dev] [PATCH v6 0/1] " yasufum.o
2019-11-01 9:04 ` [dpdk-dev] [PATCH v6 1/1] " yasufum.o
2019-11-01 12:01 ` Ananyev, Konstantin
2019-11-04 10:20 ` Burakov, Anatoly
2019-11-05 10:13 ` David Marchand
2019-11-05 11:31 ` Burakov, Anatoly
2019-11-05 11:41 ` Ananyev, Konstantin
2019-11-06 10:37 ` Burakov, Anatoly
2019-11-08 3:19 ` Yasufumi Ogawa
2019-11-13 21:43 ` [dpdk-dev] [PATCH v7 0/1] " yasufum.o
2019-11-13 21:43 ` [dpdk-dev] [PATCH v7 1/1] " yasufum.o
2019-11-14 10:01 ` Burakov, Anatoly
2019-11-14 11:42 ` Yasufumi Ogawa
2019-11-14 12:27 ` David Marchand
2019-11-26 19:40 ` Yasufumi Ogawa
2019-11-27 10:26 ` Burakov, Anatoly
2019-11-29 5:44 ` Yasufumi Ogawa
2019-12-02 10:43 ` Burakov, Anatoly
2019-12-05 20:13 ` Yasufumi Ogawa
2019-11-14 12:55 ` David Marchand
2019-11-14 17:32 ` Ananyev, Konstantin
2019-11-27 8:48 ` [dpdk-dev] [PATCH v8 0/1] " Yasufumi Ogawa
2019-11-27 8:48 ` [dpdk-dev] [PATCH v8 1/1] " Yasufumi Ogawa
2019-12-06 10:44 ` Burakov, Anatoly [this message]
2019-12-06 13:18 ` Yasufumi Ogawa
2020-02-14 7:46 ` Yasufumi Ogawa
2020-02-14 15:08 ` David Marchand
2020-02-14 15:29 ` Thomas Monjalon
2020-02-17 12:54 ` Yasufumi Ogawa
2023-06-13 16:51 ` [dpdk-dev] [PATCH] fbarray: get fbarrays from containerized secondary Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dc8c11a-ec17-7b26-b79e-bed4e6063f6b@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=yasufum.o@gmail.com \
--cc=yasufumi.ogawa.gy@hco.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).