DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
@ 2019-08-02 13:29 David Marchand
  2019-08-02 16:04 ` Burakov, Anatoly
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: David Marchand @ 2019-08-02 13:29 UTC (permalink / raw)
  To: dev; +Cc: anatoly.burakov

This symbol has been deprecated for quite some time.
Let's drop it in the next release.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b57720c..3c98a5c 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -41,6 +41,9 @@ Deprecation Notices
 * eal: The ``rte_cpu_check_supported`` function has been deprecated since
   v17.08 and will be removed in DPDK 19.11.
 
+* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced
+  by ``rte_malloc_virt2iova`` since v17.11 and will be removed in DPDK 19.11.
+
 * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
   have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
   functions.  The due date for the removal targets DPDK 20.02.
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-02 13:29 [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal David Marchand
@ 2019-08-02 16:04 ` Burakov, Anatoly
  2019-08-02 16:10   ` Jerin Jacob Kollanukkaran
  2019-08-05 14:39 ` Thomas Monjalon
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Burakov, Anatoly @ 2019-08-02 16:04 UTC (permalink / raw)
  To: David Marchand, dev

On 02-Aug-19 2:29 PM, David Marchand wrote:
> This symbol has been deprecated for quite some time.
> Let's drop it in the next release.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-02 16:04 ` Burakov, Anatoly
@ 2019-08-02 16:10   ` Jerin Jacob Kollanukkaran
  0 siblings, 0 replies; 11+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-08-02 16:10 UTC (permalink / raw)
  To: Burakov, Anatoly, David Marchand, dev



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Burakov, Anatoly
> Sent: Friday, August 2, 2019 9:35 PM
> To: David Marchand <david.marchand@redhat.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol
> removal
> 
> On 02-Aug-19 2:29 PM, David Marchand wrote:
> > This symbol has been deprecated for quite some time.
> > Let's drop it in the next release.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>


Acked-by: Jerin Jacob <jerinj@marvell.com>

> 
> --
> Thanks,
> Anatoly

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-02 13:29 [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal David Marchand
  2019-08-02 16:04 ` Burakov, Anatoly
@ 2019-08-05 14:39 ` Thomas Monjalon
  2019-08-05 15:05   ` David Marchand
  2019-08-06 13:50 ` Andrew Rybchenko
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2019-08-05 14:39 UTC (permalink / raw)
  To: David Marchand
  Cc: dev, anatoly.burakov, bruce.richardson, Ray Kinsella, Traynor,
	Kevin, Stephen Hemminger

02/08/2019 15:29, David Marchand:
> This symbol has been deprecated for quite some time.
> Let's drop it in the next release.
> ---
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> +* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced
> +  by ``rte_malloc_virt2iova`` since v17.11 and will be removed in DPDK 19.11.

For this patch and another one about removing rte_cpu_check_supported(),
I have a general comment on the date of removal.

As was stated recently in the contribution guide:
	http://git.dpdk.org/dpdk/commit/?id=7abe4a24cc
	"Deprecated APIs are removed completely just after the next LTS."

The idea behind this policy is to avoid removals during LTS releases,
in order to have at least one release before X.11 LTS for end users
to prepare replacing the usage of the removed API.

Does it make sense to postpone any API removal after 19.11?



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-05 14:39 ` Thomas Monjalon
@ 2019-08-05 15:05   ` David Marchand
  2019-08-05 15:13     ` Thomas Monjalon
  0 siblings, 1 reply; 11+ messages in thread
From: David Marchand @ 2019-08-05 15:05 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Burakov, Anatoly, Bruce Richardson, Ray Kinsella, Traynor,
	Kevin, Stephen Hemminger

On Mon, Aug 5, 2019 at 4:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 02/08/2019 15:29, David Marchand:
> > This symbol has been deprecated for quite some time.
> > Let's drop it in the next release.
> > ---
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced
> > +  by ``rte_malloc_virt2iova`` since v17.11 and will be removed in DPDK 19.11.
>
> For this patch and another one about removing rte_cpu_check_supported(),
> I have a general comment on the date of removal.
>
> As was stated recently in the contribution guide:
>         http://git.dpdk.org/dpdk/commit/?id=7abe4a24cc
>         "Deprecated APIs are removed completely just after the next LTS."
>
> The idea behind this policy is to avoid removals during LTS releases,
> in order to have at least one release before X.11 LTS for end users
> to prepare replacing the usage of the removed API.
>
> Does it make sense to postpone any API removal after 19.11?

Those symbols have been marked as deprecated for a long time.
Users had to either disable Werror or they actually migrated to the new apis.
If they chose the lazy way of not migrating to the new apis, I suspect
they forgot about it and/or they won't look at the release notes.


I don't particularly have a problem with waiting for 20.02, those are
easy to remove anyway.

-- 
David Marchand

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-05 15:05   ` David Marchand
@ 2019-08-05 15:13     ` Thomas Monjalon
  2019-08-12 10:42       ` Kinsella, Ray
  0 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2019-08-05 15:13 UTC (permalink / raw)
  To: David Marchand
  Cc: dev, Burakov, Anatoly, Bruce Richardson, Ray Kinsella, Traynor,
	Kevin, Stephen Hemminger

05/08/2019 17:05, David Marchand:
> On Mon, Aug 5, 2019 at 4:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 02/08/2019 15:29, David Marchand:
> > > This symbol has been deprecated for quite some time.
> > > Let's drop it in the next release.
> > > ---
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > +* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced
> > > +  by ``rte_malloc_virt2iova`` since v17.11 and will be removed in DPDK 19.11.
> >
> > For this patch and another one about removing rte_cpu_check_supported(),
> > I have a general comment on the date of removal.
> >
> > As was stated recently in the contribution guide:
> >         http://git.dpdk.org/dpdk/commit/?id=7abe4a24cc
> >         "Deprecated APIs are removed completely just after the next LTS."
> >
> > The idea behind this policy is to avoid removals during LTS releases,
> > in order to have at least one release before X.11 LTS for end users
> > to prepare replacing the usage of the removed API.
> >
> > Does it make sense to postpone any API removal after 19.11?
> 
> Those symbols have been marked as deprecated for a long time.
> Users had to either disable Werror or they actually migrated to the new apis.
> If they chose the lazy way of not migrating to the new apis, I suspect
> they forgot about it and/or they won't look at the release notes.

Yes I agree.
That's why they can be surprised when hitting the removal.
Avoiding this removal in LTS release is one more care for
the lazy users. The question: is too much caution?

> I don't particularly have a problem with waiting for 20.02, those are
> easy to remove anyway.




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-02 13:29 [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal David Marchand
  2019-08-02 16:04 ` Burakov, Anatoly
  2019-08-05 14:39 ` Thomas Monjalon
@ 2019-08-06 13:50 ` Andrew Rybchenko
  2019-08-06 14:00 ` Ananyev, Konstantin
  2019-08-08  9:32 ` [dpdk-dev] [PATCH v2] " David Marchand
  4 siblings, 0 replies; 11+ messages in thread
From: Andrew Rybchenko @ 2019-08-06 13:50 UTC (permalink / raw)
  To: David Marchand, dev; +Cc: anatoly.burakov

On 8/2/19 4:29 PM, David Marchand wrote:
> This symbol has been deprecated for quite some time.
> Let's drop it in the next release.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

since it was deprecated in previous LTS, I think it is already OK to remove.


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-02 13:29 [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal David Marchand
                   ` (2 preceding siblings ...)
  2019-08-06 13:50 ` Andrew Rybchenko
@ 2019-08-06 14:00 ` Ananyev, Konstantin
  2019-08-08  9:32 ` [dpdk-dev] [PATCH v2] " David Marchand
  4 siblings, 0 replies; 11+ messages in thread
From: Ananyev, Konstantin @ 2019-08-06 14:00 UTC (permalink / raw)
  To: David Marchand, dev; +Cc: Burakov, Anatoly



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> Sent: Friday, August 2, 2019 2:29 PM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
> 
> This symbol has been deprecated for quite some time.
> Let's drop it in the next release.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index b57720c..3c98a5c 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,6 +41,9 @@ Deprecation Notices
>  * eal: The ``rte_cpu_check_supported`` function has been deprecated since
>    v17.08 and will be removed in DPDK 19.11.
> 
> +* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced
> +  by ``rte_malloc_virt2iova`` since v17.11 and will be removed in DPDK 19.11.
> +
>  * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
>    have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
>    functions.  The due date for the removal targets DPDK 20.02.
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 1.8.3.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH v2] doc: announce malloc virt2phys symbol removal
  2019-08-02 13:29 [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal David Marchand
                   ` (3 preceding siblings ...)
  2019-08-06 14:00 ` Ananyev, Konstantin
@ 2019-08-08  9:32 ` " David Marchand
  2019-08-08 15:44   ` Thomas Monjalon
  4 siblings, 1 reply; 11+ messages in thread
From: David Marchand @ 2019-08-08  9:32 UTC (permalink / raw)
  To: dev; +Cc: anatoly.burakov, jerinj, arybchenko, konstantin.ananyev

This symbol has been deprecated for quite some time.
Let's drop it as soon as possible.

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
Changelog since v1:
- added acks,
- removed mention of 19.11 as the target release,

---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ee15ab6..b1aa6a8 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -41,6 +41,9 @@ Deprecation Notices
 * eal: The ``rte_cpu_check_supported`` function has been deprecated since
   v17.08 and will be removed.
 
+* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced
+  by ``rte_malloc_virt2iova`` since v17.11 and will be removed.
+
 * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
   have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
   functions.  The due date for the removal targets DPDK 20.02.
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce malloc virt2phys symbol removal
  2019-08-08  9:32 ` [dpdk-dev] [PATCH v2] " David Marchand
@ 2019-08-08 15:44   ` Thomas Monjalon
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2019-08-08 15:44 UTC (permalink / raw)
  To: David Marchand
  Cc: dev, anatoly.burakov, jerinj, arybchenko, konstantin.ananyev

08/08/2019 11:32, David Marchand:
> This symbol has been deprecated for quite some time.
> Let's drop it as soon as possible.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> Changelog since v1:
> - added acks,
> - removed mention of 19.11 as the target release,

Applied, thanks




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal
  2019-08-05 15:13     ` Thomas Monjalon
@ 2019-08-12 10:42       ` Kinsella, Ray
  0 siblings, 0 replies; 11+ messages in thread
From: Kinsella, Ray @ 2019-08-12 10:42 UTC (permalink / raw)
  To: Thomas Monjalon, David Marchand
  Cc: dev, Burakov, Anatoly, Richardson, Bruce, Traynor, Kevin,
	Stephen Hemminger



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday 5 August 2019 16:13
> To: David Marchand <david.marchand@redhat.com>
> Cc: dev <dev@dpdk.org>; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Kinsella, Ray
> <ray.kinsella@intel.com>; Traynor, Kevin <ktraynor@redhat.com>; Stephen
> Hemminger <stephen@networkplumber.org>
> Subject: Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol
> removal
> 
> 05/08/2019 17:05, David Marchand:
> > On Mon, Aug 5, 2019 at 4:39 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> > > 02/08/2019 15:29, David Marchand:
> > > > This symbol has been deprecated for quite some time.
> > > > Let's drop it in the next release.
> > > > ---
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > +* eal: The ``rte_malloc_virt2phy`` function has been deprecated
> > > > +and replaced
> > > > +  by ``rte_malloc_virt2iova`` since v17.11 and will be removed
> in DPDK 19.11.
> > >
> > > For this patch and another one about removing
> > > rte_cpu_check_supported(), I have a general comment on the date of
> removal.
> > >
> > > As was stated recently in the contribution guide:
> > >         http://git.dpdk.org/dpdk/commit/?id=7abe4a24cc
> > >         "Deprecated APIs are removed completely just after the next
> LTS."
> > >
> > > The idea behind this policy is to avoid removals during LTS
> > > releases, in order to have at least one release before X.11 LTS for
> > > end users to prepare replacing the usage of the removed API.
> > >
> > > Does it make sense to postpone any API removal after 19.11?
> >
> > Those symbols have been marked as deprecated for a long time.
> > Users had to either disable Werror or they actually migrated to the
> new apis.
> > If they chose the lazy way of not migrating to the new apis, I
> suspect
> > they forgot about it and/or they won't look at the release notes.
> 
> Yes I agree.
> That's why they can be surprised when hitting the removal.
> Avoiding this removal in LTS release is one more care for the lazy
> users. The question: is too much caution?
> 
> > I don't particularly have a problem with waiting for 20.02, those are
> > easy to remove anyway.
> 
> 

My 2c is that if they are have signalled as deprecated since v17.11.
They are fair game for removal at this point. 

Ray K

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, back to index

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 13:29 [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal David Marchand
2019-08-02 16:04 ` Burakov, Anatoly
2019-08-02 16:10   ` Jerin Jacob Kollanukkaran
2019-08-05 14:39 ` Thomas Monjalon
2019-08-05 15:05   ` David Marchand
2019-08-05 15:13     ` Thomas Monjalon
2019-08-12 10:42       ` Kinsella, Ray
2019-08-06 13:50 ` Andrew Rybchenko
2019-08-06 14:00 ` Ananyev, Konstantin
2019-08-08  9:32 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-08-08 15:44   ` Thomas Monjalon

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox