From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Shelton, Benjamin H" <benjamin.h.shelton@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] ethdev: Fix issue in Doxygen for TM API
Date: Tue, 1 May 2018 15:12:26 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BB644CF@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1521647133-17843-1-git-send-email-benjamin.h.shelton@intel.com>
> -----Original Message-----
> From: Shelton, Benjamin H
> Sent: Wednesday, March 21, 2018 3:46 PM
> To: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Shelton, Benjamin H <benjamin.h.shelton@intel.com>
> Subject: [PATCH] ethdev: Fix issue in Doxygen for TM API
>
> The rte_tm_node_wfq_weight_mode_update() API function operates on
> non-leaf nodes, not leaf nodes.
>
> Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> ---
> lib/librte_ether/rte_tm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_ether/rte_tm.h b/lib/librte_ether/rte_tm.h
> index 2b25a87..f735f84 100644
> --- a/lib/librte_ether/rte_tm.h
> +++ b/lib/librte_ether/rte_tm.h
> @@ -1643,7 +1643,7 @@ rte_tm_node_stats_update(uint16_t port_id,
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> * @param[in] node_id
> - * Node ID. Needs to be valid leaf node ID.
> + * Node ID. Needs to be valid non-leaf node ID.
> * @param[in] wfq_weight_mode
> * WFQ weight mode for each SP priority. When NULL, it indicates that
> WFQ is
> * to be used for all priorities. When non-NULL, it points to a pre-allocated
> --
> 2.6.4
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-qos tree, thanks!
prev parent reply other threads:[~2018-05-01 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 15:45 [PATCH] ethdev: Fix issue in Doxygen for TM API Ben Shelton
2018-05-01 15:12 ` Dumitrescu, Cristian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891267BB644CF@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=benjamin.h.shelton@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).