From: "Laatz, Kevin" <kevin.laatz@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>, dev@dpdk.org
Cc: anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics
Date: Fri, 31 May 2019 13:41:56 +0100 [thread overview]
Message-ID: <50a97a4a-4feb-0922-8442-2346cfba2540@intel.com> (raw)
In-Reply-To: <20190517160757.28098-1-reshma.pattan@intel.com>
On 17/05/2019 17:07, Reshma Pattan wrote:
> telemetry has support for fetching port based stats
> from metrics library.
>
> Metrics library also has global stats which are
> not fetched by telemetry, so extend telemetry to
> fetch the global metrics.
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> doc/guides/howto/telemetry.rst | 9 +-
> doc/guides/rel_notes/release_19_08.rst | 5 +
> lib/librte_telemetry/rte_telemetry.c | 119 ++++++++++++----
> lib/librte_telemetry/rte_telemetry_internal.h | 31 ++++-
> lib/librte_telemetry/rte_telemetry_parser.c | 130 +++++++++++++++---
> usertools/dpdk-telemetry-client.py | 13 +-
> 6 files changed, 253 insertions(+), 54 deletions(-)
Looks good to me, thanks!
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
next prev parent reply other threads:[~2019-05-31 12:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 16:07 [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics Reshma Pattan
2019-05-31 12:41 ` Laatz, Kevin [this message]
2019-06-18 9:44 ` Thomas Monjalon
2019-06-18 11:46 ` Pattan, Reshma
2019-06-18 15:55 ` Pattan, Reshma
2019-06-18 20:07 ` Thomas Monjalon
2019-06-18 13:49 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2019-06-19 16:02 ` Ferruh Yigit
2019-06-20 8:59 ` Laatz, Kevin
2019-06-24 14:54 ` Thomas Monjalon
2019-06-24 17:36 ` Chautru, Nicolas
2019-06-25 8:39 ` Pattan, Reshma
2019-06-25 11:28 ` Pattan, Reshma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50a97a4a-4feb-0922-8442-2346cfba2540@intel.com \
--to=kevin.laatz@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).