DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Frank Li <frank.li.65@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for	set/sequence/save commands, packet headers, UI printing
Date: Sat, 30 Nov 2019 00:03:03 +0000
Message-ID: <C302A458-E583-46EB-84C8-DB10E85F6CE0@intel.com> (raw)
In-Reply-To: <20191120004709.48292-1-frank.li.65@gmail.com>



> On Nov 19, 2019, at 6:47 PM, Frank Li <frank.li.65@gmail.com> wrote:
> 
> Current IPv6 functionality in pktgen is broken. This fix makes it so that
> IPv6 addresses are properly set when using the set, sequence, and save
> commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses
> are properly set.
> 
> To preserve the runtime commands, the `_atoip` function no longer takes
> in flags to specify converting IPv4/6 addresses, and will try both,
> returning, 4, 6, or -1 for a valid IPv4/6, invalid address, respectively.
> 
> Also print IPv6 addresses in UI properly.
> 
> Co-authored-by Valentin Andrei <vandrei@fb.com>
> 
> Signed-off-by: Frank Li <frank.li.65@gmail.com>
> ---

I applied this patch and if you have time do a pull on the pktgen repo and switch over to the ‘dev’ branch and see if this version works for you.

Regards,
Keith


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 23:42 [dpdk-dev] [PATCH] " Frank Li
2019-11-20  0:47 ` [dpdk-dev] [PATCH v2] " Frank Li
2019-11-30  0:03   ` Wiles, Keith [this message]
2019-12-02 21:20     ` Frank Li
2019-12-02 23:43       ` Wiles, Keith

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C302A458-E583-46EB-84C8-DB10E85F6CE0@intel.com \
    --to=keith.wiles@intel.com \
    --cc=dev@dpdk.org \
    --cc=frank.li.65@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git