DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Frank Li <frank.li.65@gmail.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing
Date: Mon, 2 Dec 2019 13:20:30 -0800
Message-ID: <CAOPexLMn-Vai=NmaRU-FXAvSPNthb8hEvGTQAXWyJDqqsOsLag@mail.gmail.com> (raw)
In-Reply-To: <C302A458-E583-46EB-84C8-DB10E85F6CE0@intel.com>

Hi Keith,

Thanks for fixing my macros from ETHER_TYPE_IPv6 to PG_ETHER_TYPE_IPv6 in
your latest commit.

I tested the 'dev' branch with tap interfaces running the command:
`pktgen l 1-5 -n 4 --proc-type auto --log-level debug --file-prefix pg
--vdev=net_tap0 --vdev=net_tap1 -- -T -P -m [2:3].0 -m [4:5].1`

When I use the latest commit, pktgen crashes. When I go back 1 commit to my
changes (manually fixing the ether type macros), my IPv6 changes do work as
expected running the same command.

Here is the error I saw:

Initialize Port 0 -- TxQ 1, RxQ 1
Src MAC 5a:d7:d5:38:f8:a7
 <Promiscuous mode Enabled>
Initialize Port 1 -- TxQ 1, RxQ 1
!PANIC!: Cannot create mbuf pool (Default TX  1:0) port 1, queue 0,
nb_mbufs 16384, socket_id 0: Cannot allocate memory
PANIC in pktgen_mbuf_pool_create():
Cannot create mbuf pool (Default TX  1:0) port 1, queue 0, nb_mbufs 16384,
socket_id 0: Cannot allocate memory
6: [/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen()
[0x53b853]]
5: [/lib64/libc.so.6(__libc_start_main+0xf5) [0x7fc787ed73d5]]
4:
[/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(main+0xf03)
[0x4977f3]]
3:
[/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(pktgen_config_ports+0x1d02)
[0x567832]]
2:
[/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(__rte_panic+0xb8)
[0x488bf2]]
1:
[/home/frankli1/pktgen-dpdk/app/x86_64-native-linuxapp-gcc/app/pktgen(rte_dump_stack+0x16)
[0x667ca6]]

I haven't tried running pktgen with any other options, and I do believe my
changes are incorporated properly, just wanted to bring this error to your
attention in case it may be helpful for you.

Best,
Frank


On Fri, Nov 29, 2019 at 4:03 PM Wiles, Keith <keith.wiles@intel.com> wrote:

>
>
> > On Nov 19, 2019, at 6:47 PM, Frank Li <frank.li.65@gmail.com> wrote:
> >
> > Current IPv6 functionality in pktgen is broken. This fix makes it so that
> > IPv6 addresses are properly set when using the set, sequence, and save
> > commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses
> > are properly set.
> >
> > To preserve the runtime commands, the `_atoip` function no longer takes
> > in flags to specify converting IPv4/6 addresses, and will try both,
> > returning, 4, 6, or -1 for a valid IPv4/6, invalid address, respectively.
> >
> > Also print IPv6 addresses in UI properly.
> >
> > Co-authored-by Valentin Andrei <vandrei@fb.com>
> >
> > Signed-off-by: Frank Li <frank.li.65@gmail.com>
> > ---
>
> I applied this patch and if you have time do a pull on the pktgen repo and
> switch over to the ‘dev’ branch and see if this version works for you.
>
> Regards,
> Keith
>
>

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 23:42 [dpdk-dev] [PATCH] " Frank Li
2019-11-20  0:47 ` [dpdk-dev] [PATCH v2] " Frank Li
2019-11-30  0:03   ` Wiles, Keith
2019-12-02 21:20     ` Frank Li [this message]
2019-12-02 23:43       ` Wiles, Keith

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOPexLMn-Vai=NmaRU-FXAvSPNthb8hEvGTQAXWyJDqqsOsLag@mail.gmail.com' \
    --to=frank.li.65@gmail.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git