DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation
@ 2020-01-06  7:42 pbhagavatula
  2020-01-06  7:42 ` [dpdk-dev] [PATCH 2/2] test/eventdev: fix octeontx2 event device name pbhagavatula
  2020-01-15 11:06 ` [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation Jerin Jacob
  0 siblings, 2 replies; 3+ messages in thread
From: pbhagavatula @ 2020-01-06  7:42 UTC (permalink / raw)
  To: jerinj; +Cc: dev, Pavan Nikhilesh, stable

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Virtual eventdevice should only be created when there is no existing
device with the same name.

Fixes: e0f4a0ed4237 ("test: skip tests when missing requirements")
Cc: stable@dpdk.org

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 app/test/test_eventdev.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
index 427dbbf77..56155838d 100644
--- a/app/test/test_eventdev.c
+++ b/app/test/test_eventdev.c
@@ -996,9 +996,13 @@ test_eventdev_common(void)
 static int
 test_eventdev_selftest_impl(const char *pmd, const char *opts)
 {
-	rte_vdev_init(pmd, opts);
+	int ret = 0;
+
 	if (rte_event_dev_get_dev_id(pmd) == -ENODEV)
+		ret = rte_vdev_init(pmd, opts);
+	if (ret)
 		return TEST_SKIPPED;
+
 	return rte_event_dev_selftest(rte_event_dev_get_dev_id(pmd));
 }
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH 2/2] test/eventdev: fix octeontx2 event device name
  2020-01-06  7:42 [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation pbhagavatula
@ 2020-01-06  7:42 ` pbhagavatula
  2020-01-15 11:06 ` [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation Jerin Jacob
  1 sibling, 0 replies; 3+ messages in thread
From: pbhagavatula @ 2020-01-06  7:42 UTC (permalink / raw)
  To: jerinj; +Cc: dev, Pavan Nikhilesh, stable

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Fix octeontx2 event device name used in eventdevice test.

Fixes: 62561532ac4c ("event/octeontx2: add SSO selftest")
Cc: stable@dpdk.org

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 app/test/test_eventdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
index 56155838d..43ccb1ce9 100644
--- a/app/test/test_eventdev.c
+++ b/app/test/test_eventdev.c
@@ -1021,7 +1021,7 @@ test_eventdev_selftest_octeontx(void)
 static int
 test_eventdev_selftest_octeontx2(void)
 {
-	return test_eventdev_selftest_impl("otx2_eventdev", "");
+	return test_eventdev_selftest_impl("event_octeontx2", "");
 }
 
 static int
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation
  2020-01-06  7:42 [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation pbhagavatula
  2020-01-06  7:42 ` [dpdk-dev] [PATCH 2/2] test/eventdev: fix octeontx2 event device name pbhagavatula
@ 2020-01-15 11:06 ` Jerin Jacob
  1 sibling, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2020-01-15 11:06 UTC (permalink / raw)
  To: Pavan Nikhilesh; +Cc: Jerin Jacob, dpdk-dev, dpdk stable

On Mon, Jan 6, 2020 at 1:12 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Virtual eventdevice should only be created when there is no existing
> device with the same name.
>
> Fixes: e0f4a0ed4237 ("test: skip tests when missing requirements")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>
Series applied to dpdk-next-eventdev/master. Thanks.


> ---
>  app/test/test_eventdev.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
> index 427dbbf77..56155838d 100644
> --- a/app/test/test_eventdev.c
> +++ b/app/test/test_eventdev.c
> @@ -996,9 +996,13 @@ test_eventdev_common(void)
>  static int
>  test_eventdev_selftest_impl(const char *pmd, const char *opts)
>  {
> -       rte_vdev_init(pmd, opts);
> +       int ret = 0;
> +
>         if (rte_event_dev_get_dev_id(pmd) == -ENODEV)
> +               ret = rte_vdev_init(pmd, opts);
> +       if (ret)
>                 return TEST_SKIPPED;
> +
>         return rte_event_dev_selftest(rte_event_dev_get_dev_id(pmd));
>  }
>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06  7:42 [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation pbhagavatula
2020-01-06  7:42 ` [dpdk-dev] [PATCH 2/2] test/eventdev: fix octeontx2 event device name pbhagavatula
2020-01-15 11:06 ` [dpdk-dev] [PATCH 1/2] test/eventdev: fix unintended vdev creation Jerin Jacob

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git