From: Jyri Sarha <jsarha@ti.com>
To: YueHaibing <yuehaibing@huawei.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc()
Date: Thu, 27 Feb 2020 12:01:26 +0200 [thread overview]
Message-ID: <06fb1070-9c4c-c776-6379-fe27b0a7b220@ti.com> (raw)
In-Reply-To: <20200227065057.92766-1-yuehaibing@huawei.com>
On 27/02/2020 08:50, YueHaibing wrote:
> There is no need to have the 'const struct dispc_csc_coef *coef'
> variable static since new value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Tested-by: Jyri Sarha <jsarha@ti.com>
I'll merge this to drm-misc-next tomorrow.
Thank you for the patch,
Jyri
> ---
> drivers/gpu/drm/tidss/tidss_dispc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index eeb160dc047b..e6cb176484a9 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -1510,7 +1510,7 @@ struct dispc_csc_coef *dispc_find_csc(enum drm_color_encoding encoding,
> static void dispc_vid_csc_setup(struct dispc_device *dispc, u32 hw_plane,
> const struct drm_plane_state *state)
> {
> - static const struct dispc_csc_coef *coef;
> + const struct dispc_csc_coef *coef;
>
> coef = dispc_find_csc(state->color_encoding, state->color_range);
> if (!coef) {
>
>
>
>
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-02-27 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 6:50 [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc() YueHaibing
2020-02-27 10:01 ` Jyri Sarha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06fb1070-9c4c-c776-6379-fe27b0a7b220@ti.com \
--to=jsarha@ti.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).