* [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc()
@ 2020-02-27 6:50 YueHaibing
2020-02-27 10:01 ` Jyri Sarha
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-02-27 6:50 UTC (permalink / raw)
To: Jyri Sarha, Tomi Valkeinen, David Airlie, Daniel Vetter
Cc: kernel-janitors, YueHaibing, linux-kernel, dri-devel
There is no need to have the 'const struct dispc_csc_coef *coef'
variable static since new value always be assigned before use it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/tidss/tidss_dispc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
index eeb160dc047b..e6cb176484a9 100644
--- a/drivers/gpu/drm/tidss/tidss_dispc.c
+++ b/drivers/gpu/drm/tidss/tidss_dispc.c
@@ -1510,7 +1510,7 @@ struct dispc_csc_coef *dispc_find_csc(enum drm_color_encoding encoding,
static void dispc_vid_csc_setup(struct dispc_device *dispc, u32 hw_plane,
const struct drm_plane_state *state)
{
- static const struct dispc_csc_coef *coef;
+ const struct dispc_csc_coef *coef;
coef = dispc_find_csc(state->color_encoding, state->color_range);
if (!coef) {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc()
2020-02-27 6:50 [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc() YueHaibing
@ 2020-02-27 10:01 ` Jyri Sarha
0 siblings, 0 replies; 2+ messages in thread
From: Jyri Sarha @ 2020-02-27 10:01 UTC (permalink / raw)
To: YueHaibing, Tomi Valkeinen, David Airlie, Daniel Vetter
Cc: kernel-janitors, linux-kernel, dri-devel
On 27/02/2020 08:50, YueHaibing wrote:
> There is no need to have the 'const struct dispc_csc_coef *coef'
> variable static since new value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Tested-by: Jyri Sarha <jsarha@ti.com>
I'll merge this to drm-misc-next tomorrow.
Thank you for the patch,
Jyri
> ---
> drivers/gpu/drm/tidss/tidss_dispc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index eeb160dc047b..e6cb176484a9 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -1510,7 +1510,7 @@ struct dispc_csc_coef *dispc_find_csc(enum drm_color_encoding encoding,
> static void dispc_vid_csc_setup(struct dispc_device *dispc, u32 hw_plane,
> const struct drm_plane_state *state)
> {
> - static const struct dispc_csc_coef *coef;
> + const struct dispc_csc_coef *coef;
>
> coef = dispc_find_csc(state->color_encoding, state->color_range);
> if (!coef) {
>
>
>
>
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-27 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 6:50 [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc() YueHaibing
2020-02-27 10:01 ` Jyri Sarha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).