* [PATCH] drm/meson: fix potential NULL pointer exception in meson_drv_unbind()
@ 2021-06-17 7:07 Jiajun Cao
2021-06-17 14:58 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Jiajun Cao @ 2021-06-17 7:07 UTC (permalink / raw)
Cc: Xin Tan, Neil Armstrong, David Airlie, Kevin Hilman, yuanxzhang,
linux-kernel, dri-devel, Jiajun Cao, Martin Blumenstingl,
linux-amlogic, linux-arm-kernel, Jerome Brunet
Fix a potential NULL pointer exception when meson_drv_unbind()
attempts to operate on the driver_data priv which may be NULL.
Add a null pointer check on the priv struct to avoid the NULL
pointer dereference after calling dev_get_drvdata(), just like
the null pointer checks done on the struct priv in the function
meson_drv_shutdown(), meson_drv_pm_suspend() and meson_drv_pm_resume().
Signed-off-by: Jiajun Cao <jjcao20@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
---
drivers/gpu/drm/meson/meson_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index 07fcd12dca16..adea6a2b28f5 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -380,6 +380,8 @@ static int meson_drv_bind(struct device *dev)
static void meson_drv_unbind(struct device *dev)
{
struct meson_drm *priv = dev_get_drvdata(dev);
+ if (!priv)
+ return;
struct drm_device *drm = priv->drm;
if (priv->canvas) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/meson: fix potential NULL pointer exception in meson_drv_unbind()
2021-06-17 7:07 [PATCH] drm/meson: fix potential NULL pointer exception in meson_drv_unbind() Jiajun Cao
@ 2021-06-17 14:58 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2021-06-17 14:58 UTC (permalink / raw)
To: Jiajun Cao
Cc: Xin Tan, David Airlie, Kevin Hilman, yuanxzhang, linux-kernel,
dri-devel, Martin Blumenstingl, linux-amlogic, linux-arm-kernel,
Jerome Brunet
Hi,
On 17/06/2021 09:07, Jiajun Cao wrote:
> Fix a potential NULL pointer exception when meson_drv_unbind()
> attempts to operate on the driver_data priv which may be NULL.
> Add a null pointer check on the priv struct to avoid the NULL
> pointer dereference after calling dev_get_drvdata(), just like
> the null pointer checks done on the struct priv in the function
> meson_drv_shutdown(), meson_drv_pm_suspend() and meson_drv_pm_resume().
>
> Signed-off-by: Jiajun Cao <jjcao20@fudan.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index 07fcd12dca16..adea6a2b28f5 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -380,6 +380,8 @@ static int meson_drv_bind(struct device *dev)
> static void meson_drv_unbind(struct device *dev)
> {
> struct meson_drm *priv = dev_get_drvdata(dev);
> + if (!priv)
> + return;
> struct drm_device *drm = priv->drm;
Please move struct drm_device before the if like :
struct meson_drm *priv = dev_get_drvdata(dev);
struct drm_device *drm;
if (!priv)
return;
drm = priv->drm;
>
> if (priv->canvas) {
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-17 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 7:07 [PATCH] drm/meson: fix potential NULL pointer exception in meson_drv_unbind() Jiajun Cao
2021-06-17 14:58 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).