dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] drm/panel: ili9322:Make local symbols static
@ 2018-01-03  3:08 Wei Yongjun
  2018-03-12  9:07 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-01-03  3:08 UTC (permalink / raw)
  To: Thierry Reding, David Airlie; +Cc: Wei Yongjun, dri-devel, linux-kernel

Fixes the following sparse warnings:

drivers/gpu/drm/panel/panel-ilitek-ili9322.c:182:12: warning:
 symbol 'ili9322_inputs' was not declared. Should it be static?
drivers/gpu/drm/panel/panel-ilitek-ili9322.c:343:28: warning:
 symbol 'ili9322_regmap_config' was not declared. Should it be static?

Also change ili9322_inputs to 'const char * const' to avoid
chackpatch warning.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
index b4ec0ec..bd38bf4 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
@@ -179,7 +179,7 @@ enum ili9322_input {
 	ILI9322_INPUT_UNKNOWN = 0xc,
 };
 
-const char *ili9322_inputs[] = {
+static const char * const ili9322_inputs[] = {
 	"8 bit serial RGB through",
 	"8 bit serial RGB aligned",
 	"8 bit serial RGB dummy 320x240",
@@ -340,7 +340,7 @@ static bool ili9322_writeable_reg(struct device *dev, unsigned int reg)
 	return true;
 }
 
-const struct regmap_config ili9322_regmap_config = {
+static const struct regmap_config ili9322_regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
 	.max_register = 0x44,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] drm/panel: ili9322:Make local symbols static
  2018-01-03  3:08 [PATCH -next] drm/panel: ili9322:Make local symbols static Wei Yongjun
@ 2018-03-12  9:07 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2018-03-12  9:07 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: David Airlie, dri-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

On Wed, Jan 03, 2018 at 03:08:58AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
> 
> drivers/gpu/drm/panel/panel-ilitek-ili9322.c:182:12: warning:
>  symbol 'ili9322_inputs' was not declared. Should it be static?
> drivers/gpu/drm/panel/panel-ilitek-ili9322.c:343:28: warning:
>  symbol 'ili9322_regmap_config' was not declared. Should it be static?
> 
> Also change ili9322_inputs to 'const char * const' to avoid
> chackpatch warning.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-12  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-03  3:08 [PATCH -next] drm/panel: ili9322:Make local symbols static Wei Yongjun
2018-03-12  9:07 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).