[PATCH] drm/edid: Quirk Sensics, 3 Glasses HMD as non-desktop.

[PATCH] drm/edid: Quirk Sensics, 3 Glasses HMD as non-desktop.

[Ryan Pavlik]

Two of the EDID vendor/product pairs are used across a variety of
Sensics products, as well as the OSVR HDK and HDK 2.

The third is for the "3 Glasses" brand "D3" HMD.

Signed-off-by: Ryan Pavlik <ryan.pavlik@collabora.com>
---
 drivers/gpu/drm/drm_edid.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 3c9fc9964..68b7bc007 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -187,6 +187,15 @@ static const struct edid_quirk {
 
 	/* Sony PlayStation VR Headset */
 	{ "SNY", 0x0704, EDID_QUIRK_NON_DESKTOP },
+
+	/* Sensics VR Headsets */
+	{ "SEN", 0x1019, EDID_QUIRK_NON_DESKTOP },
+
+	/* Sensics, OSVR HDK and HDK2 VR Headsets */
+	{ "SVR", 0x1019, EDID_QUIRK_NON_DESKTOP },
+
+	/* 3Glasses D3 VR Headset */
+	{ "TSB", 0x8888, EDID_QUIRK_NON_DESKTOP },
 };
 
 /*
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/edid: Quirk Sensics, 3 Glasses HMD as non-desktop.

[Philipp Zabel]

On Sat, 2018-10-20 at 20:42 +0100, Ryan Pavlik wrote:
> Two of the EDID vendor/product pairs are used across a variety of
> Sensics products, as well as the OSVR HDK and HDK 2.
> 
> The third is for the "3 Glasses" brand "D3" HMD.
> 
> Signed-off-by: Ryan Pavlik <ryan.pavlik@collabora.com>
> ---
>  drivers/gpu/drm/drm_edid.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 3c9fc9964..68b7bc007 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -187,6 +187,15 @@ static const struct edid_quirk {
>  
>  	/* Sony PlayStation VR Headset */
>  	{ "SNY", 0x0704, EDID_QUIRK_NON_DESKTOP },
> +
> +	/* Sensics VR Headsets */
> +	{ "SEN", 0x1019, EDID_QUIRK_NON_DESKTOP },
> +
> +	/* Sensics, OSVR HDK and HDK2 VR Headsets */
> +	{ "SVR", 0x1019, EDID_QUIRK_NON_DESKTOP },

This looks good to me. These are indeed HMDs, and I can confirm
"SVR"/0x1019 is correct for the HDK2.

> +	/* 3Glasses D3 VR Headset */
> +	{ "TSB", 0x8888, EDID_QUIRK_NON_DESKTOP },

This looks a lot like the vendor has not bothered to set a custom
vendor/product id in the Toshiba HDMI-to-DSI bridge chip. I would
argue that it is safer to mark such displays as non-desktop, though.

>  };
>  
>  /*

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

Can we take this into drm-misc?

regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] drm: add non-desktop quirks to Sensics and OSVR headsets.

[Ryan Pavlik]

Add two EDID vendor/product pairs used across a variety of
Sensics products, as well as the OSVR HDK and HDK 2.

Signed-off-by: Ryan Pavlik <ryan.pavlik@collabora.com>
---

Replaces the earlier patch:
drm/edid: Quirk Sensics, 3 Glasses HMD as non-desktop.

Changed:
Drops the 3 Glasses HMD, because it is using a "default" ID
shared between a number of products using a Toshiba video bridge.

 drivers/gpu/drm/drm_edid.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 3c9fc99648b7..a1a785b1b8f2 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -187,6 +187,12 @@ static const struct edid_quirk {
 
 	/* Sony PlayStation VR Headset */
 	{ "SNY", 0x0704, EDID_QUIRK_NON_DESKTOP },
+
+	/* Sensics VR Headsets */
+	{ "SEN", 0x1019, EDID_QUIRK_NON_DESKTOP },
+
+	/* OSVR HDK and HDK2 VR Headsets */
+	{ "SVR", 0x1019, EDID_QUIRK_NON_DESKTOP },
 };
 
 /*
-- 
2.19.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm: add non-desktop quirks to Sensics and OSVR headsets.

[Philipp Zabel]

On Mon, 2018-12-03 at 10:46 -0600, Ryan Pavlik wrote:
> Add two EDID vendor/product pairs used across a variety of
> Sensics products, as well as the OSVR HDK and HDK 2.
> 
> Signed-off-by: Ryan Pavlik <ryan.pavlik@collabora.com>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

> ---
> 
> Replaces the earlier patch:
> drm/edid: Quirk Sensics, 3 Glasses HMD as non-desktop.
> 
> Changed:
> Drops the 3 Glasses HMD, because it is using a "default" ID
> shared between a number of products using a Toshiba video bridge.
> 
>  drivers/gpu/drm/drm_edid.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 3c9fc99648b7..a1a785b1b8f2 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -187,6 +187,12 @@ static const struct edid_quirk {
>  
>  	/* Sony PlayStation VR Headset */
>  	{ "SNY", 0x0704, EDID_QUIRK_NON_DESKTOP },
> +
> +	/* Sensics VR Headsets */
> +	{ "SEN", 0x1019, EDID_QUIRK_NON_DESKTOP },
> +
> +	/* OSVR HDK and HDK2 VR Headsets */
> +	{ "SVR", 0x1019, EDID_QUIRK_NON_DESKTOP },
>  };
>  
>  /*

regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm: add non-desktop quirks to Sensics and OSVR headsets.

[Daniel Stone]

Hi,

On Mon, 3 Dec 2018 at 17:04, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Mon, 2018-12-03 at 10:46 -0600, Ryan Pavlik wrote:
> > Add two EDID vendor/product pairs used across a variety of
> > Sensics products, as well as the OSVR HDK and HDK 2.
> >
> > Signed-off-by: Ryan Pavlik <ryan.pavlik@collabora.com>
>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

I've pushed this to drm-misc-next now, tagged for stable backport:
    527261ddf1ac..29054230f3e1  drm-misc-next -> drm-misc-next

Cheers,
Daniel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel