* [PATCH] MAINTAINERS: adjust to reservation.h renaming
@ 2020-03-04 12:07 Lukas Bulwahn
2020-03-04 12:08 ` Christian König
0 siblings, 1 reply; 6+ messages in thread
From: Lukas Bulwahn @ 2020-03-04 12:07 UTC (permalink / raw)
To: Christian König
Cc: intel-gfx, kernel-janitors, linux-kernel, dri-devel, Joe Perches,
Lukas Bulwahn, Sebastian Duda, linux-media
Commit 52791eeec1d9 ("dma-buf: rename reservation_object to dma_resv")
renamed include/linux/reservation.h to include/linux/dma-resv.h, but
missed the reference in the MAINTAINERS entry.
Since then, ./scripts/get_maintainer.pl --self-test complains:
warning: no file matches F: include/linux/reservation.h
Adjust the DMA BUFFER SHARING FRAMEWORK entry in MAINTAINERS.
Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Christian, please pick this patch.
applies cleanly on current master and next-20200303
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6158a143a13e..3d6cb2789c9e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5022,7 +5022,7 @@ L: dri-devel@lists.freedesktop.org
L: linaro-mm-sig@lists.linaro.org (moderated for non-subscribers)
F: drivers/dma-buf/
F: include/linux/dma-buf*
-F: include/linux/reservation.h
+F: include/linux/dma-resv.h
F: include/linux/*fence.h
F: Documentation/driver-api/dma-buf.rst
K: dma_(buf|fence|resv)
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: adjust to reservation.h renaming
2020-03-04 12:07 [PATCH] MAINTAINERS: adjust to reservation.h renaming Lukas Bulwahn
@ 2020-03-04 12:08 ` Christian König
2020-03-06 10:39 ` [Intel-gfx] " Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Christian König @ 2020-03-04 12:08 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: intel-gfx, kernel-janitors, linux-kernel, dri-devel, Joe Perches,
Sebastian Duda, linux-media
Am 04.03.20 um 13:07 schrieb Lukas Bulwahn:
> Commit 52791eeec1d9 ("dma-buf: rename reservation_object to dma_resv")
> renamed include/linux/reservation.h to include/linux/dma-resv.h, but
> missed the reference in the MAINTAINERS entry.
>
> Since then, ./scripts/get_maintainer.pl --self-test complains:
>
> warning: no file matches F: include/linux/reservation.h
>
> Adjust the DMA BUFFER SHARING FRAMEWORK entry in MAINTAINERS.
>
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> Christian, please pick this patch.
> applies cleanly on current master and next-20200303
>
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6158a143a13e..3d6cb2789c9e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5022,7 +5022,7 @@ L: dri-devel@lists.freedesktop.org
> L: linaro-mm-sig@lists.linaro.org (moderated for non-subscribers)
> F: drivers/dma-buf/
> F: include/linux/dma-buf*
> -F: include/linux/reservation.h
> +F: include/linux/dma-resv.h
> F: include/linux/*fence.h
> F: Documentation/driver-api/dma-buf.rst
> K: dma_(buf|fence|resv)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] MAINTAINERS: adjust to reservation.h renaming
2020-03-04 12:08 ` Christian König
@ 2020-03-06 10:39 ` Daniel Vetter
2020-03-06 10:56 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2020-03-06 10:39 UTC (permalink / raw)
To: Christian König
Cc: intel-gfx, kernel-janitors, linux-kernel, dri-devel, Joe Perches,
Lukas Bulwahn, Sebastian Duda, linux-media
On Wed, Mar 04, 2020 at 01:08:32PM +0100, Christian König wrote:
> Am 04.03.20 um 13:07 schrieb Lukas Bulwahn:
> > Commit 52791eeec1d9 ("dma-buf: rename reservation_object to dma_resv")
> > renamed include/linux/reservation.h to include/linux/dma-resv.h, but
> > missed the reference in the MAINTAINERS entry.
> >
> > Since then, ./scripts/get_maintainer.pl --self-test complains:
> >
> > warning: no file matches F: include/linux/reservation.h
> >
> > Adjust the DMA BUFFER SHARING FRAMEWORK entry in MAINTAINERS.
> >
> > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
You'll push this too?
-Daniel
>
> > ---
> > Christian, please pick this patch.
> > applies cleanly on current master and next-20200303
> >
> > MAINTAINERS | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6158a143a13e..3d6cb2789c9e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5022,7 +5022,7 @@ L: dri-devel@lists.freedesktop.org
> > L: linaro-mm-sig@lists.linaro.org (moderated for non-subscribers)
> > F: drivers/dma-buf/
> > F: include/linux/dma-buf*
> > -F: include/linux/reservation.h
> > +F: include/linux/dma-resv.h
> > F: include/linux/*fence.h
> > F: Documentation/driver-api/dma-buf.rst
> > K: dma_(buf|fence|resv)
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] MAINTAINERS: adjust to reservation.h renaming
2020-03-06 10:39 ` [Intel-gfx] " Daniel Vetter
@ 2020-03-06 10:56 ` Joe Perches
2020-03-16 9:50 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2020-03-06 10:56 UTC (permalink / raw)
To: Daniel Vetter, Christian König
Cc: intel-gfx, kernel-janitors, linux-kernel, dri-devel,
Lukas Bulwahn, Sebastian Duda, linux-media
On Fri, 2020-03-06 at 11:39 +0100, Daniel Vetter wrote:
> On Wed, Mar 04, 2020 at 01:08:32PM +0100, Christian König wrote:
> > Am 04.03.20 um 13:07 schrieb Lukas Bulwahn:
> > > Commit 52791eeec1d9 ("dma-buf: rename reservation_object to dma_resv")
> > > renamed include/linux/reservation.h to include/linux/dma-resv.h, but
> > > missed the reference in the MAINTAINERS entry.
> > >
> > > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > >
> > > warning: no file matches F: include/linux/reservation.h
> > >
> > > Adjust the DMA BUFFER SHARING FRAMEWORK entry in MAINTAINERS.
> > >
> > > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >
> > Reviewed-by: Christian König <christian.koenig@amd.com>
>
> You'll push this too?
> -Daniel
>
> > > ---
> > > Christian, please pick this patch.
> > > applies cleanly on current master and next-20200303
> > >
> > > MAINTAINERS | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 6158a143a13e..3d6cb2789c9e 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -5022,7 +5022,7 @@ L: dri-devel@lists.freedesktop.org
> > > L: linaro-mm-sig@lists.linaro.org (moderated for non-subscribers)
> > > F: drivers/dma-buf/
> > > F: include/linux/dma-buf*
> > > -F: include/linux/reservation.h
> > > +F: include/linux/dma-resv.h
> > > F: include/linux/*fence.h
> > > F: Documentation/driver-api/dma-buf.rst
> > > K: dma_(buf|fence|resv)
Slightly unrelated:
The K: entry matches a lot of other things
and may have a lot of false positive matches
like any variable named dma_buffer
This should also use (?:...) to avoid a perl
capture group.
Perhaps:
K: '\bdma_(?:buf|fence|resv)\b'
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] MAINTAINERS: adjust to reservation.h renaming
2020-03-06 10:56 ` Joe Perches
@ 2020-03-16 9:50 ` Daniel Vetter
2020-03-16 9:56 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2020-03-16 9:50 UTC (permalink / raw)
To: Joe Perches
Cc: intel-gfx, kernel-janitors, linux-kernel, dri-devel,
Lukas Bulwahn, Sebastian Duda, Christian König, linux-media
On Fri, Mar 06, 2020 at 02:56:06AM -0800, Joe Perches wrote:
> On Fri, 2020-03-06 at 11:39 +0100, Daniel Vetter wrote:
> > On Wed, Mar 04, 2020 at 01:08:32PM +0100, Christian König wrote:
> > > Am 04.03.20 um 13:07 schrieb Lukas Bulwahn:
> > > > Commit 52791eeec1d9 ("dma-buf: rename reservation_object to dma_resv")
> > > > renamed include/linux/reservation.h to include/linux/dma-resv.h, but
> > > > missed the reference in the MAINTAINERS entry.
> > > >
> > > > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > > >
> > > > warning: no file matches F: include/linux/reservation.h
> > > >
> > > > Adjust the DMA BUFFER SHARING FRAMEWORK entry in MAINTAINERS.
> > > >
> > > > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > > > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > >
> > > Reviewed-by: Christian König <christian.koenig@amd.com>
> >
> > You'll push this too?
> > -Daniel
> >
> > > > ---
> > > > Christian, please pick this patch.
> > > > applies cleanly on current master and next-20200303
> > > >
> > > > MAINTAINERS | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 6158a143a13e..3d6cb2789c9e 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -5022,7 +5022,7 @@ L: dri-devel@lists.freedesktop.org
> > > > L: linaro-mm-sig@lists.linaro.org (moderated for non-subscribers)
> > > > F: drivers/dma-buf/
> > > > F: include/linux/dma-buf*
> > > > -F: include/linux/reservation.h
> > > > +F: include/linux/dma-resv.h
> > > > F: include/linux/*fence.h
> > > > F: Documentation/driver-api/dma-buf.rst
> > > > K: dma_(buf|fence|resv)
>
> Slightly unrelated:
>
> The K: entry matches a lot of other things
> and may have a lot of false positive matches
> like any variable named dma_buffer
>
> This should also use (?:...) to avoid a perl
> capture group.
>
> Perhaps:
>
> K: '\bdma_(?:buf|fence|resv)\b'
Hm either people aren't using get_maintainers.pl consistently, or it
doesn't seem to be a real world problem. I'm not seeing any unrelated
patches on dri-devel at least.
But happy to merge such a patch if it shows up ofc, it's definitely the
more correct thing :-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] MAINTAINERS: adjust to reservation.h renaming
2020-03-16 9:50 ` Daniel Vetter
@ 2020-03-16 9:56 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2020-03-16 9:56 UTC (permalink / raw)
To: Joe Perches, Christian König, Lukas Bulwahn, intel-gfx,
kernel-janitors, linux-kernel, dri-devel, Sebastian Duda,
Sumit Semwal, linux-media
On Mon, Mar 16, 2020 at 10:50:07AM +0100, Daniel Vetter wrote:
> On Fri, Mar 06, 2020 at 02:56:06AM -0800, Joe Perches wrote:
> > On Fri, 2020-03-06 at 11:39 +0100, Daniel Vetter wrote:
> > > On Wed, Mar 04, 2020 at 01:08:32PM +0100, Christian König wrote:
> > > > Am 04.03.20 um 13:07 schrieb Lukas Bulwahn:
> > > > > Commit 52791eeec1d9 ("dma-buf: rename reservation_object to dma_resv")
> > > > > renamed include/linux/reservation.h to include/linux/dma-resv.h, but
> > > > > missed the reference in the MAINTAINERS entry.
> > > > >
> > > > > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > > > >
> > > > > warning: no file matches F: include/linux/reservation.h
> > > > >
> > > > > Adjust the DMA BUFFER SHARING FRAMEWORK entry in MAINTAINERS.
> > > > >
> > > > > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > > > > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > >
> > > > Reviewed-by: Christian König <christian.koenig@amd.com>
> > >
> > > You'll push this too?
> > > -Daniel
> > >
> > > > > ---
> > > > > Christian, please pick this patch.
> > > > > applies cleanly on current master and next-20200303
> > > > >
> > > > > MAINTAINERS | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 6158a143a13e..3d6cb2789c9e 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -5022,7 +5022,7 @@ L: dri-devel@lists.freedesktop.org
> > > > > L: linaro-mm-sig@lists.linaro.org (moderated for non-subscribers)
> > > > > F: drivers/dma-buf/
> > > > > F: include/linux/dma-buf*
> > > > > -F: include/linux/reservation.h
> > > > > +F: include/linux/dma-resv.h
> > > > > F: include/linux/*fence.h
> > > > > F: Documentation/driver-api/dma-buf.rst
> > > > > K: dma_(buf|fence|resv)
> >
> > Slightly unrelated:
> >
> > The K: entry matches a lot of other things
> > and may have a lot of false positive matches
> > like any variable named dma_buffer
> >
> > This should also use (?:...) to avoid a perl
> > capture group.
> >
> > Perhaps:
> >
> > K: '\bdma_(?:buf|fence|resv)\b'
>
> Hm either people aren't using get_maintainers.pl consistently, or it
> doesn't seem to be a real world problem. I'm not seeing any unrelated
> patches on dri-devel at least.
>
> But happy to merge such a patch if it shows up ofc, it's definitely the
> more correct thing :-)
Ofc as usual if you lean out the window you immediately get to eat your
hat, right after sending this I got a mail from syzbot about some random
stuff because of this :-)
I'm gonna do the patch now ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-16 9:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 12:07 [PATCH] MAINTAINERS: adjust to reservation.h renaming Lukas Bulwahn
2020-03-04 12:08 ` Christian König
2020-03-06 10:39 ` [Intel-gfx] " Daniel Vetter
2020-03-06 10:56 ` Joe Perches
2020-03-16 9:50 ` Daniel Vetter
2020-03-16 9:56 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).