* [PATCH 0/4] drm/amd/display: remove some set but not used variables
@ 2019-11-14 12:36 zhengbin
2019-11-14 12:36 ` zhengbin
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland-5C7GfCeVMHo, sunpeng.li-5C7GfCeVMHo,
alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
David1.Zhou-5C7GfCeVMHo, airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: zhengbin13-hv44wF8Li93QT0dZR+AlfA
zhengbin (4):
drm/amd/display: remove set but not used variable 'old_plane_crtc'
drm/amd/display: remove set but not used variable 'bp' in
bios_parser2.c
drm/amd/display: remove set but not used variable 'bp' in
bios_parser.c
drm/amd/display: remove set but not used variable 'min_content'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 --
drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 --
4 files changed, 1 insertion(+), 8 deletions(-)
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 0/4] drm/amd/display: remove some set but not used variables
2019-11-14 12:36 [PATCH 0/4] drm/amd/display: remove some set but not used variables zhengbin
@ 2019-11-14 12:36 ` zhengbin
[not found] ` <1573734987-119703-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-11-14 16:41 ` [PATCH 0/4] drm/amd/display: remove some set but not used variables Harry Wentland
2 siblings, 0 replies; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, amd-gfx, dri-devel
Cc: zhengbin13
zhengbin (4):
drm/amd/display: remove set but not used variable 'old_plane_crtc'
drm/amd/display: remove set but not used variable 'bp' in
bios_parser2.c
drm/amd/display: remove set but not used variable 'bp' in
bios_parser.c
drm/amd/display: remove set but not used variable 'min_content'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 --
drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 --
4 files changed, 1 insertion(+), 8 deletions(-)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/4] drm/amd/display: remove set but not used variable 'old_plane_crtc'
[not found] ` <1573734987-119703-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` [PATCH 2/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser2.c zhengbin
` (2 subsequent siblings)
3 siblings, 1 reply; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland-5C7GfCeVMHo, sunpeng.li-5C7GfCeVMHo,
alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
David1.Zhou-5C7GfCeVMHo, airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: zhengbin13-hv44wF8Li93QT0dZR+AlfA
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: In function dm_determine_update_type_for_commit:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:6516:36: warning: variable old_plane_crtc set but not used [-Wunused-but-set-variable]
It is introduced by commit a87fa9938749 ("drm/amd/display:
Build stream update and plane updates in dm"), but never used,
so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index c2700bc..700cbd5 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7611,7 +7611,7 @@ dm_determine_update_type_for_commit(struct amdgpu_display_manager *dm,
int i, j, num_plane, ret = 0;
struct drm_plane_state *old_plane_state, *new_plane_state;
struct dm_plane_state *new_dm_plane_state, *old_dm_plane_state;
- struct drm_crtc *new_plane_crtc, *old_plane_crtc;
+ struct drm_crtc *new_plane_crtc;
struct drm_plane *plane;
struct drm_crtc *crtc;
@@ -7657,7 +7657,6 @@ dm_determine_update_type_for_commit(struct amdgpu_display_manager *dm,
uint64_t tiling_flags;
new_plane_crtc = new_plane_state->crtc;
- old_plane_crtc = old_plane_state->crtc;
new_dm_plane_state = to_dm_plane_state(new_plane_state);
old_dm_plane_state = to_dm_plane_state(old_plane_state);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 1/4] drm/amd/display: remove set but not used variable 'old_plane_crtc'
2019-11-14 12:36 ` [PATCH 1/4] drm/amd/display: remove set but not used variable 'old_plane_crtc' zhengbin
@ 2019-11-14 12:36 ` zhengbin
0 siblings, 0 replies; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: In function dm_determine_update_type_for_commit:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:6516:36: warning: variable old_plane_crtc set but not used [-Wunused-but-set-variable]
It is introduced by commit a87fa9938749 ("drm/amd/display:
Build stream update and plane updates in dm"), but never used,
so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index c2700bc..700cbd5 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7611,7 +7611,7 @@ dm_determine_update_type_for_commit(struct amdgpu_display_manager *dm,
int i, j, num_plane, ret = 0;
struct drm_plane_state *old_plane_state, *new_plane_state;
struct dm_plane_state *new_dm_plane_state, *old_dm_plane_state;
- struct drm_crtc *new_plane_crtc, *old_plane_crtc;
+ struct drm_crtc *new_plane_crtc;
struct drm_plane *plane;
struct drm_crtc *crtc;
@@ -7657,7 +7657,6 @@ dm_determine_update_type_for_commit(struct amdgpu_display_manager *dm,
uint64_t tiling_flags;
new_plane_crtc = new_plane_state->crtc;
- old_plane_crtc = old_plane_state->crtc;
new_dm_plane_state = to_dm_plane_state(new_plane_state);
old_dm_plane_state = to_dm_plane_state(old_plane_state);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser2.c
[not found] ` <1573734987-119703-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-11-14 12:36 ` [PATCH 1/4] drm/amd/display: remove set but not used variable 'old_plane_crtc' zhengbin
@ 2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` [PATCH 3/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser.c zhengbin
2019-11-14 12:36 ` [PATCH 4/4] drm/amd/display: remove set but not used variable 'min_content' zhengbin
3 siblings, 1 reply; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland-5C7GfCeVMHo, sunpeng.li-5C7GfCeVMHo,
alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
David1.Zhou-5C7GfCeVMHo, airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: zhengbin13-hv44wF8Li93QT0dZR+AlfA
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c: In function bios_get_board_layout_info:
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c:1826:22: warning: variable bp set but not used [-Wunused-but-set-variable]
It is introduced by commit 1eeedbcc20d6 ("drm/amd/display:
get board layout for edid emulation"), but never used,
so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
index 6e29ba8..9dc8d4e 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
@@ -1838,7 +1838,6 @@ static enum bp_result bios_get_board_layout_info(
struct board_layout_info *board_layout_info)
{
unsigned int i;
- struct bios_parser *bp;
enum bp_result record_result;
const unsigned int slot_index_to_vbios_id[MAX_BOARD_SLOTS] = {
@@ -1847,7 +1846,6 @@ static enum bp_result bios_get_board_layout_info(
0, 0
};
- bp = BP_FROM_DCB(dcb);
if (board_layout_info == NULL) {
DC_LOG_DETECTION_EDID_PARSER("Invalid board_layout_info\n");
return BP_RESULT_BADINPUT;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser2.c
2019-11-14 12:36 ` [PATCH 2/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser2.c zhengbin
@ 2019-11-14 12:36 ` zhengbin
0 siblings, 0 replies; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c: In function bios_get_board_layout_info:
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c:1826:22: warning: variable bp set but not used [-Wunused-but-set-variable]
It is introduced by commit 1eeedbcc20d6 ("drm/amd/display:
get board layout for edid emulation"), but never used,
so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
index 6e29ba8..9dc8d4e 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
@@ -1838,7 +1838,6 @@ static enum bp_result bios_get_board_layout_info(
struct board_layout_info *board_layout_info)
{
unsigned int i;
- struct bios_parser *bp;
enum bp_result record_result;
const unsigned int slot_index_to_vbios_id[MAX_BOARD_SLOTS] = {
@@ -1847,7 +1846,6 @@ static enum bp_result bios_get_board_layout_info(
0, 0
};
- bp = BP_FROM_DCB(dcb);
if (board_layout_info == NULL) {
DC_LOG_DETECTION_EDID_PARSER("Invalid board_layout_info\n");
return BP_RESULT_BADINPUT;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser.c
[not found] ` <1573734987-119703-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-11-14 12:36 ` [PATCH 1/4] drm/amd/display: remove set but not used variable 'old_plane_crtc' zhengbin
2019-11-14 12:36 ` [PATCH 2/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser2.c zhengbin
@ 2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` [PATCH 4/4] drm/amd/display: remove set but not used variable 'min_content' zhengbin
3 siblings, 1 reply; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland-5C7GfCeVMHo, sunpeng.li-5C7GfCeVMHo,
alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
David1.Zhou-5C7GfCeVMHo, airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: zhengbin13-hv44wF8Li93QT0dZR+AlfA
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c: In function bios_get_board_layout_info:
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:2743:22: warning: variable bp set but not used [-Wunused-but-set-variable]
It is introduced by commit 1eeedbcc20d6 ("drm/amd/display:
get board layout for edid emulation"), but never used,
so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
index 823843c..c34797c 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
@@ -2739,7 +2739,6 @@ static enum bp_result bios_get_board_layout_info(
struct board_layout_info *board_layout_info)
{
unsigned int i;
- struct bios_parser *bp;
enum bp_result record_result;
const unsigned int slot_index_to_vbios_id[MAX_BOARD_SLOTS] = {
@@ -2748,7 +2747,6 @@ static enum bp_result bios_get_board_layout_info(
0, 0
};
- bp = BP_FROM_DCB(dcb);
if (board_layout_info == NULL) {
DC_LOG_DETECTION_EDID_PARSER("Invalid board_layout_info\n");
return BP_RESULT_BADINPUT;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser.c
2019-11-14 12:36 ` [PATCH 3/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser.c zhengbin
@ 2019-11-14 12:36 ` zhengbin
0 siblings, 0 replies; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c: In function bios_get_board_layout_info:
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:2743:22: warning: variable bp set but not used [-Wunused-but-set-variable]
It is introduced by commit 1eeedbcc20d6 ("drm/amd/display:
get board layout for edid emulation"), but never used,
so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
index 823843c..c34797c 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
@@ -2739,7 +2739,6 @@ static enum bp_result bios_get_board_layout_info(
struct board_layout_info *board_layout_info)
{
unsigned int i;
- struct bios_parser *bp;
enum bp_result record_result;
const unsigned int slot_index_to_vbios_id[MAX_BOARD_SLOTS] = {
@@ -2748,7 +2747,6 @@ static enum bp_result bios_get_board_layout_info(
0, 0
};
- bp = BP_FROM_DCB(dcb);
if (board_layout_info == NULL) {
DC_LOG_DETECTION_EDID_PARSER("Invalid board_layout_info\n");
return BP_RESULT_BADINPUT;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/4] drm/amd/display: remove set but not used variable 'min_content'
[not found] ` <1573734987-119703-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
` (2 preceding siblings ...)
2019-11-14 12:36 ` [PATCH 3/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser.c zhengbin
@ 2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` zhengbin
3 siblings, 1 reply; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland-5C7GfCeVMHo, sunpeng.li-5C7GfCeVMHo,
alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
David1.Zhou-5C7GfCeVMHo, airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: zhengbin13-hv44wF8Li93QT0dZR+AlfA
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/modules/color/color_gamma.c: In function build_freesync_hdr:
drivers/gpu/drm/amd/display/modules/color/color_gamma.c:830:20: warning: variable min_content set but not used [-Wunused-but-set-variable]
It is not used since commit 50575eb5b339 ("drm/amd/display:
Only use EETF when maxCL > max display")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
index 1de4805..9b121b0 100644
--- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
+++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
@@ -937,7 +937,6 @@ static bool build_freesync_hdr(struct pwl_float_data_ex *rgb_regamma,
struct fixed31_32 max_display;
struct fixed31_32 min_display;
struct fixed31_32 max_content;
- struct fixed31_32 min_content;
struct fixed31_32 clip = dc_fixpt_one;
struct fixed31_32 output;
bool use_eetf = false;
@@ -951,7 +950,6 @@ static bool build_freesync_hdr(struct pwl_float_data_ex *rgb_regamma,
max_display = dc_fixpt_from_int(fs_params->max_display);
min_display = dc_fixpt_from_fraction(fs_params->min_display, 10000);
max_content = dc_fixpt_from_int(fs_params->max_content);
- min_content = dc_fixpt_from_fraction(fs_params->min_content, 10000);
sdr_white_level = dc_fixpt_from_int(fs_params->sdr_white_level);
if (fs_params->min_display > 1000) // cap at 0.1 at the bottom
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/4] drm/amd/display: remove set but not used variable 'min_content'
2019-11-14 12:36 ` [PATCH 4/4] drm/amd/display: remove set but not used variable 'min_content' zhengbin
@ 2019-11-14 12:36 ` zhengbin
0 siblings, 0 replies; 13+ messages in thread
From: zhengbin @ 2019-11-14 12:36 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/modules/color/color_gamma.c: In function build_freesync_hdr:
drivers/gpu/drm/amd/display/modules/color/color_gamma.c:830:20: warning: variable min_content set but not used [-Wunused-but-set-variable]
It is not used since commit 50575eb5b339 ("drm/amd/display:
Only use EETF when maxCL > max display")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
index 1de4805..9b121b0 100644
--- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
+++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
@@ -937,7 +937,6 @@ static bool build_freesync_hdr(struct pwl_float_data_ex *rgb_regamma,
struct fixed31_32 max_display;
struct fixed31_32 min_display;
struct fixed31_32 max_content;
- struct fixed31_32 min_content;
struct fixed31_32 clip = dc_fixpt_one;
struct fixed31_32 output;
bool use_eetf = false;
@@ -951,7 +950,6 @@ static bool build_freesync_hdr(struct pwl_float_data_ex *rgb_regamma,
max_display = dc_fixpt_from_int(fs_params->max_display);
min_display = dc_fixpt_from_fraction(fs_params->min_display, 10000);
max_content = dc_fixpt_from_int(fs_params->max_content);
- min_content = dc_fixpt_from_fraction(fs_params->min_content, 10000);
sdr_white_level = dc_fixpt_from_int(fs_params->sdr_white_level);
if (fs_params->min_display > 1000) // cap at 0.1 at the bottom
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 0/4] drm/amd/display: remove some set but not used variables
2019-11-14 12:36 [PATCH 0/4] drm/amd/display: remove some set but not used variables zhengbin
2019-11-14 12:36 ` zhengbin
[not found] ` <1573734987-119703-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2019-11-14 16:41 ` Harry Wentland
2019-11-14 20:11 ` Alex Deucher
2 siblings, 1 reply; 13+ messages in thread
From: Harry Wentland @ 2019-11-14 16:41 UTC (permalink / raw)
To: zhengbin, harry.wentland, sunpeng.li, alexander.deucher,
christian.koenig, David1.Zhou, airlied, daniel, amd-gfx,
dri-devel
On 2019-11-14 7:36 a.m., zhengbin wrote:
> zhengbin (4):
> drm/amd/display: remove set but not used variable 'old_plane_crtc'
> drm/amd/display: remove set but not used variable 'bp' in
> bios_parser2.c
> drm/amd/display: remove set but not used variable 'bp' in
> bios_parser.c
> drm/amd/display: remove set but not used variable 'min_content'
>
These would be fine as a single patch as well but I don't have a strong
preference either way.
Patches are:
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 --
> drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 --
> 4 files changed, 1 insertion(+), 8 deletions(-)
>
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/4] drm/amd/display: remove some set but not used variables
2019-11-14 16:41 ` [PATCH 0/4] drm/amd/display: remove some set but not used variables Harry Wentland
@ 2019-11-14 20:11 ` Alex Deucher
2019-11-14 20:11 ` Alex Deucher
0 siblings, 1 reply; 13+ messages in thread
From: Alex Deucher @ 2019-11-14 20:11 UTC (permalink / raw)
To: Harry Wentland
Cc: Leo (Sunpeng) Li, amd-gfx list, zhengbin, Dave Airlie,
Maling list - DRI developers, Deucher, Alexander,
Christian Koenig
On Thu, Nov 14, 2019 at 11:41 AM Harry Wentland <hwentlan@amd.com> wrote:
>
> On 2019-11-14 7:36 a.m., zhengbin wrote:
> > zhengbin (4):
> > drm/amd/display: remove set but not used variable 'old_plane_crtc'
> > drm/amd/display: remove set but not used variable 'bp' in
> > bios_parser2.c
> > drm/amd/display: remove set but not used variable 'bp' in
> > bios_parser.c
> > drm/amd/display: remove set but not used variable 'min_content'
> >
>
> These would be fine as a single patch as well but I don't have a strong
> preference either way.
>
> Patches are:
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Applied. Thanks!
Alex
>
> Harry
>
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> > drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
> > drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 --
> > drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 --
> > 4 files changed, 1 insertion(+), 8 deletions(-)
> >
> > --
> > 2.7.4
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/4] drm/amd/display: remove some set but not used variables
2019-11-14 20:11 ` Alex Deucher
@ 2019-11-14 20:11 ` Alex Deucher
0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2019-11-14 20:11 UTC (permalink / raw)
To: Harry Wentland
Cc: Leo (Sunpeng) Li, amd-gfx list, zhengbin, Dave Airlie,
Maling list - DRI developers, Deucher, Alexander,
Christian Koenig
On Thu, Nov 14, 2019 at 11:41 AM Harry Wentland <hwentlan@amd.com> wrote:
>
> On 2019-11-14 7:36 a.m., zhengbin wrote:
> > zhengbin (4):
> > drm/amd/display: remove set but not used variable 'old_plane_crtc'
> > drm/amd/display: remove set but not used variable 'bp' in
> > bios_parser2.c
> > drm/amd/display: remove set but not used variable 'bp' in
> > bios_parser.c
> > drm/amd/display: remove set but not used variable 'min_content'
> >
>
> These would be fine as a single patch as well but I don't have a strong
> preference either way.
>
> Patches are:
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Applied. Thanks!
Alex
>
> Harry
>
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> > drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 --
> > drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 --
> > drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 --
> > 4 files changed, 1 insertion(+), 8 deletions(-)
> >
> > --
> > 2.7.4
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-11-15 8:06 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 12:36 [PATCH 0/4] drm/amd/display: remove some set but not used variables zhengbin
2019-11-14 12:36 ` zhengbin
[not found] ` <1573734987-119703-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-11-14 12:36 ` [PATCH 1/4] drm/amd/display: remove set but not used variable 'old_plane_crtc' zhengbin
2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` [PATCH 2/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser2.c zhengbin
2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` [PATCH 3/4] drm/amd/display: remove set but not used variable 'bp' in bios_parser.c zhengbin
2019-11-14 12:36 ` zhengbin
2019-11-14 12:36 ` [PATCH 4/4] drm/amd/display: remove set but not used variable 'min_content' zhengbin
2019-11-14 12:36 ` zhengbin
2019-11-14 16:41 ` [PATCH 0/4] drm/amd/display: remove some set but not used variables Harry Wentland
2019-11-14 20:11 ` Alex Deucher
2019-11-14 20:11 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).