From: zhengbin <zhengbin13@huawei.com> To: bskeggs@redhat.com, lyude@redhat.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Cc: zhengbin13@huawei.com Subject: [PATCH 2/2] drm/nouveau: remove set but not used variable 'mem' Date: Fri, 15 Nov 2019 21:42:33 +0800 [thread overview] Message-ID: <1573825353-86268-3-git-send-email-zhengbin13@huawei.com> (raw) In-Reply-To: <1573825353-86268-1-git-send-email-zhengbin13@huawei.com> Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_vram_manager_new: drivers/gpu/drm/nouveau/nouveau_ttm.c:66:22: warning: variable mem set but not used [-Wunused-but-set-variable] drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_gart_manager_new: drivers/gpu/drm/nouveau/nouveau_ttm.c:106:22: warning: variable mem set but not used [-Wunused-but-set-variable] The first 'mem' is introduced by commit 9ce523cc3bf2 ("drm/nouveau: separate buffer object backing memory from nvkm structures"), but never used, so remove it. The second 'mem' is not used since commit d7722134b825 ("drm/nouveau: switch over to new memory and vmm interfaces") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: zhengbin <zhengbin13@huawei.com> --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index 77a0c6a..7ca0a24 100644 --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c @@ -63,14 +63,12 @@ nouveau_vram_manager_new(struct ttm_mem_type_manager *man, { struct nouveau_bo *nvbo = nouveau_bo(bo); struct nouveau_drm *drm = nouveau_bdev(bo->bdev); - struct nouveau_mem *mem; int ret; if (drm->client.device.info.ram_size == 0) return -ENOMEM; ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg); - mem = nouveau_mem(reg); if (ret) return ret; @@ -103,11 +101,9 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager *man, { struct nouveau_bo *nvbo = nouveau_bo(bo); struct nouveau_drm *drm = nouveau_bdev(bo->bdev); - struct nouveau_mem *mem; int ret; ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg); - mem = nouveau_mem(reg); if (ret) return ret; -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: zhengbin <zhengbin13@huawei.com> To: <bskeggs@redhat.com>, <lyude@redhat.com>, <airlied@linux.ie>, <daniel@ffwll.ch>, <dri-devel@lists.freedesktop.org>, <nouveau@lists.freedesktop.org> Cc: zhengbin13@huawei.com Subject: [PATCH 2/2] drm/nouveau: remove set but not used variable 'mem' Date: Fri, 15 Nov 2019 21:42:33 +0800 [thread overview] Message-ID: <1573825353-86268-3-git-send-email-zhengbin13@huawei.com> (raw) Message-ID: <20191115134233.VEq2dKB5L42On7pZYvhPEJwG6jiRtDlLxaLhND0V7lk@z> (raw) In-Reply-To: <1573825353-86268-1-git-send-email-zhengbin13@huawei.com> Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_vram_manager_new: drivers/gpu/drm/nouveau/nouveau_ttm.c:66:22: warning: variable mem set but not used [-Wunused-but-set-variable] drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_gart_manager_new: drivers/gpu/drm/nouveau/nouveau_ttm.c:106:22: warning: variable mem set but not used [-Wunused-but-set-variable] The first 'mem' is introduced by commit 9ce523cc3bf2 ("drm/nouveau: separate buffer object backing memory from nvkm structures"), but never used, so remove it. The second 'mem' is not used since commit d7722134b825 ("drm/nouveau: switch over to new memory and vmm interfaces") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: zhengbin <zhengbin13@huawei.com> --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index 77a0c6a..7ca0a24 100644 --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c @@ -63,14 +63,12 @@ nouveau_vram_manager_new(struct ttm_mem_type_manager *man, { struct nouveau_bo *nvbo = nouveau_bo(bo); struct nouveau_drm *drm = nouveau_bdev(bo->bdev); - struct nouveau_mem *mem; int ret; if (drm->client.device.info.ram_size == 0) return -ENOMEM; ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg); - mem = nouveau_mem(reg); if (ret) return ret; @@ -103,11 +101,9 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager *man, { struct nouveau_bo *nvbo = nouveau_bo(bo); struct nouveau_drm *drm = nouveau_bdev(bo->bdev); - struct nouveau_mem *mem; int ret; ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg); - mem = nouveau_mem(reg); if (ret) return ret; -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-15 13:42 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-15 13:42 [PATCH 0/2] drm/nouveau: remove some set but not used variables zhengbin 2019-11-15 13:42 ` zhengbin 2019-11-15 13:42 ` [PATCH 1/2] drm/nouveau: remove set but not used variable 'pclks', 'width' zhengbin 2019-11-15 13:42 ` zhengbin [not found] ` <1573825353-86268-2-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> 2019-11-15 17:59 ` Lyude Paul 2019-11-15 17:59 ` [PATCH 1/2] drm/nouveau: remove set but not used variable 'pclks','width' Lyude Paul 2019-11-15 13:42 ` zhengbin [this message] 2019-11-15 13:42 ` [PATCH 2/2] drm/nouveau: remove set but not used variable 'mem' zhengbin 2019-11-15 18:00 ` Lyude Paul 2019-11-15 18:00 ` Lyude Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1573825353-86268-3-git-send-email-zhengbin13@huawei.com \ --to=zhengbin13@huawei.com \ --cc=airlied@linux.ie \ --cc=bskeggs@redhat.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=lyude@redhat.com \ --cc=nouveau@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).