* [PATCH 00/16] constify copied structure
@ 2020-01-01 7:43 Julia Lawall
2020-01-01 7:43 ` [PATCH 07/16] video: sa1100fb: " Julia Lawall
2020-01-01 7:43 ` [PATCH 15/16] drm: bridge: dw-hdmi: " Julia Lawall
0 siblings, 2 replies; 6+ messages in thread
From: Julia Lawall @ 2020-01-01 7:43 UTC (permalink / raw)
To: Jernej Skrabec
Cc: linux-fbdev, alsa-devel, Jonas Karlman, linux-arm-msm, linux-usb,
kernel-janitors, linux-kernel, dri-devel, linux-gpio,
Laurent Pinchart, netdev, linuxppc-dev, linux-nfs,
linux-arm-kernel, linux-media
Make const static structures that are just copied into other structures.
The semantic patch that detects the opportunity for this change is as
follows: (http://coccinelle.lip6.fr/)
<smpl>
@r disable optional_qualifier@
identifier i,j;
position p;
@@
static struct i j@p = { ... };
@upd@
position p1;
identifier r.j;
expression e;
@@
e = j@p1
@ref@
position p2 != {r.p,upd.p1};
identifier r.j;
@@
j@p2
@script:ocaml depends on upd && !ref@
i << r.i;
j << r.j;
p << r.p;
@@
if j = (List.hd p).current_element
then Coccilib.print_main i p
</smpl>
---
arch/powerpc/sysdev/mpic.c | 4 ++--
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
drivers/media/i2c/mt9v111.c | 2 +-
drivers/media/platform/davinci/isif.c | 2 +-
drivers/media/usb/cx231xx/cx231xx-dvb.c | 2 +-
drivers/media/usb/dvb-usb-v2/anysee.c | 4 ++--
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 2 +-
drivers/ptp/ptp_clockmatrix.c | 2 +-
drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
drivers/video/fbdev/sa1100fb.c | 2 +-
net/sunrpc/xdr.c | 2 +-
sound/isa/ad1816a/ad1816a_lib.c | 2 +-
sound/pci/hda/hda_controller.c | 2 +-
sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +-
16 files changed, 18 insertions(+), 18 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 07/16] video: sa1100fb: constify copied structure
2020-01-01 7:43 [PATCH 00/16] constify copied structure Julia Lawall
@ 2020-01-01 7:43 ` Julia Lawall
2020-01-15 16:04 ` Bartlomiej Zolnierkiewicz
2020-01-01 7:43 ` [PATCH 15/16] drm: bridge: dw-hdmi: " Julia Lawall
1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2020-01-01 7:43 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-fbdev, kernel-janitors, linux-kernel, dri-devel
The monspecs structure is only copied into another structure,
so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/video/fbdev/sa1100fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
index 4680cc3efb81..c77b43dbc256 100644
--- a/drivers/video/fbdev/sa1100fb.c
+++ b/drivers/video/fbdev/sa1100fb.c
@@ -1053,7 +1053,7 @@ static int sa1100fb_map_video_memory(struct sa1100fb_info *fbi)
}
/* Fake monspecs to fill in fbinfo structure */
-static struct fb_monspecs monspecs = {
+static const struct fb_monspecs monspecs = {
.hfmin = 30000,
.hfmax = 70000,
.vfmin = 50,
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 15/16] drm: bridge: dw-hdmi: constify copied structure
2020-01-01 7:43 [PATCH 00/16] constify copied structure Julia Lawall
2020-01-01 7:43 ` [PATCH 07/16] video: sa1100fb: " Julia Lawall
@ 2020-01-01 7:43 ` Julia Lawall
2020-01-01 14:52 ` Laurent Pinchart
1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2020-01-01 7:43 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Jernej Skrabec, Jonas Karlman, David Airlie, Neil Armstrong,
kernel-janitors, linux-kernel, dri-devel, Laurent Pinchart
The dw_hdmi_hw structure is only copied into another structure,
so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
index 2b7539701b42..dd56996fe9c7 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
@@ -291,7 +291,7 @@ static irqreturn_t snd_dw_hdmi_irq(int irq, void *data)
return IRQ_HANDLED;
}
-static struct snd_pcm_hardware dw_hdmi_hw = {
+static const struct snd_pcm_hardware dw_hdmi_hw = {
.info = SNDRV_PCM_INFO_INTERLEAVED |
SNDRV_PCM_INFO_BLOCK_TRANSFER |
SNDRV_PCM_INFO_MMAP |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 15/16] drm: bridge: dw-hdmi: constify copied structure
2020-01-01 7:43 ` [PATCH 15/16] drm: bridge: dw-hdmi: " Julia Lawall
@ 2020-01-01 14:52 ` Laurent Pinchart
2020-01-06 14:40 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2020-01-01 14:52 UTC (permalink / raw)
To: Julia Lawall
Cc: Jernej Skrabec, Jonas Karlman, David Airlie, Neil Armstrong,
kernel-janitors, linux-kernel, dri-devel
Hi Julia,
Thank you for the patch.
On Wed, Jan 01, 2020 at 08:43:33AM +0100, Julia Lawall wrote:
> The dw_hdmi_hw structure is only copied into another structure,
> so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> index 2b7539701b42..dd56996fe9c7 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> @@ -291,7 +291,7 @@ static irqreturn_t snd_dw_hdmi_irq(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static struct snd_pcm_hardware dw_hdmi_hw = {
> +static const struct snd_pcm_hardware dw_hdmi_hw = {
> .info = SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_MMAP |
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 15/16] drm: bridge: dw-hdmi: constify copied structure
2020-01-01 14:52 ` Laurent Pinchart
@ 2020-01-06 14:40 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-01-06 14:40 UTC (permalink / raw)
To: Laurent Pinchart, Julia Lawall
Cc: Jernej Skrabec, Jonas Karlman, David Airlie, kernel-janitors,
linux-kernel, dri-devel
On 01/01/2020 15:52, Laurent Pinchart wrote:
> Hi Julia,
>
> Thank you for the patch.
>
> On Wed, Jan 01, 2020 at 08:43:33AM +0100, Julia Lawall wrote:
>> The dw_hdmi_hw structure is only copied into another structure,
>> so make it const.
>>
>> The opportunity for this change was found using Coccinelle.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> index 2b7539701b42..dd56996fe9c7 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> @@ -291,7 +291,7 @@ static irqreturn_t snd_dw_hdmi_irq(int irq, void *data)
>> return IRQ_HANDLED;
>> }
>>
>> -static struct snd_pcm_hardware dw_hdmi_hw = {
>> +static const struct snd_pcm_hardware dw_hdmi_hw = {
>> .info = SNDRV_PCM_INFO_INTERLEAVED |
>> SNDRV_PCM_INFO_BLOCK_TRANSFER |
>> SNDRV_PCM_INFO_MMAP |
>
Applied to drm-misc-next
Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 07/16] video: sa1100fb: constify copied structure
2020-01-01 7:43 ` [PATCH 07/16] video: sa1100fb: " Julia Lawall
@ 2020-01-15 16:04 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-15 16:04 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-fbdev, kernel-janitors, linux-kernel, dri-devel
On 1/1/20 8:43 AM, Julia Lawall wrote:
> The monspecs structure is only copied into another structure,
> so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Patch queued for v5.6, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/sa1100fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
> index 4680cc3efb81..c77b43dbc256 100644
> --- a/drivers/video/fbdev/sa1100fb.c
> +++ b/drivers/video/fbdev/sa1100fb.c
> @@ -1053,7 +1053,7 @@ static int sa1100fb_map_video_memory(struct sa1100fb_info *fbi)
> }
>
> /* Fake monspecs to fill in fbinfo structure */
> -static struct fb_monspecs monspecs = {
> +static const struct fb_monspecs monspecs = {
> .hfmin = 30000,
> .hfmax = 70000,
> .vfmin = 50,
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-15 16:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-01 7:43 [PATCH 00/16] constify copied structure Julia Lawall
2020-01-01 7:43 ` [PATCH 07/16] video: sa1100fb: " Julia Lawall
2020-01-15 16:04 ` Bartlomiej Zolnierkiewicz
2020-01-01 7:43 ` [PATCH 15/16] drm: bridge: dw-hdmi: " Julia Lawall
2020-01-01 14:52 ` Laurent Pinchart
2020-01-06 14:40 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).