* [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning
@ 2020-03-30 9:59 Ding Xiang
2020-03-31 14:50 ` [Xen-devel] " Oleksandr Andrushchenko
0 siblings, 1 reply; 3+ messages in thread
From: Ding Xiang @ 2020-03-30 9:59 UTC (permalink / raw)
To: oleksandr_andrushchenko, airlied, daniel
Cc: xen-devel, linux-kernel, dri-devel
Fix a static code checker warning:
drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
warn: passing zero to 'PTR_ERR'
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 4be49c1..3741420 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
obj = xen_drm_front_gem_create(dev, args->size);
if (IS_ERR_OR_NULL(obj)) {
- ret = PTR_ERR(obj);
+ ret = PTR_ERR_OR_ZERO(obj);
goto fail;
}
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning
2020-03-30 9:59 [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning Ding Xiang
@ 2020-03-31 14:50 ` Oleksandr Andrushchenko
2020-03-31 15:15 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Oleksandr Andrushchenko @ 2020-03-31 14:50 UTC (permalink / raw)
To: Ding Xiang, oleksandr_andrushchenko, airlied, daniel
Cc: xen-devel, linux-kernel, dri-devel
On 3/30/20 12:59, Ding Xiang wrote:
> Fix a static code checker warning:
> drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
> warn: passing zero to 'PTR_ERR'
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 4be49c1..3741420 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>
> obj = xen_drm_front_gem_create(dev, args->size);
> if (IS_ERR_OR_NULL(obj)) {
> - ret = PTR_ERR(obj);
> + ret = PTR_ERR_OR_ZERO(obj);
> goto fail;
> }
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning
2020-03-31 14:50 ` [Xen-devel] " Oleksandr Andrushchenko
@ 2020-03-31 15:15 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2020-03-31 15:15 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: oleksandr_andrushchenko, airlied, linux-kernel, dri-devel,
Ding Xiang, xen-devel
On Tue, Mar 31, 2020 at 05:50:10PM +0300, Oleksandr Andrushchenko wrote:
> On 3/30/20 12:59, Ding Xiang wrote:
> > Fix a static code checker warning:
> > drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
> > warn: passing zero to 'PTR_ERR'
> >
> > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
merged to drm-misc-next-fixese.
-Daniel
> > ---
> > drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> > index 4be49c1..3741420 100644
> > --- a/drivers/gpu/drm/xen/xen_drm_front.c
> > +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> > @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> > obj = xen_drm_front_gem_create(dev, args->size);
> > if (IS_ERR_OR_NULL(obj)) {
> > - ret = PTR_ERR(obj);
> > + ret = PTR_ERR_OR_ZERO(obj);
> > goto fail;
> > }
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-31 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 9:59 [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning Ding Xiang
2020-03-31 14:50 ` [Xen-devel] " Oleksandr Andrushchenko
2020-03-31 15:15 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).