* [PATCH] drm/tegra: dpaux: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-03-17 6:26 Tian Tao
0 siblings, 0 replies; only message in thread
From: Tian Tao @ 2021-03-17 6:26 UTC (permalink / raw)
To: airlied, daniel, p.zabel; +Cc: linux-tegra, dri-devel
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/tegra/dpaux.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index 105fb9c..0acaf66 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -521,7 +521,8 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
pm_runtime_get_sync(&pdev->dev);
- err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq, 0,
+ err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq,
+ IRQF_NO_AUTOEN,
dev_name(dpaux->dev), dpaux);
if (err < 0) {
dev_err(dpaux->dev, "failed to request IRQ#%u: %d\n",
@@ -529,8 +530,6 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
return err;
}
- disable_irq(dpaux->irq);
-
dpaux->aux.transfer = tegra_dpaux_transfer;
dpaux->aux.dev = &pdev->dev;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-17 6:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 6:26 [PATCH] drm/tegra: dpaux: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).