dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Polimera <quic_vpolimer@quicinc.com>
To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: quic_kalyant@quicinc.com, quic_sbillaka@quicinc.com,
	quic_abhinavk@quicinc.com, quic_vproddut@quicinc.com,
	quic_khsieh@quicinc.com, dianders@chromium.org,
	linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
	dmitry.baryshkov@linaro.org, quic_aravindh@quicinc.com,
	swboyd@chromium.org, Vinod Polimera <quic_vpolimer@quicinc.com>
Subject: [PATCH v6 07/10] drm/bridge: add psr support for panel bridge callbacks
Date: Mon, 11 Jul 2022 18:27:01 +0530	[thread overview]
Message-ID: <1657544224-10680-8-git-send-email-quic_vpolimer@quicinc.com> (raw)
In-Reply-To: <1657544224-10680-1-git-send-email-quic_vpolimer@quicinc.com>

This change will handle the psr entry exit cases in the panel
bridge atomic callback functions. For example, the panel power
should not turn off if the panel is entering psr.

Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
---
 drivers/gpu/drm/bridge/panel.c | 48 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index eeb9546..9770b8c 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -112,6 +112,18 @@ static void panel_bridge_atomic_pre_enable(struct drm_bridge *bridge,
 				struct drm_bridge_state *old_bridge_state)
 {
 	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
+	struct drm_atomic_state *atomic_state = old_bridge_state->base.state;
+	struct drm_encoder *encoder = bridge->encoder;
+	struct drm_crtc *crtc;
+	struct drm_crtc_state *old_crtc_state;
+
+	crtc = drm_atomic_get_new_crtc_for_encoder(atomic_state, encoder);
+	if (!crtc)
+		return;
+
+	old_crtc_state = drm_atomic_get_old_crtc_state(atomic_state, crtc);
+	if (old_crtc_state && old_crtc_state->self_refresh_active)
+		return;
 
 	drm_panel_prepare(panel_bridge->panel);
 }
@@ -120,6 +132,18 @@ static void panel_bridge_atomic_enable(struct drm_bridge *bridge,
 				struct drm_bridge_state *old_bridge_state)
 {
 	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
+	struct drm_atomic_state *atomic_state = old_bridge_state->base.state;
+	struct drm_encoder *encoder = bridge->encoder;
+	struct drm_crtc *crtc;
+	struct drm_crtc_state *old_crtc_state;
+
+	crtc = drm_atomic_get_new_crtc_for_encoder(atomic_state, encoder);
+	if (!crtc)
+		return;
+
+	old_crtc_state = drm_atomic_get_old_crtc_state(atomic_state, crtc);
+	if (old_crtc_state && old_crtc_state->self_refresh_active)
+		return;
 
 	drm_panel_enable(panel_bridge->panel);
 }
@@ -128,6 +152,18 @@ static void panel_bridge_atomic_disable(struct drm_bridge *bridge,
 				struct drm_bridge_state *old_bridge_state)
 {
 	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
+	struct drm_atomic_state *atomic_state = old_bridge_state->base.state;
+	struct drm_encoder *encoder = bridge->encoder;
+	struct drm_crtc *crtc;
+	struct drm_crtc_state *new_crtc_state;
+
+	crtc = drm_atomic_get_old_crtc_for_encoder(atomic_state, encoder);
+	if (!crtc)
+		return;
+
+	new_crtc_state = drm_atomic_get_new_crtc_state(atomic_state, crtc);
+	if (new_crtc_state && new_crtc_state->self_refresh_active)
+		return;
 
 	drm_panel_disable(panel_bridge->panel);
 }
@@ -136,6 +172,18 @@ static void panel_bridge_atomic_post_disable(struct drm_bridge *bridge,
 				struct drm_bridge_state *old_bridge_state)
 {
 	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
+	struct drm_atomic_state *atomic_state = old_bridge_state->base.state;
+	struct drm_encoder *encoder = bridge->encoder;
+	struct drm_crtc *crtc;
+	struct drm_crtc_state *new_crtc_state;
+
+	crtc = drm_atomic_get_old_crtc_for_encoder(atomic_state, encoder);
+	if (!crtc)
+		return;
+
+	new_crtc_state = drm_atomic_get_new_crtc_state(atomic_state, crtc);
+	if (new_crtc_state && new_crtc_state->self_refresh_active)
+		return;
 
 	drm_panel_unprepare(panel_bridge->panel);
 }
-- 
2.7.4


  parent reply	other threads:[~2022-07-11 12:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 12:56 [PATCH v6 00/10] Add PSR support for eDP Vinod Polimera
2022-07-11 12:56 ` [PATCH v6 01/10] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc Vinod Polimera
2022-07-14  5:08   ` Vinod Polimera
2022-07-29  0:18   ` Doug Anderson
2022-09-13 14:52     ` Vinod Polimera
2022-07-11 12:56 ` [PATCH v6 02/10] drm: add helper functions to retrieve old and new crtc Vinod Polimera
2022-07-14  5:08   ` Vinod Polimera
2022-07-29  0:18   ` Doug Anderson
2022-07-11 12:56 ` [PATCH v6 03/10] drm/msm/dp: use atomic callbacks for DP bridge ops Vinod Polimera
2022-07-11 14:20   ` Dmitry Baryshkov
2022-07-29  0:18   ` Doug Anderson
2022-07-11 12:56 ` [PATCH v6 04/10] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera
2022-07-11 14:21   ` Dmitry Baryshkov
2022-07-29  0:20   ` Doug Anderson
2022-10-12  7:23     ` Sankeerth Billakanti
2022-07-11 12:56 ` [PATCH v6 05/10] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera
2022-07-11 14:18   ` Dmitry Baryshkov
2022-07-11 12:57 ` [PATCH v6 06/10] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera
2022-07-11 12:57 ` Vinod Polimera [this message]
2022-07-14  5:09   ` [PATCH v6 07/10] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera
2022-07-11 12:57 ` [PATCH v6 08/10] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera
2022-07-11 12:57 ` [PATCH v6 09/10] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera
2022-07-11 14:19   ` Dmitry Baryshkov
2022-07-11 12:57 ` [PATCH v6 10/10] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Vinod Polimera
2022-07-11 14:19   ` Dmitry Baryshkov
2022-07-29  0:22 ` [PATCH v6 00/10] Add PSR support for eDP Doug Anderson
2022-08-04 16:21   ` Robert Foss
2022-08-04 17:54     ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1657544224-10680-8-git-send-email-quic_vpolimer@quicinc.com \
    --to=quic_vpolimer@quicinc.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_aravindh@quicinc.com \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).