From: Robert Foss <robert.foss@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: quic_kalyant <quic_kalyant@quicinc.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
"Abhinav Kumar \(QUIC\)" <quic_abhinavk@quicinc.com>,
quic_vproddut <quic_vproddut@quicinc.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"Kuogee Hsieh \(QUIC\)" <quic_khsieh@quicinc.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Vinod Polimera <quic_vpolimer@quicinc.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
"Aravind Venkateswaran \(QUIC\)" <quic_aravindh@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>,
freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v6 00/10] Add PSR support for eDP
Date: Thu, 4 Aug 2022 18:21:05 +0200 [thread overview]
Message-ID: <CAG3jFyv3up0o4S+UYMKaAjanKL6hxCNtEa5zQTQEeNREab-NRA@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=U_GStziLOCVLs_FC_2Vr=ykGfbb4ZtUp79iV8V=B0cEA@mail.gmail.com>
On Fri, 29 Jul 2022 at 02:22, Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Mon, Jul 11, 2022 at 5:57 AM Vinod Polimera
> <quic_vpolimer@quicinc.com> wrote:
> >
> > Changes in v2:
> > - Use dp bridge to set psr entry/exit instead of dpu_enocder.
> > - Don't modify whitespaces.
> > - Set self refresh aware from atomic_check.
> > - Set self refresh aware only if psr is supported.
> > - Provide a stub for msm_dp_display_set_psr.
> > - Move dp functions to bridge code.
> >
> > Changes in v3:
> > - Change callback names to reflect atomic interfaces.
> > - Move bridge callback change to separate patch as suggested by Dmitry.
> > - Remove psr function declaration from msm_drv.h.
> > - Set self_refresh_aware flag only if psr is supported.
> > - Modify the variable names to simpler form.
> > - Define bit fields for PSR settings.
> > - Add comments explaining the steps to enter/exit psr.
> > - Change DRM_INFO to drm_dbg_db.
> >
> > Changes in v4:
> > - Move the get crtc functions to drm_atomic.
> > - Add atomic functions for DP bridge too.
> > - Add ternary operator to choose eDP or DP ops.
> > - Return true/false instead of 1/0.
> > - mode_valid missing in the eDP bridge ops.
> > - Move the functions to get crtc into drm_atomic.c.
> > - Fix compilation issues.
> > - Remove dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc.
> > - Check for crtc state enable while reserving resources.
> >
> > Changes in v5:
> > - Move the mode_valid changes into a different patch.
> > - Complete psr_op_comp only when isr is set.
> > - Move the DP atomic callback changes to a different patch.
> > - Get crtc from drm connector state crtc.
> > - Move to separate patch for check for crtc state enable while
> > reserving resources.
> >
> > Changes in v6:
> > - Remove crtc from dpu_encoder_virt struct.
> > - fix crtc check during vblank toggle crtc.
> > - Misc changes.
> >
> > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
> > Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
> > Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
> >
> > Vinod Polimera (10):
> > drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector
> > state instead of dpu_enc
> > drm: add helper functions to retrieve old and new crtc
> > drm/msm/dp: use atomic callbacks for DP bridge ops
> > drm/msm/dp: Add basic PSR support for eDP
> > drm/msm/dp: use the eDP bridge ops to validate eDP modes
> > drm/bridge: use atomic enable/disable callbacks for panel bridge
> > drm/bridge: add psr support for panel bridge callbacks
> > drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder
> > functions
> > drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver
> > drm/msm/disp/dpu: check for crtc enable rather than crtc active to
> > release shared resources
> >
> > drivers/gpu/drm/bridge/panel.c | 68 ++++++++--
> > drivers/gpu/drm/drm_atomic.c | 60 +++++++++
> > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 17 ++-
> > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 +++++----
> > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 8 --
> > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +-
> > drivers/gpu/drm/msm/dp/dp_catalog.c | 81 ++++++++++++
> > drivers/gpu/drm/msm/dp/dp_catalog.h | 4 +
> > drivers/gpu/drm/msm/dp/dp_ctrl.c | 73 +++++++++++
> > drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 +
> > drivers/gpu/drm/msm/dp/dp_display.c | 31 +++--
> > drivers/gpu/drm/msm/dp/dp_display.h | 2 +
> > drivers/gpu/drm/msm/dp/dp_drm.c | 184 ++++++++++++++++++++++++++--
> > drivers/gpu/drm/msm/dp/dp_drm.h | 9 +-
> > drivers/gpu/drm/msm/dp/dp_link.c | 36 ++++++
> > drivers/gpu/drm/msm/dp/dp_panel.c | 22 ++++
> > drivers/gpu/drm/msm/dp/dp_panel.h | 6 +
> > drivers/gpu/drm/msm/dp/dp_reg.h | 27 ++++
> > include/drm/drm_atomic.h | 7 ++
> > 19 files changed, 631 insertions(+), 65 deletions(-)
>
Which tree does this series apply to?
next prev parent reply other threads:[~2022-08-04 16:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 12:56 [PATCH v6 00/10] Add PSR support for eDP Vinod Polimera
2022-07-11 12:56 ` [PATCH v6 01/10] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc Vinod Polimera
2022-07-14 5:08 ` Vinod Polimera
2022-07-29 0:18 ` Doug Anderson
2022-09-13 14:52 ` Vinod Polimera
2022-07-11 12:56 ` [PATCH v6 02/10] drm: add helper functions to retrieve old and new crtc Vinod Polimera
2022-07-14 5:08 ` Vinod Polimera
2022-07-29 0:18 ` Doug Anderson
2022-07-11 12:56 ` [PATCH v6 03/10] drm/msm/dp: use atomic callbacks for DP bridge ops Vinod Polimera
2022-07-11 14:20 ` Dmitry Baryshkov
2022-07-29 0:18 ` Doug Anderson
2022-07-11 12:56 ` [PATCH v6 04/10] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera
2022-07-11 14:21 ` Dmitry Baryshkov
2022-07-29 0:20 ` Doug Anderson
2022-10-12 7:23 ` Sankeerth Billakanti
2022-07-11 12:56 ` [PATCH v6 05/10] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera
2022-07-11 14:18 ` Dmitry Baryshkov
2022-07-11 12:57 ` [PATCH v6 06/10] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera
2022-07-11 12:57 ` [PATCH v6 07/10] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera
2022-07-14 5:09 ` Vinod Polimera
2022-07-11 12:57 ` [PATCH v6 08/10] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera
2022-07-11 12:57 ` [PATCH v6 09/10] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera
2022-07-11 14:19 ` Dmitry Baryshkov
2022-07-11 12:57 ` [PATCH v6 10/10] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Vinod Polimera
2022-07-11 14:19 ` Dmitry Baryshkov
2022-07-29 0:22 ` [PATCH v6 00/10] Add PSR support for eDP Doug Anderson
2022-08-04 16:21 ` Robert Foss [this message]
2022-08-04 17:54 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG3jFyv3up0o4S+UYMKaAjanKL6hxCNtEa5zQTQEeNREab-NRA@mail.gmail.com \
--to=robert.foss@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_aravindh@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).