* [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals
@ 2022-08-12 7:37 Samuel Holland
2022-08-12 7:43 ` Krzysztof Kozlowski
2022-08-15 7:47 ` Maxime Ripard
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Holland @ 2022-08-12 7:37 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec, Maxime Ripard
Cc: devicetree, Samuel Holland, David Airlie, linux-kernel,
dri-devel, Rob Herring, Krzysztof Kozlowski, linux-sunxi,
linux-arm-kernel
When adding the D1 TCON bindings, I missed the conditional blocks that
restrict the binding for TCON LCD vs TCON TV hardware. Add the D1 TCON
variants to the appropriate blocks for DE2 TCON LCDs and TCON TVs.
Fixes: ae5a5d26c15c ("dt-bindings: display: Add D1 display engine compatibles")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
.../devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
index 4a92a4c7dcd7..f8168986a0a9 100644
--- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
+++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
@@ -224,43 +224,45 @@ allOf:
- const: ahb
- const: tcon-ch0
- const: lvds-alt
- if:
properties:
compatible:
contains:
enum:
- allwinner,sun8i-a83t-tcon-lcd
- allwinner,sun8i-v3s-tcon
- allwinner,sun9i-a80-tcon-lcd
+ - allwinner,sun20i-d1-tcon-lcd
then:
properties:
clocks:
minItems: 2
clock-names:
items:
- const: ahb
- const: tcon-ch0
- if:
properties:
compatible:
contains:
enum:
- allwinner,sun8i-a83t-tcon-tv
- allwinner,sun8i-r40-tcon-tv
- allwinner,sun9i-a80-tcon-tv
+ - allwinner,sun20i-d1-tcon-tv
then:
properties:
clocks:
minItems: 2
clock-names:
items:
- const: ahb
- const: tcon-ch1
- if:
@@ -269,40 +271,42 @@ allOf:
contains:
enum:
- allwinner,sun5i-a13-tcon
- allwinner,sun6i-a31-tcon
- allwinner,sun6i-a31s-tcon
- allwinner,sun7i-a20-tcon
- allwinner,sun8i-a23-tcon
- allwinner,sun8i-a33-tcon
- allwinner,sun8i-v3s-tcon
- allwinner,sun9i-a80-tcon-lcd
- allwinner,sun4i-a10-tcon
- allwinner,sun8i-a83t-tcon-lcd
+ - allwinner,sun20i-d1-tcon-lcd
then:
required:
- "#clock-cells"
- clock-output-names
- if:
properties:
compatible:
contains:
enum:
- allwinner,sun6i-a31-tcon
- allwinner,sun6i-a31s-tcon
- allwinner,sun8i-a23-tcon
- allwinner,sun8i-a33-tcon
- allwinner,sun8i-a83t-tcon-lcd
+ - allwinner,sun20i-d1-tcon-lcd
then:
properties:
resets:
minItems: 2
reset-names:
items:
- const: lcd
- const: lvds
- if:
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals
2022-08-12 7:37 [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals Samuel Holland
@ 2022-08-12 7:43 ` Krzysztof Kozlowski
2022-08-15 7:47 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-12 7:43 UTC (permalink / raw)
To: Samuel Holland, Chen-Yu Tsai, Jernej Skrabec, Maxime Ripard
Cc: devicetree, David Airlie, linux-kernel, dri-devel, Rob Herring,
Krzysztof Kozlowski, linux-sunxi, linux-arm-kernel
On 12/08/2022 10:37, Samuel Holland wrote:
> When adding the D1 TCON bindings, I missed the conditional blocks that
> restrict the binding for TCON LCD vs TCON TV hardware. Add the D1 TCON
> variants to the appropriate blocks for DE2 TCON LCDs and TCON TVs.
>
> Fixes: ae5a5d26c15c ("dt-bindings: display: Add D1 display engine compatibles")
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals
2022-08-12 7:37 [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals Samuel Holland
2022-08-12 7:43 ` Krzysztof Kozlowski
@ 2022-08-15 7:47 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2022-08-15 7:47 UTC (permalink / raw)
To: jernej.skrabec, wens, samuel, mripard
Cc: devicetree, krzysztof.kozlowski+dt, airlied, linux-kernel,
dri-devel, robh+dt, Maxime Ripard, linux-sunxi, linux-arm-kernel
On Fri, 12 Aug 2022 02:37:02 -0500, Samuel Holland wrote:
> When adding the D1 TCON bindings, I missed the conditional blocks that
> restrict the binding for TCON LCD vs TCON TV hardware. Add the D1 TCON
> variants to the appropriate blocks for DE2 TCON LCDs and TCON TVs.
>
>
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-24 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 7:37 [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals Samuel Holland
2022-08-12 7:43 ` Krzysztof Kozlowski
2022-08-15 7:47 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).