dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 00/18] mdss-dsi-ctrl binding and dts fixes
@ 2022-11-25 12:36 Bryan O'Donoghue
  2022-11-25 12:36 ` [PATCH v4 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
                   ` (17 more replies)
  0 siblings, 18 replies; 38+ messages in thread
From: Bryan O'Donoghue @ 2022-11-25 12:36 UTC (permalink / raw)
  To: linux-arm-msm, freedreno, devicetree
  Cc: dri-devel, krzysztof.kozlowski+dt, sean, andersson,
	konrad.dybcio, quic_abhinavk, david, dianders, robh+dt, agross,
	dmitry.baryshkov, bryan.odonoghue, swboyd, linux-kernel

V4:
- Moves the update of the example from patch #5 to patch #4

V3:
- Moves declaration of mdss-dsi-ctrl into compat string declaration
  patch - Krzysztof, Dmitry
- Renames qcm-2290 compat string to agreed compat "qcom,socname-dsi-ctrl"
  Dmirty, Krzysztof
- Adds empty line after if clause in yaml control flow section - Dmirty
- Adds Rb/Ack - Krzysztof, Dmitry, Doug, David
- vdd*
  Looking into this some more, I don't believe vdd, vdda, vddio ought to be
  required properties. Its up to the PCB manufacturer and the panel in-use
  how that panel is powered. Powering the panel is not something that
  even necessarily needs to be done from the dsi-ctrl driver.
  Originally marking vdd* as required in the .txt was an error, its not a
  SoC level dtsi requirement.
- clock-names
  Rather than replicate the clock-name in each if block I listed them with
  a specific description from a similar reference in usb/qcom,dwc3.yaml.
 
https://lore.kernel.org/linux-arm-msm/eb80681f-2e0b-605f-0444-ec65562f74b8@linaro.org/

V2:
https://www.spinics.net/lists/linux-arm-msm/msg116326.html

- Moves the DSI PHY changes to a different later series.
  There are enough dsi-controller-main changes to justify its own
  standalone series.

- The original phy-name binding change given discussion with Rob and
  Krzysztof became its own standalone series that has since been merged.
  https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403214.html

- Retains the drop of power-domain from yaml as a required property.
  I dug into the available dtsi. The apq8064 doesn't appear to have any
  GDSC which can be attached as a power-domain, which means the
  power-domain requirement is not universal across the various silicon
  versions.

- Adds Dmitry's RB to power-domain drop

- For the clock declarations I've
  * I noticed that the simple change I had worked for msm8939 but
    subsquently broke other dtsi which drove a bigger change to document
    the clocks on a per compatible basis.
  * Added compat strings in yaml.
  * Moved the allOf down later in the file to acomodate the if/then.
  * Number of clocks validated on a per compatible basis
  * The driver code which doesn't care about the number of clocks
    can still operate on the mdss-dsi-ctrl compat but the dts checks will
    validate against the compat string and yaml.

- vdd descriptions
  Took the previous text I missed from the .txt file - Krzysztof, Dmitry
  Adds vdd, vdda and vddio to the required list. This exposes warnings in
  existing dtsi but the previous .txt declared these regulators as
  required. - Krzysztof
 
V1:
This series fixes up a number of dtbs checks which are being flagged adding
in the msm8939 dtsi.


When converting from .txt to .yaml a number of the parameters for the older
msm8916 silicon were not transmitted into the yaml.

Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms of
dtsi triggers a rake of dtbs checks as a result.

https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403211.html

Bryan O'Donoghue (18):
  dt-bindings: msm: dsi-controller-main: Fix operating-points-v2
    constraint
  dt-bindings: msm: dsi-controller-main: Fix power-domain constraint
  dt-bindings: msm: dsi-controller-main: Rename qcom,dsi-ctrl-6g-qcm2290
    to qcom,qcm2290-dsi-ctrl
  dt-bindings: msm: dsi-controller-main: Add compatible strings for
    every current SoC
  dt-bindings: msm: dsi-controller-main: Document clocks on a per
    compatible basis
  dt-bindings: msm: dsi-controller-main: Fix description of core clock
  dt-bindings: msm: dsi-controller-main: Fix clock declarations
  dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in
  ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl
  ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl
  arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl
  arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl
  arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl
  arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl
  arm64: dts: qcom: sdm630: Add compat qcom,sdm630-dsi-ctrl
  arm64: dts: qcom: sdm660: Add compat qcom,sdm660-dsi-ctrl
  arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl
  arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl

 .../display/msm/dsi-controller-main.yaml      | 205 ++++++++++++++++--
 arch/arm/boot/dts/qcom-apq8064.dtsi           |   3 +-
 arch/arm/boot/dts/qcom-msm8974.dtsi           |   3 +-
 arch/arm64/boot/dts/qcom/msm8916.dtsi         |   3 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |   6 +-
 arch/arm64/boot/dts/qcom/sc7180.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sdm630.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sdm660.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |   6 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi          |   6 +-
 11 files changed, 208 insertions(+), 36 deletions(-)

-- 
2.38.1


^ permalink raw reply	[flat|nested] 38+ messages in thread

end of thread, other threads:[~2022-12-05 20:01 UTC | newest]

Thread overview: 38+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 12:36 [PATCH v4 00/18] mdss-dsi-ctrl binding and dts fixes Bryan O'Donoghue
2022-11-25 12:36 ` [PATCH v4 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-11-25 12:36 ` [PATCH v4 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-11-27 12:24   ` Bryan O'Donoghue
2022-11-25 12:36 ` [PATCH v4 03/18] dt-bindings: msm: dsi-controller-main: Rename qcom, dsi-ctrl-6g-qcm2290 to qcom, qcm2290-dsi-ctrl Bryan O'Donoghue
2022-11-26 18:54   ` [PATCH v4 03/18] dt-bindings: msm: dsi-controller-main: Rename qcom,dsi-ctrl-6g-qcm2290 to qcom,qcm2290-dsi-ctrl Dmitry Baryshkov
2022-11-30 21:51     ` Rob Herring
2022-11-25 12:36 ` [PATCH v4 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2022-11-26 18:55   ` Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 05/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2022-12-05 19:59   ` Rob Herring
2022-11-25 12:36 ` [PATCH v4 06/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-11-26 18:56   ` Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 07/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations Bryan O'Donoghue
2022-12-05 20:00   ` Rob Herring
2022-11-25 12:36 ` [PATCH v4 08/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-12-05 20:01   ` Rob Herring
2022-11-25 12:36 ` [PATCH v4 09/18] ARM: dts: qcom: apq8064: add compat qcom, apq8064-dsi-ctrl Bryan O'Donoghue
2022-11-26 18:58   ` [PATCH v4 09/18] ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl Dmitry Baryshkov
2022-11-28  4:21   ` kernel test robot
2022-11-25 12:36 ` [PATCH v4 10/18] ARM: dts: qcom: msm8974: Add compat qcom, msm8974-dsi-ctrl Bryan O'Donoghue
2022-11-26 18:59   ` [PATCH v4 10/18] ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 11/18] arm64: dts: qcom: msm8916: Add compat qcom, msm8916-dsi-ctrl Bryan O'Donoghue
2022-11-26 18:59   ` [PATCH v4 11/18] arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 12/18] arm64: dts: qcom: msm8996: Add compat qcom, msm8996-dsi-ctrl Bryan O'Donoghue
2022-11-26 18:59   ` [PATCH v4 12/18] arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 13/18] arm64: dts: qcom: sc7180: Add compat qcom, sc7180-dsi-ctrl Bryan O'Donoghue
2022-11-26 18:59   ` [PATCH v4 13/18] arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 14/18] arm64: dts: qcom: sc7280: Add compat qcom, sc7280-dsi-ctrl Bryan O'Donoghue
2022-11-26 19:01   ` [PATCH v4 14/18] arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 15/18] arm64: dts: qcom: sdm630: Add compat qcom, sdm630-dsi-ctrl Bryan O'Donoghue
2022-11-26 19:01   ` [PATCH v4 15/18] arm64: dts: qcom: sdm630: Add compat qcom,sdm630-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 16/18] arm64: dts: qcom: sdm660: Add compat qcom, sdm660-dsi-ctrl Bryan O'Donoghue
2022-11-26 19:03   ` [PATCH v4 16/18] arm64: dts: qcom: sdm660: Add compat qcom,sdm660-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 17/18] arm64: dts: qcom: sdm845: Add compat qcom, sdm845-dsi-ctrl Bryan O'Donoghue
2022-11-26 19:04   ` [PATCH v4 17/18] arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl Dmitry Baryshkov
2022-11-25 12:36 ` [PATCH v4 18/18] arm64: dts: qcom: sm8250: Add compat qcom, sm8250-dsi-ctrl Bryan O'Donoghue
2022-11-26 19:04   ` [PATCH v4 18/18] arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).