* [PATCH v2] dt-bindings: samsung,mipi-dsim: Use port-base reference
@ 2023-05-31 22:44 Fabio Estevam
2023-06-01 7:35 ` Krzysztof Kozlowski
2023-06-01 7:45 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-05-31 22:44 UTC (permalink / raw)
To: neil.armstrong
Cc: marex, devicetree, conor+dt, Fabio Estevam, dri-devel, robh+dt,
krzysztof.kozlowski+dt
From: Fabio Estevam <festevam@denx.de>
Use port-base reference for port@1.
This fixes the following schema warning:
imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
Fixes: 1f0d40d88f7a ("dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Only changed port@1.
- Used Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml as reference. (Thanks Marek for the suggestion!)
To reproduce the original problem against linux-next 20230531:
- Enable the mipi_dsi node on imx8mp-dhcom-som.dtsi
&mipi_dsi {
samsung,burst-clock-frequency = <160000000>;
samsung,esc-clock-frequency = <10000000>;
+ status = "okay";
ports {
port@1 {
$ make CHECK_DTBS=y DT_SCHEMA_FILES=samsung,mipi-dsim.yaml freescale/imx8mp-dhcom-pdk3.dtb
UPD include/config/kernel.release
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTC_CHK arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dtb
arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
.../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
index 06b6c44d4641..4ed7a799ba26 100644
--- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
@@ -103,7 +103,8 @@ properties:
specified.
port@1:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description:
DSI output port node to the panel or the next bridge
in the chain.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: samsung,mipi-dsim: Use port-base reference
2023-05-31 22:44 [PATCH v2] dt-bindings: samsung,mipi-dsim: Use port-base reference Fabio Estevam
@ 2023-06-01 7:35 ` Krzysztof Kozlowski
2023-06-01 7:45 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-01 7:35 UTC (permalink / raw)
To: Fabio Estevam, neil.armstrong
Cc: marex, devicetree, conor+dt, Fabio Estevam, dri-devel, robh+dt,
krzysztof.kozlowski+dt
On 01/06/2023 00:44, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Use port-base reference for port@1.
>
> This fixes the following schema warning:
>
> imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
> From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>
> Fixes: 1f0d40d88f7a ("dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml")
>
No line breaks between tags (in general, no need to resend)
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: samsung,mipi-dsim: Use port-base reference
2023-05-31 22:44 [PATCH v2] dt-bindings: samsung,mipi-dsim: Use port-base reference Fabio Estevam
2023-06-01 7:35 ` Krzysztof Kozlowski
@ 2023-06-01 7:45 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-06-01 7:45 UTC (permalink / raw)
To: Fabio Estevam
Cc: marex, devicetree, conor+dt, Fabio Estevam, dri-devel, robh+dt,
krzysztof.kozlowski+dt
Hi,
On Wed, 31 May 2023 19:44:07 -0300, Fabio Estevam wrote:
> Use port-base reference for port@1.
>
> This fixes the following schema warning:
>
> imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
> From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] dt-bindings: samsung,mipi-dsim: Use port-base reference
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=54df4868fb728bebbb0fb7c3f187eba383e922b5
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-01 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-31 22:44 [PATCH v2] dt-bindings: samsung,mipi-dsim: Use port-base reference Fabio Estevam
2023-06-01 7:35 ` Krzysztof Kozlowski
2023-06-01 7:45 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).