* [PATCH] drm/bridge: anx7625: Use common macros for HDCP capabilities
@ 2023-07-10 9:12 Chen-Yu Tsai
2023-07-17 16:07 ` Robert Foss
0 siblings, 1 reply; 2+ messages in thread
From: Chen-Yu Tsai @ 2023-07-10 9:12 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Xin Ji,
Nícolas F. R. A. Prado, AngeloGioacchino Del Regno
Cc: linux-kernel, dri-devel, Chen-Yu Tsai
The DRM DP code has macros for the DP HDCP capabilities. Use them in the
anx7625 driver instead of raw numbers.
Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
Suggested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 9db3784cb554..866d018f4bb1 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -872,11 +872,11 @@ static int anx7625_hdcp_enable(struct anx7625_data *ctx)
}
/* Read downstream capability */
- ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_READ, 0x68028, 1, &bcap);
+ ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_READ, DP_AUX_HDCP_BCAPS, 1, &bcap);
if (ret < 0)
return ret;
- if (!(bcap & 0x01)) {
+ if (!(bcap & DP_BCAPS_HDCP_CAPABLE)) {
pr_warn("downstream not support HDCP 1.4, cap(%x).\n", bcap);
return 0;
}
--
2.41.0.255.g8b1d071c50-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Use common macros for HDCP capabilities
2023-07-10 9:12 [PATCH] drm/bridge: anx7625: Use common macros for HDCP capabilities Chen-Yu Tsai
@ 2023-07-17 16:07 ` Robert Foss
0 siblings, 0 replies; 2+ messages in thread
From: Robert Foss @ 2023-07-17 16:07 UTC (permalink / raw)
To: Laurent Pinchart, Jernej Skrabec, Nícolas F . R . A . Prado,
Neil Armstrong, AngeloGioacchino Del Regno, Chen-Yu Tsai, Xin Ji,
Jonas Karlman, Andrzej Hajda
Cc: dri-devel, Robert Foss, linux-kernel
On Mon, 10 Jul 2023 17:12:01 +0800, Chen-Yu Tsai wrote:
> The DRM DP code has macros for the DP HDCP capabilities. Use them in the
> anx7625 driver instead of raw numbers.
>
>
Applied, thanks!
[1/1] drm/bridge: anx7625: Use common macros for HDCP capabilities
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=41639b3a8b0f
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-17 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-10 9:12 [PATCH] drm/bridge: anx7625: Use common macros for HDCP capabilities Chen-Yu Tsai
2023-07-17 16:07 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).