* [PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init
2024-03-20 13:12 [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags Heiko Stuebner
@ 2024-03-20 13:12 ` Heiko Stuebner
2024-03-21 14:44 ` Quentin Schulz
2024-03-20 20:38 ` [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags Jessica Zhang
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2024-03-20 13:12 UTC (permalink / raw)
To: neil.armstrong, quic_jesszhan, sam
Cc: maarten.lankhorst, mripard, tzimmermann, quentin.schulz,
klaus.goger, heiko, dri-devel, linux-kernel, Heiko Stuebner
From: Heiko Stuebner <heiko.stuebner@cherry.de>
The init sequence specifies the 0x11 and 0x29 dsi commands, which are
the exit-sleep and display-on commands.
In the actual prepare step the driver already uses the appropriate
function calls for those, so drop the duplicates.
Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant")
Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
---
drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
index a50f5330a661..8e0f5c3e3b98 100644
--- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
+++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
@@ -295,8 +295,6 @@ static int ltk050h3148w_init_sequence(struct ltk050h3146w *ctx)
mipi_dsi_dcs_write_seq(dsi, 0xbd, 0x00);
mipi_dsi_dcs_write_seq(dsi, 0xc6, 0xef);
mipi_dsi_dcs_write_seq(dsi, 0xd4, 0x02);
- mipi_dsi_dcs_write_seq(dsi, 0x11);
- mipi_dsi_dcs_write_seq(dsi, 0x29);
ret = mipi_dsi_dcs_set_tear_on(dsi, 1);
if (ret < 0) {
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init
2024-03-20 13:12 ` [PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init Heiko Stuebner
@ 2024-03-21 14:44 ` Quentin Schulz
0 siblings, 0 replies; 6+ messages in thread
From: Quentin Schulz @ 2024-03-21 14:44 UTC (permalink / raw)
To: Heiko Stuebner, neil.armstrong, quic_jesszhan, sam
Cc: maarten.lankhorst, mripard, tzimmermann, klaus.goger, dri-devel,
linux-kernel, Heiko Stuebner
Hi Heiko,
On 3/20/24 14:12, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> The init sequence specifies the 0x11 and 0x29 dsi commands, which are
> the exit-sleep and display-on commands.
>
> In the actual prepare step the driver already uses the appropriate
> function calls for those, so drop the duplicates.
>
> Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags
2024-03-20 13:12 [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags Heiko Stuebner
2024-03-20 13:12 ` [PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init Heiko Stuebner
@ 2024-03-20 20:38 ` Jessica Zhang
2024-03-21 14:41 ` Quentin Schulz
2024-03-26 9:40 ` Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Jessica Zhang @ 2024-03-20 20:38 UTC (permalink / raw)
To: Heiko Stuebner, neil.armstrong, sam
Cc: maarten.lankhorst, mripard, tzimmermann, quentin.schulz,
klaus.goger, dri-devel, linux-kernel, Heiko Stuebner
On 3/20/2024 6:12 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> Similar to other variants, the LTK050H3148W wants to run in video mode
> when displaying data. So far only the Synopsis DSI driver was using this
> panel and it is always switching to video mode, independent of this flag
> being set.
>
> Other DSI drivers might handle this differently, so add the flag.
>
> Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Hi Heiko,
Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
> ---
> drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> index 30919c872ac8..a50f5330a661 100644
> --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> @@ -326,7 +326,8 @@ static const struct drm_display_mode ltk050h3148w_mode = {
> static const struct ltk050h3146w_desc ltk050h3148w_data = {
> .mode = <k050h3148w_mode,
> .init = ltk050h3148w_init_sequence,
> - .mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE | MIPI_DSI_MODE_VIDEO_BURST,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> + MIPI_DSI_MODE_VIDEO_BURST,
> };
>
> static int ltk050h3146w_init_sequence(struct ltk050h3146w *ctx)
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags
2024-03-20 13:12 [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags Heiko Stuebner
2024-03-20 13:12 ` [PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init Heiko Stuebner
2024-03-20 20:38 ` [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags Jessica Zhang
@ 2024-03-21 14:41 ` Quentin Schulz
2024-03-26 9:40 ` Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Quentin Schulz @ 2024-03-21 14:41 UTC (permalink / raw)
To: Heiko Stuebner, neil.armstrong, quic_jesszhan, sam
Cc: maarten.lankhorst, mripard, tzimmermann, klaus.goger, dri-devel,
linux-kernel, Heiko Stuebner
Hi Heiko,
On 3/20/24 14:12, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> Similar to other variants, the LTK050H3148W wants to run in video mode
> when displaying data. So far only the Synopsis DSI driver was using this
> panel and it is always switching to video mode, independent of this flag
> being set.
>
> Other DSI drivers might handle this differently, so add the flag.
>
> Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags
2024-03-20 13:12 [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags Heiko Stuebner
` (2 preceding siblings ...)
2024-03-21 14:41 ` Quentin Schulz
@ 2024-03-26 9:40 ` Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2024-03-26 9:40 UTC (permalink / raw)
To: Heiko Stuebner, quic_jesszhan, neil.armstrong, sam
Cc: tzimmermann, klaus.goger, dri-devel, Heiko Stuebner,
linux-kernel, maarten.lankhorst, mripard, quentin.schulz
On Wed, 20 Mar 2024 14:12:31 +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> Similar to other variants, the LTK050H3148W wants to run in video mode
> when displaying data. So far only the Synopsis DSI driver was using this
> panel and it is always switching to video mode, independent of this flag
> being set.
>
> [...]
Applied, thanks!
[1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags
commit: 80cc8c0d09e6bab3bd016ddaccd0570cadbe1891
[2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init
commit: 55679cc22e60e8ec23b2340248389022798416cd
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread