* [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth'
@ 2019-03-23 2:46 YueHaibing
2019-03-25 17:26 ` Deepak Singh Rawat
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2019-03-23 2:46 UTC (permalink / raw)
To: VMware Graphics, Thomas Hellstrom, David Airlie, Daniel Vetter
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning:
variable 'fb_offset' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:19: warning:
variable 'fb_depth' set but not used [-Wunused-but-set-variable]
They're not used any more, so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
index 2a9112515f46..86efb91f5034 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
@@ -642,12 +642,11 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
struct vmw_fb_par *par;
struct fb_info *info;
unsigned fb_width, fb_height;
- unsigned fb_bpp, fb_depth, fb_offset, fb_pitch, fb_size;
+ unsigned fb_bpp, fb_pitch, fb_size;
struct drm_display_mode *init_mode;
int ret;
fb_bpp = 32;
- fb_depth = 24;
/* XXX As shouldn't these be as well. */
fb_width = min(vmw_priv->fb_max_width, (unsigned)2048);
@@ -655,7 +654,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
fb_pitch = fb_width * fb_bpp / 8;
fb_size = fb_pitch * fb_height;
- fb_offset = vmw_read(vmw_priv, SVGA_REG_FB_OFFSET);
info = framebuffer_alloc(sizeof(*par), device);
if (!info)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth'
2019-03-23 2:46 [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth' YueHaibing
@ 2019-03-25 17:26 ` Deepak Singh Rawat
2019-03-26 6:54 ` Mukesh Ojha
2019-03-27 13:59 ` Mukesh Ojha
2 siblings, 0 replies; 4+ messages in thread
From: Deepak Singh Rawat @ 2019-03-25 17:26 UTC (permalink / raw)
To: YueHaibing, Linux-graphics-maintainer, Thomas Hellstrom,
David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel, kernel-janitors
Thanks for doing this.
Reviewed-by: Deepak Rawat <drawat@vmware.com>
On Sat, 2019-03-23 at 02:46 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning:
> variable 'fb_offset' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:19: warning:
> variable 'fb_depth' set but not used [-Wunused-but-set-variable]
>
> They're not used any more, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> index 2a9112515f46..86efb91f5034 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> @@ -642,12 +642,11 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
> struct vmw_fb_par *par;
> struct fb_info *info;
> unsigned fb_width, fb_height;
> - unsigned fb_bpp, fb_depth, fb_offset, fb_pitch, fb_size;
> + unsigned fb_bpp, fb_pitch, fb_size;
> struct drm_display_mode *init_mode;
> int ret;
>
> fb_bpp = 32;
> - fb_depth = 24;
>
> /* XXX As shouldn't these be as well. */
> fb_width = min(vmw_priv->fb_max_width, (unsigned)2048);
> @@ -655,7 +654,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
>
> fb_pitch = fb_width * fb_bpp / 8;
> fb_size = fb_pitch * fb_height;
> - fb_offset = vmw_read(vmw_priv, SVGA_REG_FB_OFFSET);
>
> info = framebuffer_alloc(sizeof(*par), device);
> if (!info)
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth'
2019-03-23 2:46 [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth' YueHaibing
2019-03-25 17:26 ` Deepak Singh Rawat
@ 2019-03-26 6:54 ` Mukesh Ojha
2019-03-27 13:59 ` Mukesh Ojha
2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-03-26 6:54 UTC (permalink / raw)
To: YueHaibing, VMware Graphics, Thomas Hellstrom, David Airlie,
Daniel Vetter
Cc: kernel-janitors, linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]
On 3/23/2019 8:16 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning:
> variable 'fb_offset' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:19: warning:
> variable 'fb_depth' set but not used [-Wunused-but-set-variable]
>
> They're not used any more, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org
<mailto:mojha@codeaurora.org>>
Thanks.
Mukesh
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> index 2a9112515f46..86efb91f5034 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> @@ -642,12 +642,11 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
> struct vmw_fb_par *par;
> struct fb_info *info;
> unsigned fb_width, fb_height;
> - unsigned fb_bpp, fb_depth, fb_offset, fb_pitch, fb_size;
> + unsigned fb_bpp, fb_pitch, fb_size;
> struct drm_display_mode *init_mode;
> int ret;
>
> fb_bpp = 32;
> - fb_depth = 24;
>
> /* XXX As shouldn't these be as well. */
> fb_width = min(vmw_priv->fb_max_width, (unsigned)2048);
> @@ -655,7 +654,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
>
> fb_pitch = fb_width * fb_bpp / 8;
> fb_size = fb_pitch * fb_height;
> - fb_offset = vmw_read(vmw_priv, SVGA_REG_FB_OFFSET);
>
> info = framebuffer_alloc(sizeof(*par), device);
> if (!info)
>
>
>
[-- Attachment #1.2: Type: text/html, Size: 2350 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth'
2019-03-23 2:46 [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth' YueHaibing
2019-03-25 17:26 ` Deepak Singh Rawat
2019-03-26 6:54 ` Mukesh Ojha
@ 2019-03-27 13:59 ` Mukesh Ojha
2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-03-27 13:59 UTC (permalink / raw)
To: YueHaibing, VMware Graphics, Thomas Hellstrom, David Airlie,
Daniel Vetter
Cc: dri-devel, linux-kernel, kernel-janitors
On 3/23/2019 8:16 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning:
> variable 'fb_offset' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:19: warning:
> variable 'fb_depth' set but not used [-Wunused-but-set-variable]
>
> They're not used any more, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> index 2a9112515f46..86efb91f5034 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> @@ -642,12 +642,11 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
> struct vmw_fb_par *par;
> struct fb_info *info;
> unsigned fb_width, fb_height;
> - unsigned fb_bpp, fb_depth, fb_offset, fb_pitch, fb_size;
> + unsigned fb_bpp, fb_pitch, fb_size;
> struct drm_display_mode *init_mode;
> int ret;
>
> fb_bpp = 32;
> - fb_depth = 24;
>
> /* XXX As shouldn't these be as well. */
> fb_width = min(vmw_priv->fb_max_width, (unsigned)2048);
> @@ -655,7 +654,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
>
> fb_pitch = fb_width * fb_bpp / 8;
> fb_size = fb_pitch * fb_height;
> - fb_offset = vmw_read(vmw_priv, SVGA_REG_FB_OFFSET);
>
> info = framebuffer_alloc(sizeof(*par), device);
> if (!info)
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-27 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-23 2:46 [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth' YueHaibing
2019-03-25 17:26 ` Deepak Singh Rawat
2019-03-26 6:54 ` Mukesh Ojha
2019-03-27 13:59 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).