Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Simon Ser <contact@emersion.fr>,
	Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Cc: Shashank Sharma <shashank.sharma@amd.com>,
	Amaranath Somalapuram <amaranath.somalapuram@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Alexandar Deucher <alexander.deucher@amd.com>,
	Shashank Sharma <contactshashanksharma@gmail.com>,
	Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event
Date: Wed, 9 Mar 2022 11:24:02 +0100	[thread overview]
Message-ID: <1e2ad919-e336-cf8f-c675-0ddd62796a0f@gmail.com> (raw)
In-Reply-To: <DQGKSkEjxg-p9oBYX3hMa6fmY3Am2mAT4KBSQL_qsLGK0m85wehKp54s1IbobLSc5-FGbY67HrlWfQYO876bGgeObzY5eJF5UXJ1BktPilA=@emersion.fr>

Am 09.03.22 um 11:10 schrieb Simon Ser:
> On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> wrote:
>
>> Would it be possible to include the app parameters as well?
> Can all processes read sysfs events?

No, but application parameters are usually not secret.

> There might be security implications here. The app parameters might
> contain sensitive information, like passwords or tokens.

It's a well known security vulnerably to provide password etc.. as 
application parameter since everybody can read them through procfs.

> Can't the uevent receiver query the kernel to get that info from the
> PID?

I'm leaning also towards just providing the PID and not the application 
name. The information should be as short as possible.

Regards,
Christian.