From: Daniel Vetter <daniel@ffwll.ch>
To: Keith Packard <keithp@keithp.com>
Cc: "Airlie, Dave" <airlied@linux.ie>,
Intel drivers <Intel-gfx@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PULL] drm-intel-next
Date: Thu, 5 Jan 2012 16:24:08 +0100 [thread overview]
Message-ID: <20120105152408.GD3831@phenom.ffwll.local> (raw)
In-Reply-To: <86y5tmkeia.fsf@sumi.keithp.com>
On Wed, Jan 04, 2012 at 07:35:41PM -0800, Keith Packard wrote:
>
> Here are the rest of the 3.3 pending changes.
>
> This has a bunch of small bug fixes and overlay plane support for i915.
>
> The following changes since commit 7a7e8734ac3235efafd34819b27fbdf5417e6d60:
>
> Merge branch 'drm-radeon-testing' of ../drm-radeon-next into drm-core-next (2012-01-03 09:45:12 +0000)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/keithp/linux drm-intel-next
I'm not happy with Eric's missed IRQ workaround because
- it's incomplete, the BSD ring is similarly affected by these issues like
the blitter ring, but not handled by his patches.
- it does a busy-loop wait until the gpu signals completion - in normal
useage this can easily be a few msecs, especially since now semaphores
are enabled by defailt on Ivybridge. With offscreen benchmarking it can
easily reach seconds. This is imo unacceptable.
Furthermore
- Chris Wilson proposed an alternative approach quite a bit before these
patches have been created that combines the irq signalling path with a
short timer as a backup. This works really well because we only rarely
miss irqs. See
Message-Id: <1323978198-3501-1-git-send-email-chris@chris-wilson.co.uk>
- Meanwhile I've discovered a magic set of tricks that seem to completely
solve missed irq issues on both ivb and snb. This would render all this
ducttape irrelevant.
Imo the minimal right thing to do is to revert the patch "drm/i915: Make
the fallback IRQ wait not sleep". This will regress piglit throughput (and
anything else stupid enough to crazily ping-pong between the gpu and cpu)
quite a bit, but honestly that's not something our userbase cares about.
I'd also like to express my frustration with the general -next process for
drm/i915:
- This drm-intel-next tree is less than 24h ours old (if you look at when
it showed up at an official place where both our QA and the community
can pick it up and test it). I fear we'll ship yet another disaster like
the stack eating bug the vt-d/ilk w/a patch caused with an unbounded
recursion. Our QA actually caught it in testing, but there was simply
not enough time to fix things up before the buggy code landed in -linus.
- Because the drm-intel-next merge cycle started so late there has simply
not been enough time to include quite a few bugfixes for serious issues
like 20s delays in intial modeset, userspace-triggerable kernel OOPSes
and deadlocks and reproducible hard hw hangs. For most of these there
are testcases in intel-gpu-tools, and these issues span the entire set
of hw generations drm/i915 currently supports. But this late it's imo
no longer advisible to merge them, so we'll ship 3.3 with a bunch of
known (and sometimes longstanding) serious issues that have fixes.
Yours, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-05 15:24 UTC|newest]
Thread overview: 267+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 3:35 [PULL] drm-intel-next Keith Packard
2012-01-05 15:24 ` Daniel Vetter [this message]
2012-01-05 17:58 ` [Intel-gfx] " Ben Widawsky
2012-01-05 18:02 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2024-04-24 16:32 Rodrigo Vivi
2024-04-17 13:38 Rodrigo Vivi
2024-04-17 14:05 ` Maxime Ripard
2024-02-27 16:16 Jani Nikula
2024-02-07 11:35 Jani Nikula
2024-02-14 11:01 ` Jani Nikula
2023-12-18 16:54 Rodrigo Vivi
2023-12-07 18:59 Rodrigo Vivi
2023-11-23 19:03 Jani Nikula
2023-11-23 19:39 ` Daniel Vetter
2023-10-19 16:18 Rodrigo Vivi
2023-10-12 13:42 Jani Nikula
2023-09-29 10:49 Jani Nikula
2023-08-10 19:53 Rodrigo Vivi
2023-08-03 18:56 Rodrigo Vivi
2023-06-05 14:20 Jani Nikula
2023-04-06 14:03 Rodrigo Vivi
2023-04-06 16:24 ` Daniel Vetter
2023-03-23 20:43 Rodrigo Vivi
2023-03-24 20:13 ` Daniel Vetter
2023-03-07 22:00 Rodrigo Vivi
2023-01-27 11:11 Jani Nikula
2023-01-12 12:06 Jani Nikula
2022-11-18 21:40 Rodrigo Vivi
2022-10-28 18:22 Rodrigo Vivi
2022-09-16 12:09 Jani Nikula
2022-08-29 13:22 Jani Nikula
2022-09-15 11:55 ` Jani Nikula
2022-07-07 3:04 Rodrigo Vivi
2022-06-22 19:53 Rodrigo Vivi
2022-05-06 10:47 Jani Nikula
2022-04-13 15:51 Jani Nikula
2022-02-23 23:29 Rodrigo Vivi
2022-02-08 14:58 Rodrigo Vivi
2021-12-14 15:37 Jani Nikula
2021-11-30 15:04 Jani Nikula
2021-10-15 18:45 Rodrigo Vivi
2021-10-04 19:01 Rodrigo Vivi
2021-08-10 13:51 Jani Nikula
2021-06-09 21:30 Rodrigo Vivi
2021-05-19 19:10 Rodrigo Vivi
2021-04-01 9:06 Jani Nikula
2021-03-16 16:24 Jani Nikula
2021-01-29 22:53 Rodrigo Vivi
2021-01-27 14:08 Rodrigo Vivi
2021-01-27 21:51 ` Ville Syrjälä
2021-01-12 17:51 Rodrigo Vivi
2021-01-04 21:10 Rodrigo Vivi
2021-01-07 12:02 ` Daniel Vetter
2020-09-18 17:30 Rodrigo Vivi
2020-08-26 23:27 Rodrigo Vivi
2020-07-15 13:19 Jani Nikula
2020-07-15 13:33 ` Jani Nikula
2020-07-15 14:05 ` Daniel Vetter
2020-07-02 18:29 Jani Nikula
2020-05-15 16:07 Joonas Lahtinen
2020-04-30 12:49 Joonas Lahtinen
2020-05-13 17:10 ` Joonas Lahtinen
2020-05-14 1:28 ` Dave Airlie
2020-05-14 14:55 ` Joonas Lahtinen
2020-04-17 11:15 Joonas Lahtinen
2020-02-25 18:58 Rodrigo Vivi
2020-01-14 11:43 Jani Nikula
2020-01-14 12:05 ` Chris Wilson
2020-01-14 12:15 ` Jani Nikula
2019-12-23 17:53 Jani Nikula
2019-11-01 10:47 Joonas Lahtinen
2019-11-01 10:47 ` Joonas Lahtinen
2019-10-21 18:03 Joonas Lahtinen
2019-10-07 13:48 Joonas Lahtinen
2019-08-23 5:14 Rodrigo Vivi
2019-08-22 19:29 Rodrigo Vivi
2019-08-23 1:50 ` Dave Airlie
2019-08-01 20:13 Rodrigo Vivi
2019-06-19 12:40 Jani Nikula
2019-05-24 17:38 Jani Nikula
2019-04-18 8:04 Joonas Lahtinen
2019-04-18 11:40 ` Ville Syrjälä
2019-03-28 15:15 Joonas Lahtinen
2019-03-25 12:49 Joonas Lahtinen
2019-03-28 2:09 ` Dave Airlie
2019-03-28 15:29 ` Joonas Lahtinen
2019-02-08 16:50 Rodrigo Vivi
2019-02-02 8:29 Rodrigo Vivi
2019-02-04 5:02 ` Dave Airlie
2019-02-04 8:47 ` Joonas Lahtinen
2019-02-04 9:30 ` Daniel Vetter
2019-02-05 8:03 ` Jani Nikula
2019-01-28 18:10 Rodrigo Vivi
2019-01-14 18:38 Rodrigo Vivi
2018-12-04 17:58 Jani Nikula
2018-11-23 9:40 Jani Nikula
2018-09-27 9:59 Joonas Lahtinen
2018-09-07 10:54 Joonas Lahtinen
2018-07-19 17:12 Rodrigo Vivi
2018-07-13 22:22 Rodrigo Vivi
2018-06-25 16:56 Rodrigo Vivi
2018-06-11 16:27 Rodrigo Vivi
2018-06-12 4:04 ` Dave Airlie
2018-06-12 7:59 ` Jani Nikula
2018-06-18 7:12 ` Daniel Vetter
2018-06-18 19:57 ` Rodrigo Vivi
2018-06-18 7:14 ` Daniel Vetter
2018-05-15 9:55 Jani Nikula
2018-05-15 10:01 ` Srinivas, Vidya
2018-05-15 13:16 ` Wang, Zhi A
2018-05-15 14:58 ` Daniel Vetter
2018-05-15 15:53 ` Jani Nikula
2018-05-15 16:03 ` Daniel Vetter
2018-05-02 7:03 Jani Nikula
2018-05-04 0:19 ` Dave Airlie
2018-05-04 0:29 ` Dave Airlie
2018-05-04 0:34 ` Dave Airlie
2018-03-12 15:06 Joonas Lahtinen
2018-02-28 9:52 Joonas Lahtinen
2018-02-14 9:22 Joonas Lahtinen
2017-12-22 22:58 Rodrigo Vivi
2017-12-18 19:50 Rodrigo Vivi
2017-12-07 21:43 Rodrigo Vivi
2017-12-01 0:36 Rodrigo Vivi
2017-10-27 7:55 Jani Nikula
2017-10-19 14:16 Jani Nikula
2017-10-11 17:59 Jani Nikula
2017-10-12 15:23 ` Jani Nikula
2017-10-13 6:26 ` Dave Airlie
2017-10-13 7:45 ` Jani Nikula
2017-09-21 8:57 Jani Nikula
2017-08-21 15:21 Daniel Vetter
2017-07-18 8:30 Daniel Vetter
2017-06-20 12:44 Daniel Vetter
2017-05-29 21:43 Daniel Vetter
2017-05-16 9:05 Daniel Vetter
2017-04-07 16:58 Daniel Vetter
2017-03-20 15:33 Daniel Vetter
2017-03-07 0:10 Daniel Vetter
2017-01-26 10:11 Daniel Vetter
2017-01-26 9:37 Daniel Vetter
2017-01-09 19:13 Daniel Vetter
2016-12-30 10:37 Daniel Vetter
2016-11-29 10:16 Daniel Vetter
2016-11-10 14:57 Daniel Vetter
2016-10-24 7:25 Daniel Vetter
2016-10-24 8:05 ` Daniel Vetter
2016-09-19 9:17 Daniel Vetter
2016-08-24 7:58 Daniel Vetter
2016-08-12 17:21 Daniel Vetter
2016-07-14 8:17 Daniel Vetter
2016-06-22 9:24 Daniel Vetter
2016-06-22 11:16 ` Daniel Vetter
2016-06-07 19:56 Daniel Vetter
2016-06-01 8:28 Daniel Vetter
2016-04-29 7:53 Daniel Vetter
2016-04-21 9:26 Daniel Vetter
2016-04-21 13:32 ` Daniel Vetter
2016-04-01 13:42 Daniel Vetter
2016-03-04 16:50 Daniel Vetter
2016-02-29 8:27 Daniel Vetter
2016-02-08 9:26 Daniel Vetter
2015-12-22 10:37 Daniel Vetter
2015-12-22 14:05 ` Daniel Vetter
2015-12-22 14:31 ` Chris Wilson
2015-12-11 18:31 Daniel Vetter
2015-11-26 8:24 Daniel Vetter
2015-10-19 13:18 Daniel Vetter
2015-10-07 16:18 Daniel Vetter
2015-10-02 8:35 Daniel Vetter
2015-09-22 8:31 Daniel Vetter
2015-08-14 16:19 Daniel Vetter
2015-07-23 7:39 Daniel Vetter
2015-05-28 16:10 Daniel Vetter
2015-05-18 8:31 Daniel Vetter
2015-05-07 7:48 Daniel Vetter
2015-03-31 14:31 Daniel Vetter
2015-03-31 22:22 ` Dave Airlie
2015-03-23 7:37 Daniel Vetter
2015-03-06 17:36 Daniel Vetter
2015-02-27 18:03 Daniel Vetter
2015-02-04 12:08 Daniel Vetter
2015-01-23 15:44 Daniel Vetter
2015-01-07 9:31 Daniel Vetter
2014-12-19 9:44 Daniel Vetter
2014-12-19 15:21 ` Daniel Vetter
2014-12-02 14:29 Daniel Vetter
2014-11-28 13:30 Daniel Vetter
2014-11-28 14:22 ` Daniel Vetter
2014-12-02 1:02 ` Dave Airlie
2014-12-02 7:36 ` Daniel Vetter
2014-11-14 16:31 Daniel Vetter
2014-11-03 14:34 Daniel Vetter
2014-10-21 13:38 Daniel Vetter
2014-10-21 23:09 ` Dave Airlie
2014-10-22 7:05 ` Chris Wilson
2014-10-22 8:06 ` Dave Airlie
2014-10-21 12:27 Daniel Vetter
2014-10-21 12:43 ` Daniel Vetter
2014-09-15 14:05 Daniel Vetter
2014-09-01 8:49 Daniel Vetter
2014-08-04 7:10 Daniel Vetter
2014-08-04 7:52 ` Dave Airlie
2014-07-18 16:36 Daniel Vetter
2014-07-01 8:24 Jani Nikula
2014-07-07 8:10 ` Daniel Vetter
2014-06-02 6:05 Daniel Vetter
2014-05-16 16:43 Daniel Vetter
2014-04-28 13:26 Daniel Vetter
2014-04-30 23:26 ` Dave Airlie
2014-05-05 6:39 ` Daniel Vetter
2014-05-06 13:08 ` [Intel-gfx] " Knut Petersen
2014-05-06 13:30 ` Jani Nikula
2014-05-06 18:59 ` Daniel Vetter
2014-05-06 20:04 ` Knut Petersen
2014-05-06 20:17 ` [Intel-gfx] " Daniel Vetter
2014-05-07 6:38 ` Jani Nikula
2014-03-28 9:05 Daniel Vetter
2014-03-17 10:02 Daniel Vetter
2014-03-03 17:39 Daniel Vetter
2014-02-14 13:30 Daniel Vetter
2014-01-17 16:57 Daniel Vetter
2013-12-20 21:42 Daniel Vetter
2013-12-22 6:04 ` Ben Widawsky
2013-12-11 10:20 Daniel Vetter
2013-10-24 14:56 Daniel Vetter
2013-10-14 6:50 Daniel Vetter
2013-09-27 9:02 Daniel Vetter
2013-09-26 8:48 Daniel Vetter
2013-08-29 23:18 Daniel Vetter
2013-08-20 5:21 Daniel Vetter
2013-08-04 19:35 Daniel Vetter
2013-08-07 0:27 ` Dave Airlie
2013-08-07 7:51 ` Daniel Vetter
2013-06-08 15:14 Daniel Vetter
2013-04-15 7:56 [pull] drm-intel-next Daniel Vetter
2013-04-15 9:43 ` Daniel Vetter
2013-04-02 9:34 [PULL] drm-intel-next Daniel Vetter
2013-01-29 14:19 Daniel Vetter
2012-11-16 17:17 [pull] drm-intel-next Daniel Vetter
2012-11-16 17:47 ` Alex Deucher
2012-11-16 17:49 ` Daniel Vetter
2012-09-13 14:18 Daniel Vetter
2012-09-17 23:09 ` Daniel Vetter
2013-03-15 2:11 ` Stéphane Marchesin
2013-03-17 19:46 ` Daniel Vetter
2013-03-18 19:35 ` Stéphane Marchesin
2013-03-18 20:59 ` Daniel Vetter
2013-03-18 21:00 ` Daniel Vetter
2012-08-31 9:03 [PULL] drm-intel-next Daniel Vetter
2012-07-13 18:55 [pull] drm-intel-next Daniel Vetter
[not found] <20120621082533.GB4704@phenom.ffwll.local>
2012-06-28 12:05 ` [PULL] drm-intel-next Daniel Vetter
2012-06-28 12:30 ` Daniel Vetter
[not found] <20120506190931.GD4756@phenom.ffwll.local>
2012-05-10 13:55 ` Daniel Vetter
[not found] <20120216172744.GC19158@phenom.ffwll.local>
[not found] ` <D9F66AA509623343B6A9A3D4502D5A520FCCA1B7@SHSMSX102.ccr.corp.intel.com>
2012-02-23 11:00 ` Daniel Vetter
[not found] <D9F66AA509623343B6A9A3D4502D5A520FCC730C@SHSMSX102.ccr.corp.intel.com>
2012-02-14 12:36 ` Daniel Vetter
2011-10-23 7:27 Keith Packard
2011-09-20 3:55 Keith Packard
2011-08-04 3:14 Keith Packard
2011-08-10 16:20 ` Andy Lutomirski
2011-08-10 16:34 ` Keith Packard
2011-07-13 16:39 Keith Packard
2011-07-13 17:22 ` Wolfram Sang
2011-07-13 18:04 ` Keith Packard
2011-07-13 19:41 ` Wolfram Sang
2011-05-15 21:29 Keith Packard
2011-05-17 22:00 ` Keith Packard
2011-05-17 23:39 ` Keith Packard
2011-05-26 4:13 ` Keith Packard
2011-06-03 23:40 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105152408.GD3831@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).