* [PATCH] intel/decode: VERTEX_ELEMENT_STATE, 1 means valid
@ 2012-06-25 3:41 Ben Widawsky
2012-06-27 17:02 ` Eric Anholt
0 siblings, 1 reply; 3+ messages in thread
From: Ben Widawsky @ 2012-06-25 3:41 UTC (permalink / raw)
To: DRI Devel; +Cc: Ben Widawsky
The logic seemed to be inverse to me.
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
intel/intel_decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/intel/intel_decode.c b/intel/intel_decode.c
index c9bfee4..eac48c3 100644
--- a/intel/intel_decode.c
+++ b/intel/intel_decode.c
@@ -3390,7 +3390,7 @@ decode_3d_965(struct drm_intel_decode *ctx)
"src offset 0x%04x bytes\n",
data[i] >> (IS_GEN6(devid) ? 26 : 27),
data[i] & (1 << (IS_GEN6(devid) ? 25 : 26)) ?
- "" : "in", (data[i] >> 16) & 0x1ff,
+ "in" : "", (data[i] >> 16) & 0x1ff,
data[i] & 0x07ff);
i++;
instr_out(ctx, i, "(%s, %s, %s, %s), "
--
1.7.11
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] intel/decode: VERTEX_ELEMENT_STATE, 1 means valid
2012-06-25 3:41 [PATCH] intel/decode: VERTEX_ELEMENT_STATE, 1 means valid Ben Widawsky
@ 2012-06-27 17:02 ` Eric Anholt
2012-06-27 20:53 ` Ben Widawsky
0 siblings, 1 reply; 3+ messages in thread
From: Eric Anholt @ 2012-06-27 17:02 UTC (permalink / raw)
To: DRI Devel; +Cc: Ben Widawsky
[-- Attachment #1.1: Type: text/plain, Size: 176 bytes --]
Ben Widawsky <ben@bwidawsk.net> writes:
> The logic seemed to be inverse to me.
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] intel/decode: VERTEX_ELEMENT_STATE, 1 means valid
2012-06-27 17:02 ` Eric Anholt
@ 2012-06-27 20:53 ` Ben Widawsky
0 siblings, 0 replies; 3+ messages in thread
From: Ben Widawsky @ 2012-06-27 20:53 UTC (permalink / raw)
To: Eric Anholt; +Cc: DRI Devel
On Wed, 27 Jun 2012 10:02:35 -0700
Eric Anholt <eric@anholt.net> wrote:
> Ben Widawsky <ben@bwidawsk.net> writes:
>
> > The logic seemed to be inverse to me.
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
This patch was bonghits :-(
My bad, I've fixed the problem upstream though which turned out to just
be a missing GEN7 thing.
--
Ben Widawsky, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-27 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-25 3:41 [PATCH] intel/decode: VERTEX_ELEMENT_STATE, 1 means valid Ben Widawsky
2012-06-27 17:02 ` Eric Anholt
2012-06-27 20:53 ` Ben Widawsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).