From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>,
jeyu@kernel.org
Subject: Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335
Date: Fri, 14 Jul 2017 14:42:48 -0500 [thread overview]
Message-ID: <20170714194248.6n7rw5ln6luhnz3l@treble> (raw)
In-Reply-To: <1500049981.5248.2.camel@gmx.de>
On Fri, Jul 14, 2017 at 06:33:01PM +0200, Mike Galbraith wrote:
> On Fri, 2017-07-14 at 18:10 +0200, Peter Zijlstra wrote:
> > On Fri, Jul 14, 2017 at 05:58:18PM +0200, Mike Galbraith wrote:
> > > On Fri, 2017-07-14 at 17:50 +0200, Peter Zijlstra wrote:
> >
> > > > Urgh, is for some mysterious reason the __bug_table section of modules
> > > > ending up in RO memory?
> > > >
> > > > I forever get lost in that link magic :/
> > >
> > > +1
> > >
> > > drm.ko
> > > 20 __bug_table 00000630 0000000000000000 0000000000000000 0004bff3 2**0
> > > CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
> > > vmlinux
> > > 15 __bug_table 0000ba84 ffffffff81af26c0 0000000001af26c0 00cf26c0 2**0
> > > CONTENTS, ALLOC, LOAD, READONLY, DATA
> > >
> > > Danged if I know... um um RELOC business mucks things up?
> >
> > Argh, it shouldn't be READONLY for vmlinux either, but apparently that
> > is working for mysterious reasons.
> >
> > Some architectures were in fact complaining that I broke that, and hence
> > patch:
> >
> > b5effd3815cc ("debug: Fix __bug_table[] in arch linker scripts")
> >
> > I think we need professional help with this linking stuff, but who to
> > ask?
>
> Andy Lutomirski?
Does this fix it?
diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index 39e702d..aa6b202 100644
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -35,7 +35,7 @@
#define _BUG_FLAGS(ins, flags) \
do { \
asm volatile("1:\t" ins "\n" \
- ".pushsection __bug_table,\"a\"\n" \
+ ".pushsection __bug_table,\"aw\"\n" \
"2:\t" __BUG_REL(1b) "\t# bug_entry::bug_addr\n" \
"\t" __BUG_REL(%c0) "\t# bug_entry::file\n" \
"\t.word %c1" "\t# bug_entry::line\n" \
@@ -52,7 +52,7 @@ do { \
#define _BUG_FLAGS(ins, flags) \
do { \
asm volatile("1:\t" ins "\n" \
- ".pushsection __bug_table,\"a\"\n" \
+ ".pushsection __bug_table,\"aw\"\n" \
"2:\t" __BUG_REL(1b) "\t# bug_entry::bug_addr\n" \
"\t.word %c0" "\t# bug_entry::flags\n" \
"\t.org 2b+%c1\n" \
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-14 19:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 17:32 [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith
[not found] ` <1499794333.5315.8.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-11 17:51 ` Ilia Mirkin
2017-07-11 18:08 ` Mike Galbraith
[not found] ` <1499796510.5315.27.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-11 18:22 ` Ilia Mirkin
2017-07-11 18:53 ` Mike Galbraith
2017-07-12 7:45 ` Mike Galbraith
2017-07-12 9:55 ` Mike Galbraith
2017-07-12 11:25 ` Mike Galbraith
2017-07-12 11:37 ` Ilia Mirkin
2017-07-12 17:19 ` Mike Galbraith
[not found] ` <1499879972.23742.50.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-12 19:33 ` Tobias Klausmann
2017-07-14 13:36 ` Mike Galbraith
2017-07-14 13:41 ` Mike Galbraith
[not found] ` <1500039693.5763.15.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-14 15:05 ` Tobias Klausmann
[not found] ` <6341f91f-1c56-2188-f55b-2f47d23262fc-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
2017-07-14 15:10 ` Karol Herbst
2017-07-14 15:15 ` [Nouveau] " Mike Galbraith
[not found] ` <1500045346.5763.21.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-14 15:16 ` Ilia Mirkin
2017-07-14 15:19 ` [Nouveau] " Tobias Klausmann
[not found] ` <31d327dd-bc3d-cb80-45a9-6a8eb9eb2a9d-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
2017-07-14 15:20 ` Ilia Mirkin
2017-07-14 15:55 ` [Nouveau] " Peter Zijlstra
2017-07-14 15:11 ` Mike Galbraith
2017-07-14 15:50 ` Peter Zijlstra
2017-07-14 15:58 ` Mike Galbraith
2017-07-14 16:10 ` Peter Zijlstra
2017-07-14 16:33 ` Mike Galbraith
2017-07-14 19:42 ` Josh Poimboeuf [this message]
2017-07-15 2:45 ` Mike Galbraith
2017-07-17 17:20 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714194248.6n7rw5ln6luhnz3l@treble \
--to=jpoimboe@redhat.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=efault@gmx.de \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).