From: Karol Herbst <karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tobias Klausmann
<tobias.johannes.klausmann-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
Cc: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Mike Galbraith <efault-Mmb7MZpHnFY@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335
Date: Fri, 14 Jul 2017 17:10:34 +0200 [thread overview]
Message-ID: <CAEXux-b=u88Bu6JN3xbP+=Fwq2rPRXTXdNWJpBu+pSdsNYwQRQ@mail.gmail.com> (raw)
In-Reply-To: <6341f91f-1c56-2188-f55b-2f47d23262fc-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
Yeah, we shouldn't let the machine die. Are there more WARN_ON_ONCE
usage we could convert to WARN_ONCE?
Reviewed-By: Karol Herbst <karolherbst@gmail.com>
On Fri, Jul 14, 2017 at 5:05 PM, Tobias Klausmann
<tobias.johannes.klausmann@mni.thm.de> wrote:
> On 7/14/17 3:41 PM, Mike Galbraith wrote:
>>
>> On Fri, 2017-07-14 at 15:36 +0200, Mike Galbraith wrote:
>>>
>>> All DRM did was to slip a
>>> WARN_ON_ONCE() that nouveau triggers into a kernel module where such
>>> things no longer warn, they blow the box out of the water.
>>
>> BTW, turn that irksome WARN_ON_ONCE() in drivers/gpu/drm/drm_vblank.c
>> into a WARN_ONCE(), and all is peachy, you get the warning, box lives.
>>
>> ---
>> drivers/gpu/drm/drm_vblank.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> --- a/drivers/gpu/drm/drm_vblank.c
>> +++ b/drivers/gpu/drm/drm_vblank.c
>> @@ -605,7 +605,8 @@ bool drm_calc_vbltimestamp_from_scanoutp
>> */
>> if (mode->crtc_clock == 0) {
>> DRM_DEBUG("crtc %u: Noop due to uninitialized mode.\n",
>> pipe);
>> - WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev));
>> + WARN_ONCE(drm_drv_uses_atomic_modeset(dev), "%s: report
>> me.\n",
>> + dev->driver->name);
>> return false;
>> }
>
>
>
> Hey,
>
> confirmed this helps saving the box, but we still have to find the root
> cause! Backtrace with the above fix applied (and the one which came in with
> the latest drm-fixes merge)!
>
>
> [1] https://hastebin.com/uyoqifijed.http
>
> Thanks,
>
> Tobias
>Reviewed-By: Karol Herbst <karolherbst@gmail.com>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2017-07-14 15:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 17:32 [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith
[not found] ` <1499794333.5315.8.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-11 17:51 ` Ilia Mirkin
2017-07-11 18:08 ` Mike Galbraith
[not found] ` <1499796510.5315.27.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-11 18:22 ` Ilia Mirkin
2017-07-11 18:53 ` Mike Galbraith
2017-07-12 7:45 ` Mike Galbraith
2017-07-12 9:55 ` Mike Galbraith
2017-07-12 11:25 ` Mike Galbraith
2017-07-12 11:37 ` Ilia Mirkin
2017-07-12 17:19 ` Mike Galbraith
[not found] ` <1499879972.23742.50.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-12 19:33 ` Tobias Klausmann
2017-07-14 13:36 ` Mike Galbraith
2017-07-14 13:41 ` Mike Galbraith
[not found] ` <1500039693.5763.15.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-14 15:05 ` Tobias Klausmann
[not found] ` <6341f91f-1c56-2188-f55b-2f47d23262fc-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
2017-07-14 15:10 ` Karol Herbst [this message]
2017-07-14 15:15 ` [Nouveau] " Mike Galbraith
[not found] ` <1500045346.5763.21.camel-Mmb7MZpHnFY@public.gmane.org>
2017-07-14 15:16 ` Ilia Mirkin
2017-07-14 15:19 ` [Nouveau] " Tobias Klausmann
[not found] ` <31d327dd-bc3d-cb80-45a9-6a8eb9eb2a9d-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
2017-07-14 15:20 ` Ilia Mirkin
2017-07-14 15:55 ` [Nouveau] " Peter Zijlstra
2017-07-14 15:11 ` Mike Galbraith
2017-07-14 15:50 ` Peter Zijlstra
2017-07-14 15:58 ` Mike Galbraith
2017-07-14 16:10 ` Peter Zijlstra
2017-07-14 16:33 ` Mike Galbraith
2017-07-14 19:42 ` Josh Poimboeuf
2017-07-15 2:45 ` Mike Galbraith
2017-07-17 17:20 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEXux-b=u88Bu6JN3xbP+=Fwq2rPRXTXdNWJpBu+pSdsNYwQRQ@mail.gmail.com' \
--to=karolherbst-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=efault-Mmb7MZpHnFY@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tobias.johannes.klausmann-AqjdNwhu20eELgA04lAiVw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).