* [PATCH] drm/vgem: add compat_ioctl support
@ 2017-07-15 3:12 Brian Norris
2017-07-17 15:53 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2017-07-15 3:12 UTC (permalink / raw)
To: Sean Paul, David Airlie, Daniel Vetter, Jani Nikula
Cc: linux-kernel, dri-devel, Brian Norris
DRM drivers should supply a compat version if they're going to provide
an ioctl implementation at all. This can confuse 32-bit user space on a
64-bit system.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/gpu/drm/vgem/vgem_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 9fee38a942c4..3835656e2baf 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -220,6 +220,7 @@ static const struct file_operations vgem_driver_fops = {
.poll = drm_poll,
.read = drm_read,
.unlocked_ioctl = drm_ioctl,
+ .compat_ioctl = drm_compat_ioctl,
.release = drm_release,
};
--
2.13.2.932.g7449e964c-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/vgem: add compat_ioctl support
2017-07-15 3:12 [PATCH] drm/vgem: add compat_ioctl support Brian Norris
@ 2017-07-17 15:53 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2017-07-17 15:53 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-kernel, dri-devel, Daniel Vetter
On Fri, Jul 14, 2017 at 08:12:12PM -0700, Brian Norris wrote:
> DRM drivers should supply a compat version if they're going to provide
> an ioctl implementation at all. This can confuse 32-bit user space on a
> 64-bit system.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Thanks, applied.
-Daniel
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index 9fee38a942c4..3835656e2baf 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -220,6 +220,7 @@ static const struct file_operations vgem_driver_fops = {
> .poll = drm_poll,
> .read = drm_read,
> .unlocked_ioctl = drm_ioctl,
> + .compat_ioctl = drm_compat_ioctl,
> .release = drm_release,
> };
>
> --
> 2.13.2.932.g7449e964c-goog
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-17 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-15 3:12 [PATCH] drm/vgem: add compat_ioctl support Brian Norris
2017-07-17 15:53 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).