From: Manasi Navare <manasi.d.navare@intel.com>
To: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Cc: "grundler@chromium.org" <grundler@chromium.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"mka@chromium.org" <mka@chromium.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V
Date: Mon, 17 Jul 2017 14:17:13 -0700 [thread overview]
Message-ID: <20170717211713.GA6173@intel.com> (raw)
In-Reply-To: <1500326360.18069.12.camel@dk-H97M-D3H>
On Mon, Jul 17, 2017 at 08:59:18PM +0000, Pandiyan, Dhinakaran wrote:
>
>
>
> On Mon, 2017-07-17 at 18:55 +0000, Pandiyan, Dhinakaran wrote:
> > Looks like a typo in
> >
> > cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.")
> >
> > but Cc'ing Rodrigo, Clint to make sure this wasn't a workaround.
> >
> > -DK
>
> Checked with Clint, this wasn't a workaround, a typo indeed.
>
>
Yup, Like I mentioned in the previous reply, I am positive that this should
return cnl_ddi_translations_edp_0_85 since I had discussed this with Rodrigo
while working on ddi buffer initialization.
Matthias, please go ahead and add the Fixes Tag like I mentioned in my previous
message. Thanks for catching this.
Manasi
>
> > On Mon, 2017-07-17 at 11:21 -0700, Matthias Kaehlcke wrote:
> > > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> > > Use the correct table.
> > >
> > > The error was pointed out by this clang warning:
> > >
> > > drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
> > > 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
> > > [-Wunneeded-internal-declaration]
> > > static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
> > >
> > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > > ---
> > > drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > > index efb13582dc73..6fa02e6a7a9b 100644
> > > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > > @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv,
> > > if (dev_priv->vbt.edp.low_vswing) {
> > > if (voltage == VOLTAGE_INFO_0_85V) {
> > > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V);
> > > - return cnl_ddi_translations_dp_0_85V;
> > > + return cnl_ddi_translations_edp_0_85V;
> > > } else if (voltage == VOLTAGE_INFO_0_95V) {
> > > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V);
> > > return cnl_ddi_translations_edp_0_95V;
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-17 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 18:21 [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Matthias Kaehlcke
2017-07-17 18:55 ` [Intel-gfx] " Pandiyan, Dhinakaran
2017-07-17 20:59 ` Pandiyan, Dhinakaran
2017-07-17 21:17 ` Manasi Navare [this message]
2017-07-17 19:21 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717211713.GA6173@intel.com \
--to=manasi.d.navare@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=grundler@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).