dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V
@ 2017-07-17 18:21 Matthias Kaehlcke
  2017-07-17 18:55 ` [Intel-gfx] " Pandiyan, Dhinakaran
  2017-07-17 19:21 ` Manasi Navare
  0 siblings, 2 replies; 5+ messages in thread
From: Matthias Kaehlcke @ 2017-07-17 18:21 UTC (permalink / raw)
  To: Daniel Vetter, Jani Nikula, David Airlie, Daniel Vetter
  Cc: intel-gfx, dri-devel, Linux Kernel Mailing List,
	Stéphane Marchesin, Grant Grundler, Matthias Kaehlcke

For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
Use the correct table.

The error was pointed out by this clang warning:

drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
  'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
  [-Wunneeded-internal-declaration]
    static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index efb13582dc73..6fa02e6a7a9b 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv,
 	if (dev_priv->vbt.edp.low_vswing) {
 		if (voltage == VOLTAGE_INFO_0_85V) {
 			*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V);
-			return cnl_ddi_translations_dp_0_85V;
+			return cnl_ddi_translations_edp_0_85V;
 		} else if (voltage == VOLTAGE_INFO_0_95V) {
 			*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V);
 			return cnl_ddi_translations_edp_0_95V;
-- 
2.13.2.932.g7449e964c-goog

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-07-17 21:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 18:21 [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Matthias Kaehlcke
2017-07-17 18:55 ` [Intel-gfx] " Pandiyan, Dhinakaran
2017-07-17 20:59   ` Pandiyan, Dhinakaran
2017-07-17 21:17     ` Manasi Navare
2017-07-17 19:21 ` Manasi Navare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).