* [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V
@ 2017-07-17 19:58 Matthias Kaehlcke
2017-08-11 18:32 ` Matthias Kaehlcke
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-07-17 19:58 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, David Airlie, Daniel Vetter,
Manasi Navare, rodrigo.vivi, clinton.a.taylor
Cc: Grant Grundler, intel-gfx, Linux Kernel Mailing List, dri-devel,
Stéphane Marchesin, Matthias Kaehlcke
For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
Use the correct table.
The error was pointed out by this clang warning:
drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
---
Changes in v2:
- Added 'Fixes' tag
- Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index efb13582dc73..6fa02e6a7a9b 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv,
if (dev_priv->vbt.edp.low_vswing) {
if (voltage == VOLTAGE_INFO_0_85V) {
*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V);
- return cnl_ddi_translations_dp_0_85V;
+ return cnl_ddi_translations_edp_0_85V;
} else if (voltage == VOLTAGE_INFO_0_95V) {
*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V);
return cnl_ddi_translations_edp_0_95V;
--
2.13.2.932.g7449e964c-goog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V
2017-07-17 19:58 [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Matthias Kaehlcke
@ 2017-08-11 18:32 ` Matthias Kaehlcke
2017-08-11 18:38 ` Rodrigo Vivi
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-08-11 18:32 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, David Airlie, Daniel Vetter,
Manasi Navare, rodrigo.vivi, clinton.a.taylor
Cc: Grant Grundler, intel-gfx, Linux Kernel Mailing List, dri-devel
El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
>
> The error was pointed out by this clang warning:
>
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>
> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> Changes in v2:
> - Added 'Fixes' tag
> - Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
ping, it seems this patch went under the radar.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V
2017-08-11 18:32 ` Matthias Kaehlcke
@ 2017-08-11 18:38 ` Rodrigo Vivi
0 siblings, 0 replies; 3+ messages in thread
From: Rodrigo Vivi @ 2017-08-11 18:38 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: David Airlie, intel-gfx, Linux Kernel Mailing List,
Grant Grundler, DRI mailing list, Vivi, Rodrigo, Daniel Vetter
On Fri, Aug 11, 2017 at 11:32 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
> El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
>
>> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
>> Use the correct table.
>>
>> The error was pointed out by this clang warning:
>>
>> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>> [-Wunneeded-internal-declaration]
>> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>>
>> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>> ---
>> Changes in v2:
>> - Added 'Fixes' tag
>> - Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>
> ping, it seems this patch went under the radar.
yes totally. sorry about that.
merged to dinq. Thanks for patch, review, and heads up
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-11 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 19:58 [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Matthias Kaehlcke
2017-08-11 18:32 ` Matthias Kaehlcke
2017-08-11 18:38 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).