linux-next: build warning after merge of the drm tree

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

Hi all,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/gpu/drm/i915/gvt/cmd_parser.c: In function 'perform_bb_shadow':
drivers/gpu/drm/i915/gvt/cmd_parser.c:1647:8: warning: unused variable 'dst' [-Wunused-variable]
  void *dst = NULL;
        ^

Introduced by commit

  93588e545a4f ("Merge tag 'drm-intel-next-2017-11-17-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-next")

this merge reintroduced the variable declaration removed by commit

  f52c380a48f5 ("drm/i915/gvt: Refine shadow batch buffer")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drm tree

[Dave Airlie]

On 4 December 2017 at 10:30, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:

Oops, not sure how I missed it, force pushed drm-next with the merge fixed.

Dave.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1025 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/list.h:9:0,
                 from include/linux/wait.h:7,
                 from include/linux/wait_bit.h:8,
                 from include/linux/fs.h:6,
                 from include/linux/highmem.h:5,
                 from drivers/gpu/drm/drm_memory.c:36:
drivers/gpu/drm/drm_memory.c: In function 'drm_get_max_iomem':
include/linux/kernel.h:808:16: warning: comparison of distinct pointer types lacks a cast
  (void) (&max1 == &max2);   \
                ^
include/linux/kernel.h:817:2: note: in expansion of macro '__max'
  __max(typeof(x), typeof(y),   \
  ^~~~~
drivers/gpu/drm/drm_memory.c:159:15: note: in expansion of macro 'max'
   max_iomem = max(max_iomem,  tmp->end);
               ^~~

Introduced by commit

  82626363a217 ("drm: add func to get max iomem address v2")

tmp->end is a resource_size_t ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1200 bytes --]

Hi all,

On Mon, 19 Feb 2018 10:18:17 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/list.h:9:0,
>                  from include/linux/wait.h:7,
>                  from include/linux/wait_bit.h:8,
>                  from include/linux/fs.h:6,
>                  from include/linux/highmem.h:5,
>                  from drivers/gpu/drm/drm_memory.c:36:
> drivers/gpu/drm/drm_memory.c: In function 'drm_get_max_iomem':
> include/linux/kernel.h:808:16: warning: comparison of distinct pointer types lacks a cast
>   (void) (&max1 == &max2);   \
>                 ^
> include/linux/kernel.h:817:2: note: in expansion of macro '__max'
>   __max(typeof(x), typeof(y),   \
>   ^~~~~
> drivers/gpu/drm/drm_memory.c:159:15: note: in expansion of macro 'max'
>    max_iomem = max(max_iomem,  tmp->end);
>                ^~~
> 
> Introduced by commit
> 
>   82626363a217 ("drm: add func to get max iomem address v2")
> 
> tmp->end is a resource_size_t ...

I am still getting this warning ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 523 bytes --]

Hi Paul,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/gpu/drm/gma500/mdfld_intel_display.c: In function 'mdfld__intel_pipe_set_base':
drivers/gpu/drm/gma500/mdfld_intel_display.c:170:26: warning: unused variable 'psbfb' [-Wunused-variable]
  struct psb_framebuffer *psbfb = to_psb_fb(fb);
                          ^~~~~

Introduced by commit

  c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 180 bytes --]

Hi all,

On Mon, 25 Jun 2018 14:22:07 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Paul,
     ^^^^
Hmm, not Paul at all :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:160:9: warning: #pragma pack (pop) encountered without matching #pragma pack (push) [-Wpragmas]
 #pragma pack(pop)
         ^~~~

Introduced by commit

  1411fd85416f ("Merge remote-tracking branch 'drm/drm-next'")

Commits

  099139bef026 ("drm/amd/display: Pack DMCU iRAM alignment")

from Linus' tree and

  c591d8429df2 ("drm/amd/display: Pack DMCU iRAM alignment")

from the drm tree are identical, but then commit

  bf75572a2536 ("drm/amd/display: Create switching mechanism for ABM 2.2")

added more code before the "#pragma(pop)" and so git's automatic merge
resolution ended up adding the "#pragma(pop)" line twice.

I will fix up the merge resolution for tomorrow.  This will need to be
reported to Linus when the drm tree is merged (or a back merge of
Linus' tree will need to be done - and well commented :-)).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 337 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-visionox-rm69299.o

Introduced by commit

  c7f66d32dd43 ("drm/panel: add support for rm69299 visionox panel")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Randy Dunlap]

On 5/10/20 8:47 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-visionox-rm69299.o
> 
> Introduced by commit
> 
>   c7f66d32dd43 ("drm/panel: add support for rm69299 visionox panel")
> 

I posted a patch last week:

https://lore.kernel.org/dri-devel/bbb7b3b3-9968-9a1f-8ef6-2e8e3be998f6@infradead.org/

-- 
~Randy

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1267 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_fw_activate':
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
  751 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_attach':
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:1692:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
 1692 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_bridge_hpd_enable':
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2125:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
 2125 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,

Introduced by commit

  fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Tomi Valkeinen]

Hi Stephen,

On 23/09/2020 06:36, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_fw_activate':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>   751 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_attach':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:1692:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>  1692 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_bridge_hpd_enable':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2125:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>  2125 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> 
> Introduced by commit
> 
>   fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge")
> 

Thanks. I think we can just do:

diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index 621ebdbff8a3..d0c65610ebb5 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -748,7 +748,7 @@ static int cdns_mhdp_fw_activate(const struct firmware *fw,
 	 * bridge should already be detached.
 	 */
 	if (mhdp->bridge_attached)
-		writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+		writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
 		       mhdp->regs + CDNS_APB_INT_MASK);
 
 	spin_unlock(&mhdp->start_lock);
@@ -1689,7 +1689,7 @@ static int cdns_mhdp_attach(struct drm_bridge *bridge,
 
 	/* Enable SW event interrupts */
 	if (hw_ready)
-		writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+		writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
 		       mhdp->regs + CDNS_APB_INT_MASK);
 
 	return 0;
@@ -2122,7 +2122,7 @@ static void cdns_mhdp_bridge_hpd_enable(struct drm_bridge *bridge)
 
 	/* Enable SW event interrupts */
 	if (mhdp->bridge_attached)
-		writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+		writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
 		       mhdp->regs + CDNS_APB_INT_MASK);
 }

I'll send a patch.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1426 bytes --]

Hi all,

On Wed, 23 Sep 2020 13:36:01 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_fw_activate':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>   751 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_attach':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:1692:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>  1692 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_bridge_hpd_enable':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2125:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>  2125 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> 
> Introduced by commit
> 
>   fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge")

I am still getting these warnings ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 700 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/gpu/drm-kms:466: drivers/gpu/drm/drm_crtc.c:236: WARNING: Unexpected indentation.
Documentation/gpu/drm-kms:466: drivers/gpu/drm/drm_crtc.c:237: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/gpu/drm-kms:472: drivers/gpu/drm/drm_blend.c:203: WARNING: Unexpected indentation.
Documentation/gpu/drm-kms:472: drivers/gpu/drm/drm_blend.c:204: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  5c759eda9b04 ("drm: Introduce plane and CRTC scaling filter properties")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 864 bytes --]

Hi Stephen,

On Thu, 5 Nov 2020 18:02:50 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/gpu/drm-kms:466: drivers/gpu/drm/drm_crtc.c:236: WARNING: Unexpected indentation.
> Documentation/gpu/drm-kms:466: drivers/gpu/drm/drm_crtc.c:237: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/gpu/drm-kms:472: drivers/gpu/drm/drm_blend.c:203: WARNING: Unexpected indentation.
> Documentation/gpu/drm-kms:472: drivers/gpu/drm/drm_blend.c:204: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Introduced by commit
> 
>   5c759eda9b04 ("drm: Introduce plane and CRTC scaling filter properties")

I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: unmet direct dependencies detected for DRM_I915_WERROR
  Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
  Selected by [m]:
  - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]

WARNING: unmet direct dependencies detected for DRM_I915_WERROR
  Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
  Selected by [m]:
  - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]

WARNING: unmet direct dependencies detected for DRM_I915_WERROR
  Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
  Selected by [m]:
  - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]

Maybe introduced by commit

  4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Daniel Vetter]

On Fri, Jan 22, 2021 at 1:59 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
>   Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
>   Selected by [m]:
>   - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
>   Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
>   Selected by [m]:
>   - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
>   Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
>   Selected by [m]:
>   - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
>
> Maybe introduced by commit
>
>   4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")

Hm that has been in drm-intel-gt-next for a few days, is that tree not
in linux-next?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1097 bytes --]

Hi Daniel,

On Fri, 22 Jan 2021 08:17:58 +0100 Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> Hm that has been in drm-intel-gt-next for a few days, is that tree not
> in linux-next?

It is not.

These are the drm branches currently in linux-next:

drm-fixes	git://git.freedesktop.org/git/drm/drm.git	drm-fixes
amdgpu-fixes	git://people.freedesktop.org/~agd5f/linux	drm-fixes
drm-intel-fixes	git://anongit.freedesktop.org/drm-intel		for-linux-next-fixes
drm-misc-fixes	git://anongit.freedesktop.org/drm/drm-misc	for-linux-next-fixes
drm		git://git.freedesktop.org/git/drm/drm.git	drm-next
amdgpu		https://gitlab.freedesktop.org/agd5f/linux	drm-next
drm-intel	git://anongit.freedesktop.org/drm-intel		for-linux-next
drm-tegra	git://anongit.freedesktop.org/tegra/linux.git	drm/tegra/for-next
drm-misc	git://anongit.freedesktop.org/drm/drm-misc	for-linux-next
drm-msm		https://gitlab.freedesktop.org/drm/msm.git	msm-next
imx-drm		https://git.pengutronix.de/git/pza/linux	imx-drm/next
etnaviv		https://git.pengutronix.de/git/lst/linux	etnaviv/next

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Daniel Vetter]

On Fri, Jan 22, 2021 at 8:29 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Daniel,
>
> On Fri, 22 Jan 2021 08:17:58 +0100 Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > Hm that has been in drm-intel-gt-next for a few days, is that tree not
> > in linux-next?
>
> It is not.

Adding -intel maintainers to get that sorted.
-Daniel

> These are the drm branches currently in linux-next:

Oh for ordering maybe put drm-misc ahead of the other subtrees, -misc
is where nowadays a lot of refactorings and core changes land.
Probably doesn't matter in practice.
-Daniel

> drm-fixes       git://git.freedesktop.org/git/drm/drm.git       drm-fixes
> amdgpu-fixes    git://people.freedesktop.org/~agd5f/linux       drm-fixes
> drm-intel-fixes git://anongit.freedesktop.org/drm-intel         for-linux-next-fixes
> drm-misc-fixes  git://anongit.freedesktop.org/drm/drm-misc      for-linux-next-fixes
> drm             git://git.freedesktop.org/git/drm/drm.git       drm-next
> amdgpu          https://gitlab.freedesktop.org/agd5f/linux      drm-next
> drm-intel       git://anongit.freedesktop.org/drm-intel         for-linux-next
> drm-tegra       git://anongit.freedesktop.org/tegra/linux.git   drm/tegra/for-next
> drm-misc        git://anongit.freedesktop.org/drm/drm-misc      for-linux-next
> drm-msm         https://gitlab.freedesktop.org/drm/msm.git      msm-next
> imx-drm         https://git.pengutronix.de/git/pza/linux        imx-drm/next
> etnaviv         https://git.pengutronix.de/git/lst/linux        etnaviv/next
>
> --
> Cheers,
> Stephen Rothwell



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Joonas Lahtinen]

(+ Tvrtko who was recently added as a drm/i915 co-maintainer)

Quoting Daniel Vetter (2021-01-22 10:40:48)
> On Fri, Jan 22, 2021 at 8:29 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi Daniel,
> >
> > On Fri, 22 Jan 2021 08:17:58 +0100 Daniel Vetter <daniel@ffwll.ch> wrote:
> > >
> > > Hm that has been in drm-intel-gt-next for a few days, is that tree not
> > > in linux-next?
> >
> > It is not.

Hi Stephen,

We should be now good to go and add drm-intel-gt-next to linux-next.

The branch would be as follows:

drm-intel-gt-next	git://anongit.freedesktop.org/drm-intel	for-linux-next-gt

Notice the "-gt" and the end of the for-linux-next branch name. This should eliminate
the gap we have been having. The change to add it to the DIM tool is here:

https://gitlab.freedesktop.org/drm/maintainer-tools/-/commit/7b5c2c29cdbc054e8c8fce38f095c56290fc4833

So once all developers have updated their tooling (for which they will
get an automatic nag message) we should be all up-to-date for future
merge windows.

Regards, Joonas

> Adding -intel maintainers to get that sorted.
> -Daniel
> 
> > These are the drm branches currently in linux-next:
> 
> Oh for ordering maybe put drm-misc ahead of the other subtrees, -misc
> is where nowadays a lot of refactorings and core changes land.
> Probably doesn't matter in practice.
> -Daniel
> 
> > drm-fixes       git://git.freedesktop.org/git/drm/drm.git       drm-fixes
> > amdgpu-fixes    git://people.freedesktop.org/~agd5f/linux       drm-fixes
> > drm-intel-fixes git://anongit.freedesktop.org/drm-intel         for-linux-next-fixes
> > drm-misc-fixes  git://anongit.freedesktop.org/drm/drm-misc      for-linux-next-fixes
> > drm             git://git.freedesktop.org/git/drm/drm.git       drm-next
> > amdgpu          https://gitlab.freedesktop.org/agd5f/linux      drm-next
> > drm-intel       git://anongit.freedesktop.org/drm-intel         for-linux-next
> > drm-tegra       git://anongit.freedesktop.org/tegra/linux.git   drm/tegra/for-next
> > drm-misc        git://anongit.freedesktop.org/drm/drm-misc      for-linux-next
> > drm-msm         https://gitlab.freedesktop.org/drm/msm.git      msm-next
> > imx-drm         https://git.pengutronix.de/git/pza/linux        imx-drm/next
> > etnaviv         https://git.pengutronix.de/git/lst/linux        etnaviv/next
> >
> > --
> > Cheers,
> > Stephen Rothwell
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

Hi Joonas,

On Wed, 27 Oct 2021 15:12:44 +0300 Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
>
> We should be now good to go and add drm-intel-gt-next to linux-next.
> 
> The branch would be as follows:
> 
> drm-intel-gt-next	git://anongit.freedesktop.org/drm-intel	for-linux-next-gt
> 
> Notice the "-gt" and the end of the for-linux-next branch name. This should eliminate
> the gap we have been having.

I have added it to linux-next from today. I called it just
"drm-intel-gt" for consistency with the other drm trees in linux-next.

Currently I just have you listed as a contact, is there anyone else (or
a list) that I should add?

Thanks for adding your subsystem tree as a participant of linux-next.  As
you may know, this is not a judgement of your code.  The purpose of
linux-next is for integration testing and to lower the impact of
conflicts between subsystems in the next merge window. 

You will need to ensure that the patches/commits in your tree/series have
been:
     * submitted under GPL v2 (or later) and include the Contributor's
        Signed-off-by,
     * posted to the relevant mailing list,
     * reviewed by you (or another maintainer of your subsystem tree),
     * successfully unit tested, and 
     * destined for the current or next Linux merge window.

Basically, this should be just what you would send to Linus (or ask him
to fetch).  It is allowed to be rebased if you deem it necessary.

-- 
Cheers,
Stephen Rothwell 
sfr@canb.auug.org.au

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Joonas Lahtinen]

Quoting Stephen Rothwell (2021-10-27 23:51:55)
> Hi Joonas,
> 
> On Wed, 27 Oct 2021 15:12:44 +0300 Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> >
> > We should be now good to go and add drm-intel-gt-next to linux-next.
> > 
> > The branch would be as follows:
> > 
> > drm-intel-gt-next     git://anongit.freedesktop.org/drm-intel for-linux-next-gt
> > 
> > Notice the "-gt" and the end of the for-linux-next branch name. This should eliminate
> > the gap we have been having.
> 
> I have added it to linux-next from today.

Thanks!

> I called it just
> "drm-intel-gt" for consistency with the other drm trees in linux-next.

We use the drm-intel-gt-next as the branch name in repo and DIM tolling, so if
we are after consistenty consistency, using the full name probably makes
sense. drm-intel-gt-next for name keeps open the option for separating
the drm-intel-gt-fixes too, if we decide to do so in the future.

> Currently I just have you listed as a contact, is there anyone else (or
> a list) that I should add?

Please do add Tvrtko (Cc'd). I guess it might make sense adding Jani and
Rodrigo too, as backups. Similarly Tvrtko could be added to the other
drm-intel-* trees. Doesn't hurt to have more eyes especially if some
folks are on a vacation.

Regards, Joonas

> Thanks for adding your subsystem tree as a participant of linux-next.  As
> you may know, this is not a judgement of your code.  The purpose of
> linux-next is for integration testing and to lower the impact of
> conflicts between subsystems in the next merge window. 
> 
> You will need to ensure that the patches/commits in your tree/series have
> been:
>      * submitted under GPL v2 (or later) and include the Contributor's
>         Signed-off-by,
>      * posted to the relevant mailing list,
>      * reviewed by you (or another maintainer of your subsystem tree),
>      * successfully unit tested, and 
>      * destined for the current or next Linux merge window.
> 
> Basically, this should be just what you would send to Linus (or ask him
> to fetch).  It is allowed to be rebased if you deem it necessary.
> 
> -- 
> Cheers,
> Stephen Rothwell 
> sfr@canb.auug.org.au
> 
> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1164 bytes --]

Hi all,

On Fri, 22 Jan 2021 11:59:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
>   Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
>   Selected by [m]:
>   - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
> 
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
>   Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
>   Selected by [m]:
>   - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
> 
> WARNING: unmet direct dependencies detected for DRM_I915_WERROR
>   Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y]
>   Selected by [m]:
>   - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m]
> 
> Maybe introduced by commit
> 
>   4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 587 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/rockchip/rockchip_drm_vop.c: In function 'vop_plane_atomic_update':
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:882:26: warning: unused variable 'old_state' [-Wunused-variable]
  882 |  struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
      |                          ^~~~~~~~~

Introduced by commit

  977697e20b3d ("drm/atomic: Pass the full state to planes atomic disable and update")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 350 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

include/drm/gpu_scheduler.h:304: warning: Function parameter or member '_score' not described in 'drm_gpu_scheduler'

Introduced by commit

  f2f12eb9c32b ("drm/scheduler: provide scheduler score externally")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 350 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'

Introduced by commit

  cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 507 bytes --]

Hi all,

On Thu, 1 Apr 2021 18:19:33 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'
> 
> Introduced by commit
> 
>   cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.")

I am still seeing this warning (as of next-20210420).
-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'

Introduced by commit

  30598d925d46 ("drm/privacy_screen: Add drvdata in drm_privacy_screen")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi all,

On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'

Actually:

drivers/gpu/drm/drm_privacy_screen.c:392: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Hans de Goede]

Hi,

On 2/2/22 05:03, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the drm tree, today's linux-next build (htmldocs) produced
>> this warning:
>>
>> drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'
> 
> Actually:
> 
> drivers/gpu/drm/drm_privacy_screen.c:392: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'

Thank you for reporting this, I will prepare a patch fixing this.

Regards,

Hans

Re: linux-next: build warning after merge of the drm tree

[Rajat Jain]

On Wed, Feb 2, 2022 at 12:38 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 2/2/22 05:03, Stephen Rothwell wrote:
> > Hi all,
> >
> > On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> After merging the drm tree, today's linux-next build (htmldocs) produced
> >> this warning:
> >>
> >> drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'
> >
> > Actually:
> >
> > drivers/gpu/drm/drm_privacy_screen.c:392: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'
>
> Thank you for reporting this, I will prepare a patch fixing this.

Thank you so much Hans!

Best Regards,

Rajat

>
> Regards,
>
> Hans
>

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi all,

On Wed, 2 Feb 2022 09:38:37 +0100 Hans de Goede <hdegoede@redhat.com> wrote:
> 
> On 2/2/22 05:03, Stephen Rothwell wrote:
> > 
> > On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> >>
> >> After merging the drm tree, today's linux-next build (htmldocs) produced
> >> this warning:
> >>
> >> drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'  
> > 
> > Actually:
> > 
> > drivers/gpu/drm/drm_privacy_screen.c:392: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'  
> 
> Thank you for reporting this, I will prepare a patch fixing this.

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Hans de Goede]

Hi,

On 3/2/22 02:34, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 2 Feb 2022 09:38:37 +0100 Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> On 2/2/22 05:03, Stephen Rothwell wrote:
>>>
>>> On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
>>>>
>>>> After merging the drm tree, today's linux-next build (htmldocs) produced
>>>> this warning:
>>>>
>>>> drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'  
>>>
>>> Actually:
>>>
>>> drivers/gpu/drm/drm_privacy_screen.c:392: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'  
>>
>> Thank you for reporting this, I will prepare a patch fixing this.
> 
> I am still seeing this warning.

Weird, this should be fixed by:

https://cgit.freedesktop.org/drm-misc/commit/?id=ccbeca4ca04302d129602093c8d611065e3f7958

Which was added to the "drm-misc-next-2022-02-23" drm-misc tag/pull-req 7 days ago,
which was merged into drm-next 6 days ago ?

I just reverted that did a make htmldocs and got the warning, then re-applied and
the warning was gone...

Regards,

Hans

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

Hi Hans,

On Wed, 2 Mar 2022 11:32:37 +0100 Hans de Goede <hdegoede@redhat.com> wrote:
>
> On 3/2/22 02:34, Stephen Rothwell wrote:
> > Hi all,
> > 
> > On Wed, 2 Feb 2022 09:38:37 +0100 Hans de Goede <hdegoede@redhat.com> wrote:  
> >>
> >> On 2/2/22 05:03, Stephen Rothwell wrote:  
> >>>
> >>> On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> >>>>
> >>>> After merging the drm tree, today's linux-next build (htmldocs) produced
> >>>> this warning:
> >>>>
> >>>> drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'    
> >>>
> >>> Actually:
> >>>
> >>> drivers/gpu/drm/drm_privacy_screen.c:392: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register'    
> >>
> >> Thank you for reporting this, I will prepare a patch fixing this.  
> > 
> > I am still seeing this warning.  
> 
> Weird, this should be fixed by:
> 
> https://cgit.freedesktop.org/drm-misc/commit/?id=ccbeca4ca04302d129602093c8d611065e3f7958
> 
> Which was added to the "drm-misc-next-2022-02-23" drm-misc tag/pull-req 7 days ago,
> which was merged into drm-next 6 days ago ?
> 
> I just reverted that did a make htmldocs and got the warning, then re-applied and
> the warning was gone...

As I said in my other reply, the drm tree has had build problems until
today and so it has been only partly included in linux-next.  I can
confirm that the warning is gone in today's tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

include/drm/drm_connector.h:637: warning: Function parameter or member 'edid_hdmi_rgb444_dc_modes' not described in 'drm_display_info'
include/drm/drm_connector.h:637: warning: Function parameter or member 'edid_hdmi_ycbcr444_dc_modes' not described in 'drm_display_info'

Introduced by commit

  4adc33f36d80 ("drm/edid: Split deep color modes between RGB and YUV444")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Hi all,

On Wed, 2 Feb 2022 15:10:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/drm/drm_connector.h:637: warning: Function parameter or member 'edid_hdmi_rgb444_dc_modes' not described in 'drm_display_info'
> include/drm/drm_connector.h:637: warning: Function parameter or member 'edid_hdmi_ycbcr444_dc_modes' not described in 'drm_display_info'
> 
> Introduced by commit
> 
>   4adc33f36d80 ("drm/edid: Split deep color modes between RGB and YUV444")

I am still seeing these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (KCONFIG_NAME)
produced this warning:

drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not described in 'i915_perf_stream'

Introduced by commit

  2db609c01495 ("drm/i915/perf: Replace gt->perf.lock with stream->lock for file ops")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[John Harrison]

On 11/6/2022 19:29, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm tree, today's linux-next build (KCONFIG_NAME)
> produced this warning:
>
> drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not described in 'i915_perf_stream'
>
> Introduced by commit
>
>    2db609c01495 ("drm/i915/perf: Replace gt->perf.lock with stream->lock for file ops")
>
Yes, a fix has been posted - 
https://patchwork.freedesktop.org/series/110633/

It is unclear how this escaped. It wasn't spotted in code review but 
moreover, the CI pre-merge doc build returned clean for that patch set 
(https://patchwork.freedesktop.org/series/107584/).

John.

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

drivers/gpu/drm/drm_atomic_state_helper.c:560: warning: Cannot understand  * @drm_atomic_helper_connector_tv_check: Validate an analog TV connector state
 on line 560 - I thought it was a doc line

Introduced by commit

  5a28cefda3a9 ("drm/atomic-helper: Add an analog TV atomic_check implementation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

drivers/gpu/drm/drm_connector.c:1849: warning: bad line:

Introduced by commit

  7d63cd8526f1 ("drm/connector: Add TV standard property")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

include/drm/drm_connector.h:203: warning: Enum value 'DRM_MODE_TV_MODE_MAX' not described in enum 'drm_connector_tv_mode'

Introduced by commit

  7d63cd8526f1 ("drm/connector: Add TV standard property")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:32: WARNING: Inline emphasis start-string without end-string.
Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:57: WARNING: Inline emphasis start-string without end-string.
Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:66: WARNING: Inline emphasis start-string without end-string.

Introduced by commit

  0c3064cf33fb ("drm/i915/doc: Document where to implement register workarounds")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Gustavo Sousa]

On Fri, Feb 03, 2023 at 01:46:22PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:32: WARNING: Inline emphasis start-string without end-string.
> Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:57: WARNING: Inline emphasis start-string without end-string.
> Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:66: WARNING: Inline emphasis start-string without end-string.
> 
> Introduced by commit
> 
>   0c3064cf33fb ("drm/i915/doc: Document where to implement register workarounds")
> 

Hello all.

First of all, sorry about that!

There is already a patch[1] in intel-gfx mailing list fixing that and it has
already received an r-b. It just needs to be applied by a maintainer.

[1] https://patchwork.freedesktop.org/series/113193/

--
Gustavo Sousa

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

include/uapi/linux/sync_file.h:77: warning: Function parameter or member 'num_fences' not described in 'sync_file_info'

Revealed by commit

  d71c11cc79d2 ("dma-buf/sync_file: Surface sync-file uABI")

Introduced by commit

  2d75c88fefb2 ("staging/android: refactor SYNC IOCTLs")

in 2016.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Rob Clark]

On Wed, Mar 29, 2023 at 8:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/uapi/linux/sync_file.h:77: warning: Function parameter or member 'num_fences' not described in 'sync_file_info'
>

thanks, should be fixed by:

https://patchwork.freedesktop.org/series/115871/

> Revealed by commit
>
>   d71c11cc79d2 ("dma-buf/sync_file: Surface sync-file uABI")
>
> Introduced by commit
>
>   2d75c88fefb2 ("staging/android: refactor SYNC IOCTLs")
>
> in 2016.
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

Hi all,

On Thu, 30 Mar 2023 07:28:26 -0700 Rob Clark <robdclark@chromium.org> wrote:
>
> On Wed, Mar 29, 2023 at 8:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the drm tree, today's linux-next build (htmldocs) produced
> > this warning:
> >
> > include/uapi/linux/sync_file.h:77: warning: Function parameter or member 'num_fences' not described in 'sync_file_info'
> >  
> 
> thanks, should be fixed by:
> 
> https://patchwork.freedesktop.org/series/115871/
> 
> > Revealed by commit
> >
> >   d71c11cc79d2 ("dma-buf/sync_file: Surface sync-file uABI")
> >
> > Introduced by commit
> >
> >   2d75c88fefb2 ("staging/android: refactor SYNC IOCTLs")
> >
> > in 2016.

I am still getting this warning (presumably now from Linus' tree).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

Hi all,

On Wed, 12 Jul 2023 09:17:14 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 30 Mar 2023 07:28:26 -0700 Rob Clark <robdclark@chromium.org> wrote:
> >
> > On Wed, Mar 29, 2023 at 8:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > After merging the drm tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > >
> > > include/uapi/linux/sync_file.h:77: warning: Function parameter or member 'num_fences' not described in 'sync_file_info'
> > >    
> > 
> > thanks, should be fixed by:
> > 
> > https://patchwork.freedesktop.org/series/115871/
> >   
> > > Revealed by commit
> > >
> > >   d71c11cc79d2 ("dma-buf/sync_file: Surface sync-file uABI")
> > >
> > > Introduced by commit
> > >
> > >   2d75c88fefb2 ("staging/android: refactor SYNC IOCTLs")
> > >
> > > in 2016.  
> 
> I am still getting this warning (presumably now from Linus' tree).

I am still getting this warning despite the patch from Rob being
available since March 30.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

drivers/gpu/drm/i915/i915_perf.c:5307: warning: Function parameter or member 'i915' not described in 'i915_perf_ioctl_version'

Introduced by commit

  94d82e95219a ("drm/i915/perf: Pass i915 object to perf revision helper")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/i915/gt/uc/intel_guc.h:274: warning: Function parameter or member 'dbgfs_node' not described in 'intel_guc'

Introduced by commit

  70b5ffb393f3 ("drm/i915/gt: Create per-gt debugfs files")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Andi Shyti]

Hi Stephen,

On Tue, Apr 11, 2023 at 04:02:36PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/gpu/drm/i915/gt/uc/intel_guc.h:274: warning: Function parameter or member 'dbgfs_node' not described in 'intel_guc'
> 
> Introduced by commit
> 
>   70b5ffb393f3 ("drm/i915/gt: Create per-gt debugfs files")

that's mine to take... will fix it!

Thanks!

Andi

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/gpu/imagination/uapi.rst:124: WARNING: Title underline too short.

CREATE_HWRT_DATASET and DESTROY_HWRT_DATASET
--------------------------------------

Introduced by commit

  815d8b0425ad ("drm/imagination: Add driver documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

drivers/gpu/drm/imagination/pvr_drv.c:1: warning: 'PowerVR Graphics Driver' not found

Introduced by commit

  815d8b0425ad ("drm/imagination: Add driver documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

include/uapi/drm/pvr_drm.h:1: warning: 'Flags for DRM_PVR_DEV_QUERY_HEAP_INFO_GET.' not found

Introduced by commit

  1088d89e5515 ("drm/imagination/uapi: Add PowerVR driver UAPI")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Donald Robson]

Hi Stephen,

Thanks for the report.  I've fixed these locally, along with a few other doc issues
I found.  I'll get the patch out as soon as I can.

Thanks,
Donald

On Fri, 2023-11-24 at 13:25 +1100, Stephen Rothwell wrote:
> *** CAUTION: This email originates from a source not known to Imagination Technologies. Think before you click a link or open an attachment ***
> 
> Hi all,
> 
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/uapi/drm/pvr_drm.h:1: warning: 'Flags for DRM_PVR_DEV_QUERY_HEAP_INFO_GET.' not found
> 
> Introduced by commit
> 
>   1088d89e5515 ("drm/imagination/uapi: Add PowerVR driver UAPI")
> 

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2348 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

In file included from include/drm/drm_mm.h:51,
                 from drivers/gpu/drm/xe/xe_bo_types.h:11,
                 from drivers/gpu/drm/xe/xe_bo.h:11,
                 from drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h:11,
                 from drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:15,
                 from drivers/gpu/drm/i915/display/intel_display_power.c:8:
drivers/gpu/drm/i915/display/intel_display_power.c: In function 'print_async_put_domains_state':
drivers/gpu/drm/i915/display/intel_display_power.c:408:29: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=]
  408 |         drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
  409 |                 power_domains->async_put_wakeref);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                              |
      |                              int
include/drm/drm_print.h:410:39: note: in definition of macro 'drm_dev_dbg'
  410 |         __drm_dev_dbg(NULL, dev, cat, fmt, ##__VA_ARGS__)
      |                                       ^~~
include/drm/drm_print.h:510:33: note: in expansion of macro 'drm_dbg_driver'
  510 | #define drm_dbg(drm, fmt, ...)  drm_dbg_driver(drm, fmt, ##__VA_ARGS__)
      |                                 ^~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_power.c:408:9: note: in expansion of macro 'drm_dbg'
  408 |         drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
      |         ^~~~~~~
drivers/gpu/drm/i915/display/intel_display_power.c:408:50: note: format string is defined here
  408 |         drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
      |                                                ~~^
      |                                                  |
      |                                                  long unsigned int
      |                                                %u

Introduced by commit

  b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library")

This would be an error except that I am building with CONFIG_WERROR=n
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 4906 bytes --]

Hi all,

On Tue, 2 Jan 2024 11:12:22 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> In file included from include/drm/drm_mm.h:51,
>                  from drivers/gpu/drm/xe/xe_bo_types.h:11,
>                  from drivers/gpu/drm/xe/xe_bo.h:11,
>                  from drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h:11,
>                  from drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:15,
>                  from drivers/gpu/drm/i915/display/intel_display_power.c:8:
> drivers/gpu/drm/i915/display/intel_display_power.c: In function 'print_async_put_domains_state':
> drivers/gpu/drm/i915/display/intel_display_power.c:408:29: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=]
>   408 |         drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
>   409 |                 power_domains->async_put_wakeref);
>       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                              |
>       |                              int
> 
> Introduced by commit
> 
>   b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library")
> 
> This would be an error except that I am building with CONFIG_WERROR=n

OK, so I have turned off CONFIG_WERROR=n in the run up to the merge
window opening and so this is now a build failure.  I have tried
applying the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 3 Jan 2024 11:40:26 +1100
Subject: [PATCH] fix up for "drm/i915: Replace custom intel runtime_pm tracker
 with ref_tracker library"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 5f091502719b..f23080a4368d 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -405,7 +405,7 @@ print_async_put_domains_state(struct i915_power_domains *power_domains)
 						     struct drm_i915_private,
 						     display.power.domains);
 
-	drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
+	drm_dbg(&i915->drm, "async_put_wakeref %u\n",
 		power_domains->async_put_wakeref);
 
 	print_power_domains(power_domains, "async_put_domains[0]",
-- 
2.43.0

but that produces this failure:

In file included from include/drm/ttm/ttm_resource.h:34,
                 from include/drm/ttm/ttm_device.h:30,
                 from drivers/gpu/drm/i915/i915_drv.h:37,
                 from drivers/gpu/drm/i915/display/intel_display_power.c:8:  
drivers/gpu/drm/i915/display/intel_display_power.c: In function 'print_async_put_domains_state':
drivers/gpu/drm/i915/display/intel_display_power.c:408:29: error: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'intel_wakeref_t' {aka 'long unsigned int'} [-Werror=format=]
  408 |         drm_dbg(&i915->drm, "async_put_wakeref %u\n",
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~
  409 |                 power_domains->async_put_wakeref);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                              |
      |                              intel_wakeref_t {aka long unsigned int}

I don't understand how the above patch can change the compilation like
that.  I must be missing something obvious.  Maybe my compiler is
strangely broken?  I have applied the following instead (which at least
builds):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 3 Jan 2024 11:40:26 +1100
Subject: [PATCH] fix up for "drm/i915: Replace custom intel runtime_pm tracker
 with ref_tracker library"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 5f091502719b..6253ce061d20 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -406,7 +406,7 @@ print_async_put_domains_state(struct i915_power_domains *power_domains)
 						     display.power.domains);
 
 	drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
-		power_domains->async_put_wakeref);
+		(unsigned long int)power_domains->async_put_wakeref);
 
 	print_power_domains(power_domains, "async_put_domains[0]",
 			    &power_domains->async_put_domains[0]);
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2936 bytes --]

Hi all,

On Wed, 3 Jan 2024 12:19:11 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 2 Jan 2024 11:12:22 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > In file included from include/drm/drm_mm.h:51,
> >                  from drivers/gpu/drm/xe/xe_bo_types.h:11,
> >                  from drivers/gpu/drm/xe/xe_bo.h:11,
> >                  from drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h:11,
> >                  from drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:15,
> >                  from drivers/gpu/drm/i915/display/intel_display_power.c:8:
> > drivers/gpu/drm/i915/display/intel_display_power.c: In function 'print_async_put_domains_state':
> > drivers/gpu/drm/i915/display/intel_display_power.c:408:29: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=]
> >   408 |         drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
> >       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
> >   409 |                 power_domains->async_put_wakeref);
> >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >       |                              |
> >       |                              int
> > 
>
> In file included from include/drm/ttm/ttm_resource.h:34,
>                  from include/drm/ttm/ttm_device.h:30,
>                  from drivers/gpu/drm/i915/i915_drv.h:37,
>                  from drivers/gpu/drm/i915/display/intel_display_power.c:8:  
> drivers/gpu/drm/i915/display/intel_display_power.c: In function 'print_async_put_domains_state':
> drivers/gpu/drm/i915/display/intel_display_power.c:408:29: error: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'intel_wakeref_t' {aka 'long unsigned int'} [-Werror=format=]
>   408 |         drm_dbg(&i915->drm, "async_put_wakeref %u\n",
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~
>   409 |                 power_domains->async_put_wakeref);
>       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                              |
>       |                              intel_wakeref_t {aka long unsigned int}
> 
> I don't understand how the above patch can change the compilation like
> that.  I must be missing something obvious.  Maybe my compiler is
> strangely broken?

OK, the only thing I can find is that there are 2 intel_wakeref.h files
that have different definitions for intel_wakeref_t:

./drivers/gpu/drm/i915/intel_wakeref.h:typedef unsigned long intel_wakeref_t;
./drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h:typedef bool intel_wakeref_t;

and the two compilations above seem to use different include paths, but
how the single character change causes that is beyond me.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Jani Nikula]

On Wed, 03 Jan 2024, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> OK, the only thing I can find is that there are 2 intel_wakeref.h files
> that have different definitions for intel_wakeref_t:
>
> ./drivers/gpu/drm/i915/intel_wakeref.h:typedef unsigned long intel_wakeref_t;
> ./drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h:typedef bool intel_wakeref_t;
>
> and the two compilations above seem to use different include paths, but
> how the single character change causes that is beyond me.

There are a few things going on here, but the gist of it is that
intel_wakeref_t is supposed to be an opaque cookie, and printing its
value does not make sense, especially not when you can't be certain
which printf format should be used for it.

Fix at [1], thanks for the report.

BR,
Jani.


[1] https://patchwork.freedesktop.org/patch/msgid/20240104164600.783371-1-jani.nikula@intel.com


-- 
Jani Nikula, Intel

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs) produced
this warning:

Warning: /sys/devices/.../hwmon/hwmon<i>/curr1_crit is defined 2 times:  /home/s
fr/next/next/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:35  /home/sfr
/next/next/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:52
Warning: /sys/devices/.../hwmon/hwmon<i>/energy1_input is defined 2 times:  /hom
e/sfr/next/next/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:54  /home/
sfr/next/next/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:65
Warning: /sys/devices/.../hwmon/hwmon<i>/in0_input is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:46  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:0
Warning: /sys/devices/.../hwmon/hwmon<i>/power1_crit is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:22  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:39
Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:0  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:8
Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max_interval is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:62  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:30
Warning: /sys/devices/.../hwmon/hwmon<i>/power1_rated_max is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:14  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:22

Introduced by commits

  fb1b70607f73 ("drm/xe/hwmon: Expose power attributes")
  92d44a422d0d ("drm/xe/hwmon: Expose card reactive critical power")
  fbcdc9d3bf58 ("drm/xe/hwmon: Expose input voltage attribute")
  71d0a32524f9 ("drm/xe/hwmon: Expose hwmon energy attribute")
  4446fcf220ce ("drm/xe/hwmon: Expose power1_max_interval")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]

Hi all,

On Fri, 5 Jan 2024 17:47:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the drm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Warning: /sys/devices/.../hwmon/hwmon<i>/curr1_crit is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:35  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:52
> Warning: /sys/devices/.../hwmon/hwmon<i>/energy1_input is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:54  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:65
> Warning: /sys/devices/.../hwmon/hwmon<i>/in0_input is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:46  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:0
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_crit is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:22  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:39
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:0  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:8
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max_interval is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:62  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:30
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_rated_max is defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:14  Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:22
> 
> Introduced by commits
> 
>   fb1b70607f73 ("drm/xe/hwmon: Expose power attributes")
>   92d44a422d0d ("drm/xe/hwmon: Expose card reactive critical power")
>   fbcdc9d3bf58 ("drm/xe/hwmon: Expose input voltage attribute")
>   71d0a32524f9 ("drm/xe/hwmon: Expose hwmon energy attribute")
>   4446fcf220ce ("drm/xe/hwmon: Expose power1_max_interval")

I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Thomas Hellström]

On Thu, 2024-01-25 at 11:33 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Fri, 5 Jan 2024 17:47:45 +1100 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the drm tree, today's linux-next build (htmldocs)
> > produced
> > this warning:
> > 
> > Warning: /sys/devices/.../hwmon/hwmon<i>/curr1_crit is defined 2
> > times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:35 
> > Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:52
> > Warning: /sys/devices/.../hwmon/hwmon<i>/energy1_input is defined 2
> > times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:54 
> > Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:65
> > Warning: /sys/devices/.../hwmon/hwmon<i>/in0_input is defined 2
> > times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:46 
> > Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:0
> > Warning: /sys/devices/.../hwmon/hwmon<i>/power1_crit is defined 2
> > times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:22 
> > Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:39
> > Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max is defined 2
> > times:  Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:0 
> > Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:8
> > Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max_interval is
> > defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-
> > hwmon:62  Documentation/ABI/testing/sysfs-driver-intel-i915-
> > hwmon:30
> > Warning: /sys/devices/.../hwmon/hwmon<i>/power1_rated_max is
> > defined 2 times:  Documentation/ABI/testing/sysfs-driver-intel-xe-
> > hwmon:14  Documentation/ABI/testing/sysfs-driver-intel-i915-
> > hwmon:22
> > 
> > Introduced by commits
> > 
> >   fb1b70607f73 ("drm/xe/hwmon: Expose power attributes")
> >   92d44a422d0d ("drm/xe/hwmon: Expose card reactive critical
> > power")
> >   fbcdc9d3bf58 ("drm/xe/hwmon: Expose input voltage attribute")
> >   71d0a32524f9 ("drm/xe/hwmon: Expose hwmon energy attribute")
> >   4446fcf220ce ("drm/xe/hwmon: Expose power1_max_interval")
> 
> I am still getting these warnings.
> 

We're looking at fixing those.

Thanks,
Thomas

linux-next: build warning after merge of the drm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Hi all,

After merging the drm tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/gpu/rfc/index.rst:35: WARNING: toctree contains reference to nonexisting document 'gpu/rfc/xe'

Introduced by commit

  d11dc7aa98e5 ("drm/doc/rfc: Remove Xe's pre-merge plan")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm tree

[Rodrigo Vivi]

On Wed, Feb 07, 2024 at 05:17:19PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/gpu/rfc/index.rst:35: WARNING: toctree contains reference to nonexisting document 'gpu/rfc/xe'
> 
> Introduced by commit
> 
>   d11dc7aa98e5 ("drm/doc/rfc: Remove Xe's pre-merge plan")

It should be fixed by commit 70a46e1fda3b ("drm/doc/rfc: Removing missing reference to xe.rst")
that is part of drm-misc/drm-misc-next and drm-misc/for-linux-next

> 
> -- 
> Cheers,
> Stephen Rothwell