* [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
@ 2018-10-09 0:23 Manasi Navare
2018-10-09 13:43 ` Ville Syrjälä
0 siblings, 1 reply; 6+ messages in thread
From: Manasi Navare @ 2018-10-09 0:23 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Jani Nikula
VESA eDP 1.4 specification has separate fields defined in
EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions.
This patch defines those. Found this when one of my eDP panels
advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
include/drm/drm_dp_helper.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2a3843f248cf..9ad98e8d9ede 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -685,6 +685,8 @@
# define DP_EDP_12 0x01
# define DP_EDP_13 0x02
# define DP_EDP_14 0x03
+# define DP_EDP_14a 0x04 /* eDP 1.4a */
+# define DP_EDP_14b 0x05 /* eDP 1.4b */
#define DP_EDP_GENERAL_CAP_1 0x701
# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
2018-10-09 0:23 [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b Manasi Navare
@ 2018-10-09 13:43 ` Ville Syrjälä
2018-10-09 14:32 ` Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ville Syrjälä @ 2018-10-09 13:43 UTC (permalink / raw)
To: Manasi Navare; +Cc: Jani Nikula, intel-gfx, dri-devel
On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote:
> VESA eDP 1.4 specification has separate fields defined in
> EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions.
> This patch defines those. Found this when one of my eDP panels
> advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 2a3843f248cf..9ad98e8d9ede 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -685,6 +685,8 @@
> # define DP_EDP_12 0x01
> # define DP_EDP_13 0x02
> # define DP_EDP_14 0x03
> +# define DP_EDP_14a 0x04 /* eDP 1.4a */
> +# define DP_EDP_14b 0x05 /* eDP 1.4b */
The comments seem a bit redundant.
Either way
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> #define DP_EDP_GENERAL_CAP_1 0x701
> # define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
> --
> 2.18.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
2018-10-09 13:43 ` Ville Syrjälä
@ 2018-10-09 14:32 ` Jani Nikula
2018-10-09 19:32 ` Manasi Navare
2018-10-09 19:34 ` Manasi Navare
2018-10-20 0:18 ` Manasi Navare
2 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2018-10-09 14:32 UTC (permalink / raw)
To: Ville Syrjälä, Manasi Navare; +Cc: intel-gfx, dri-devel
On Tue, 09 Oct 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote:
>> VESA eDP 1.4 specification has separate fields defined in
>> EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions.
>> This patch defines those. Found this when one of my eDP panels
>> advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
>>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
>> ---
>> include/drm/drm_dp_helper.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index 2a3843f248cf..9ad98e8d9ede 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -685,6 +685,8 @@
>> # define DP_EDP_12 0x01
>> # define DP_EDP_13 0x02
>> # define DP_EDP_14 0x03
>> +# define DP_EDP_14a 0x04 /* eDP 1.4a */
>> +# define DP_EDP_14b 0x05 /* eDP 1.4b */
>
> The comments seem a bit redundant.
>
> Either way
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
So I guess we'll need code changing our == checks to >= checks.
BR,
Jani.
>
>>
>> #define DP_EDP_GENERAL_CAP_1 0x701
>> # define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
>> --
>> 2.18.0
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
2018-10-09 14:32 ` Jani Nikula
@ 2018-10-09 19:32 ` Manasi Navare
0 siblings, 0 replies; 6+ messages in thread
From: Manasi Navare @ 2018-10-09 19:32 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, dri-devel
On Tue, Oct 09, 2018 at 05:32:49PM +0300, Jani Nikula wrote:
> On Tue, 09 Oct 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote:
> >> VESA eDP 1.4 specification has separate fields defined in
> >> EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions.
> >> This patch defines those. Found this when one of my eDP panels
> >> advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
> >>
> >> Cc: Jani Nikula <jani.nikula@intel.com>
> >> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> >> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> >> ---
> >> include/drm/drm_dp_helper.h | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> >> index 2a3843f248cf..9ad98e8d9ede 100644
> >> --- a/include/drm/drm_dp_helper.h
> >> +++ b/include/drm/drm_dp_helper.h
> >> @@ -685,6 +685,8 @@
> >> # define DP_EDP_12 0x01
> >> # define DP_EDP_13 0x02
> >> # define DP_EDP_14 0x03
> >> +# define DP_EDP_14a 0x04 /* eDP 1.4a */
> >> +# define DP_EDP_14b 0x05 /* eDP 1.4b */
> >
> > The comments seem a bit redundant.
> >
> > Either way
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> So I guess we'll need code changing our == checks to >= checks.
>
We already have >= check in edp_init_dpcd and then in compute_config,
we check for < DP_EDP_14 to set to max link rate /lane count.
So checks wise we shuld be good for now.
Manasi
> BR,
> Jani.
>
> >
> >>
> >> #define DP_EDP_GENERAL_CAP_1 0x701
> >> # define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
> >> --
> >> 2.18.0
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
2018-10-09 13:43 ` Ville Syrjälä
2018-10-09 14:32 ` Jani Nikula
@ 2018-10-09 19:34 ` Manasi Navare
2018-10-20 0:18 ` Manasi Navare
2 siblings, 0 replies; 6+ messages in thread
From: Manasi Navare @ 2018-10-09 19:34 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx, dri-devel
On Tue, Oct 09, 2018 at 04:43:51PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote:
> > VESA eDP 1.4 specification has separate fields defined in
> > EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions.
> > This patch defines those. Found this when one of my eDP panels
> > advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > ---
> > include/drm/drm_dp_helper.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index 2a3843f248cf..9ad98e8d9ede 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -685,6 +685,8 @@
> > # define DP_EDP_12 0x01
> > # define DP_EDP_13 0x02
> > # define DP_EDP_14 0x03
> > +# define DP_EDP_14a 0x04 /* eDP 1.4a */
> > +# define DP_EDP_14b 0x05 /* eDP 1.4b */
>
> The comments seem a bit redundant.
>
Thanks for the review.
I added the comments since for all other defs there is comment of
eDP 1.2 at the top of defs.
If you feel strongly about it I can remove the comments before merging.
What do you think?
Manasi
> Either way
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> >
> > #define DP_EDP_GENERAL_CAP_1 0x701
> > # define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
> > --
> > 2.18.0
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
2018-10-09 13:43 ` Ville Syrjälä
2018-10-09 14:32 ` Jani Nikula
2018-10-09 19:34 ` Manasi Navare
@ 2018-10-20 0:18 ` Manasi Navare
2 siblings, 0 replies; 6+ messages in thread
From: Manasi Navare @ 2018-10-20 0:18 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx, dri-devel
Thanks for the review.
Pushed to drm-misc
Manasi
On Tue, Oct 09, 2018 at 04:43:51PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote:
> > VESA eDP 1.4 specification has separate fields defined in
> > EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions.
> > This patch defines those. Found this when one of my eDP panels
> > advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > ---
> > include/drm/drm_dp_helper.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index 2a3843f248cf..9ad98e8d9ede 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -685,6 +685,8 @@
> > # define DP_EDP_12 0x01
> > # define DP_EDP_13 0x02
> > # define DP_EDP_14 0x03
> > +# define DP_EDP_14a 0x04 /* eDP 1.4a */
> > +# define DP_EDP_14b 0x05 /* eDP 1.4b */
>
> The comments seem a bit redundant.
>
> Either way
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> >
> > #define DP_EDP_GENERAL_CAP_1 0x701
> > # define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
> > --
> > 2.18.0
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-20 0:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 0:23 [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b Manasi Navare
2018-10-09 13:43 ` Ville Syrjälä
2018-10-09 14:32 ` Jani Nikula
2018-10-09 19:32 ` Manasi Navare
2018-10-09 19:34 ` Manasi Navare
2018-10-20 0:18 ` Manasi Navare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).