Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol - Lee Jones via dri-devel

From: Lee Jones via dri-devel <dri-devel@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
	Alexander Shiyan <shc_work@mail.ru>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
Date: Thu, 14 Feb 2019 08:12:43 +0000	[thread overview]
Message-ID: <20190214081243.GH1863@dell> (raw)
In-Reply-To: <CAKMK7uHaYAXW2k9Fkb4c365=GQ-y9pDm2n10=k+-xMgX0shgyw@mail.gmail.com>

On Wed, 13 Feb 2019, Daniel Vetter wrote:

> On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via
> dri-devel <dri-devel@lists.freedesktop.org> wrote:
> >
> >
> > On 02/12/2019 09:42 AM, Lee Jones wrote:
> > > On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
> > >
> > >>
> > >> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
> > >>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
> > >>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> > >>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
> > >>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> > >>>> and converts LCD_CLASS_DEVICE into a menu.
> > >>>>
> > >>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > >>>
> > >>> A cover letter with the v1 -> v2 changelog would be nice... but
> > >>> nevertheless:
> > >>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> > >>
> > >> Also:
> > >>
> > >> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > >>
> > >> Lee, will you pick this up or do you want me to do it?
> > >
> > > You can take them if you want.  I will require a pull-request from an
> > > independent immutable branch though please.
> >
> > OK, immutable branch will also allow other trees (drm) to sync with
> > these changes if desired.
> >
> > I will do it for v5.2 if you are fine with it (too late for v5.1
> > IMHO and I also won't have time too fix any potential issues next
> > week).
> 
> Topic branch for these 2 simple patches seems like serious overkill.
> Especially for backlight stuff, which doesn't move fast. Anyway, up to
> you, ack for all the drm patches to go through whatever tree you
> people can agree on. Would be good to get it into 5.1 still though,
> just to avoid too many conflicts.

It takes me approx 1 min to set-up an immutable branch.

If you think it's too much work, I can set it up for you.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel