Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

From: Lee Jones <lee.jones@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
	Alexander Shiyan <shc_work@mail.ru>,
	Jingoo Han <jingoohan1@gmail.com>,
	Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
Date: Wed, 20 Mar 2019 10:07:08 +0000	[thread overview]
Message-ID: <20190320100708.GM4731@dell> (raw)
In-Reply-To: <64fd6532-83da-333d-279b-748a34428f97@samsung.com>

> >> On 02/12/2019 09:42 AM, Lee Jones wrote:
> >>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
> >>>
> >>>>
> >>>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
> >>>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
> >>>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> >>>>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
> >>>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> >>>>>> and converts LCD_CLASS_DEVICE into a menu.
> >>>>>>
> >>>>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> >>>>>
> >>>>> A cover letter with the v1 -> v2 changelog would be nice... but
> >>>>> nevertheless:
> >>>>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >>>>
> >>>> Also:
> >>>>
> >>>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >>>>
> >>>> Lee, will you pick this up or do you want me to do it?
> >>>
> >>> You can take them if you want.  I will require a pull-request from an
> >>> independent immutable branch though please.
> >>
> >> OK, immutable branch will also allow other trees (drm) to sync with
> >> these changes if desired.
> >>
> >> I will do it for v5.2 if you are fine with it (too late for v5.1
> >> IMHO and I also won't have time too fix any potential issues next
> >> week).

> > Topic branch for these 2 simple patches seems like serious overkill.

[...]

> > Would be good to get it into 5.1 still though, just to avoid too
> > many conflicts. 

I think you just answered your own statement. :)

> Well, if so I'm also fine with this going in 5.1 w/o topic branch.
> 
> Lee, do you want to merge this directly into backlight tree (you
> have now both fbdev and drm acks)?

It was too late for v5.1.

Do you still want to take this for v5.2, or should I take them and
provide you with an immutable pull-request?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel