From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: eben@raspberrypi.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Sean Paul <seanpaul@chromium.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Daniel Vetter <daniel.vetter@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data
Date: Tue, 5 Mar 2019 09:08:48 +0100 [thread overview]
Message-ID: <20190305080848.jifr5rgcz2rejlz5@flea> (raw)
In-Reply-To: <87imwymyki.fsf@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1733 bytes --]
On Mon, Mar 04, 2019 at 05:47:09PM +0200, Jani Nikula wrote:
> On Mon, 04 Mar 2019, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > In some cases, in order to accomodate with displays with poor EDIDs, we
> > need to ignore that the monitor alledgedly supports audio output and
> > disable the audio output.
>
> *sad trombone*
>
> Trying to figure this out automatically in kernel is better than a
> quirk.
>
> A quirk is better than requiring the user to provide an override EDID
> via the firmware loader (drm.edid_firmware parameter).
>
> Requiring an override EDID is better than adding a module parameter.
>
> I'd much rather we exhausted the other options before adding module
> parameters to address specific issues with EDIDs. That's a rabbit hole
> with no end.
We should also consider the usability of these solutions.
Sure, the quirks are the ideal solution long term, but do we really
expect the average user that just got its device from Amazon and
connected it to its display to figure out:
- That if it's display doesn't work, it's because the display is
broken
- That it is broken due to poor EDIDs
- To find out that it's supposed to be handled in DRM through a quirk
- How to make such a quirk
- How to recompile the kernel on its distro of choice
- That they need to send a patch later on to upstream Linux, and then
wait for a year or so (depending on their distro) before it's
actually working.
Chances are that they would stop at 1, call the device trash and never
submit any quirk, therefore making the quirk approach useless in the
process.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-05 8:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 14:52 [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Maxime Ripard
2019-03-04 14:52 ` [PATCH 1/7] drm/vc4: hdmi: Check that the monitor supports HDMI audio Maxime Ripard
2019-03-04 15:10 ` Paul Kocialkowski
2019-03-04 15:54 ` Stefan Wahren
2019-03-04 18:28 ` Eric Anholt
2019-03-04 20:06 ` Stefan Wahren
2019-03-04 21:09 ` Eric Anholt
2019-03-04 14:52 ` [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Maxime Ripard
2019-03-04 15:47 ` Jani Nikula
2019-03-04 15:51 ` Adam Jackson
2019-03-05 8:08 ` Maxime Ripard [this message]
2019-03-05 10:33 ` Jani Nikula
2019-03-05 15:08 ` Adam Jackson
2019-03-04 15:59 ` Ville Syrjälä
2019-03-04 19:53 ` Eric Anholt
2019-03-04 20:05 ` Alex Deucher
2019-03-05 9:12 ` Maxime Ripard
2019-03-05 15:24 ` Ville Syrjälä
2019-03-05 19:15 ` Ville Syrjälä
2019-03-05 19:21 ` Alex Deucher
2019-03-05 19:36 ` Ville Syrjälä
2019-03-13 10:44 ` Takashi Iwai
2019-03-13 14:03 ` Maxime Ripard
2019-03-05 18:11 ` Eric Anholt
2019-03-11 13:07 ` Daniel Vetter
2019-03-05 21:47 ` Eric Anholt
2019-03-06 8:52 ` Maxime Ripard
2019-03-06 13:22 ` Maxime Ripard
2019-03-06 17:51 ` Eric Anholt
2019-03-04 14:52 ` [PATCH 3/7] drm/edid: Allow to ignore the HDMI monitor mode Maxime Ripard
2019-03-04 15:14 ` Paul Kocialkowski
2019-03-04 15:48 ` Jani Nikula
2019-03-04 20:02 ` Eric Anholt
2019-03-05 9:24 ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 4/7] drm/modes: Rewrite the command line parser Maxime Ripard
2019-03-04 14:52 ` [PATCH 5/7] drm/modes: Support modes names on the command line Maxime Ripard
2019-03-04 14:52 ` [PATCH 6/7] drm/modes: Allow to specify rotation and reflection on the commandline Maxime Ripard
2019-03-04 14:52 ` [PATCH 7/7] drm/modes: Parse overscan properties Maxime Ripard
2019-03-04 15:21 ` [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Peter Stuge
2019-03-04 15:56 ` Maxime Ripard
2019-03-04 15:44 ` Stefan Wahren
2019-03-04 20:06 ` Eric Anholt
2019-03-05 9:14 ` Maxime Ripard
2019-03-11 13:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305080848.jifr5rgcz2rejlz5@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eben@raspberrypi.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=seanpaul@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).