dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Sean Paul <seanpaul@chromium.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: Fix Display Engine DTC warnings
Date: Fri, 15 Mar 2019 09:57:10 +0100	[thread overview]
Message-ID: <20190315085710.taefcdrwrdiwfrvw@flea> (raw)
In-Reply-To: <CAGb2v67D6DbaaPHRw6zachx7C9psH0-5srLEypR3565F6mzaEg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1568 bytes --]

Hi,

On Fri, Mar 15, 2019 at 10:28:16AM +0800, Chen-Yu Tsai wrote:
> > diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
> > index 1111a6498102..4484d76c88b5 100644
> > --- a/arch/arm/boot/dts/sun8i-a33.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a33.dtsi
> > @@ -266,18 +266,9 @@
> >                         phy-names = "dphy";
> >                         status = "disabled";
> >
> > -                       ports {
> > -                               #address-cells = <1>;
> > -                               #size-cells = <0>;
> > -
> > -                               port@0 {
> > -                                       #address-cells = <1>;
> > -                                       #size-cells = <0>;
> > -                                       reg = <0>;
> > -
> > -                                       dsi_in_tcon0: endpoint {
> > -                                               remote-endpoint = <&tcon0_out_dsi>;
> > -                                       };
> > +                       port {
> > +                               dsi_in_tcon0: endpoint {
> > +                                       remote-endpoint = <&tcon0_out_dsi>;
> 
> Shouldn't we expect to see an output port as well?

DSI panels are not using the OF Graph, but are subnodes of the DSI
controller itself. It's kind of odd when we have to mix the two, but
that means we'll never get an output endpoint for the DSI node.

Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-15  8:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic Maxime Ripard
2019-03-15  2:43   ` Chen-Yu Tsai
2019-03-15  8:38     ` Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 02/13] drm/sun4i: mixer: " Maxime Ripard
2019-03-15  2:44   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 03/13] ARM: dts: sun8i: a83t: Add cross links for the mixers Maxime Ripard
2019-03-15  2:53   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 04/13] arm64: dts: allwinner: a64: " Maxime Ripard
2019-03-15  2:54   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 05/13] ARM: dts: sun5i: Fix display pipeline endpoint warnings in DTC Maxime Ripard
2019-03-15  2:29   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 06/13] ARM: dts: sun5i: Fix Display Engine DTC warnings Maxime Ripard
2019-03-15  2:30   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 07/13] ARM: dts: sun6i: " Maxime Ripard
2019-03-15  2:29   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: " Maxime Ripard
2019-03-15  2:28   ` Chen-Yu Tsai
2019-03-15  8:57     ` Maxime Ripard [this message]
2019-03-14 20:16 ` [PATCH v2 09/13] ARM: dts: sun8i: v3s: " Maxime Ripard
2019-03-15  2:32   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 10/13] ARM: dts: sun8i: a83t: " Maxime Ripard
2019-03-15  2:34   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 11/13] ARM: dts: sun8i: r40: " Maxime Ripard
2019-03-15  2:35   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 12/13] ARM: dts: sun9i: " Maxime Ripard
2019-03-15  2:35   ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address Maxime Ripard
2019-03-15  2:39   ` Chen-Yu Tsai
2019-03-15  9:02     ` Maxime Ripard
2019-03-15  9:09       ` Chen-Yu Tsai
2019-03-15  9:16         ` Maxime Ripard
2019-03-15 10:22           ` Chen-Yu Tsai
2019-03-15 11:58             ` Maxime Ripard
2019-03-15  9:08 ` [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315085710.taefcdrwrdiwfrvw@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=seanpaul@chromium.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).